Jelle van der Waa
ea30aecb67
Coccinelle labels refactor ( #3947 )
...
Follow up of https://github.com/oxc-project/oxc/pull/3946
2024-06-27 19:11:46 -04:00
Jelle van der Waa
1cca2a8d92
refactor(eslint): convert with_labels to with_label where applicable ( #3946 )
...
Following earlier work in d6437fec0bhttps://github.com/oxc-project/oxc/pull/3854 and in my recent
pull requests. The Linux kernel uses Coccinelle to automatically
converted helper functions, so I was wondering if there was something
similar for Rust as Coccinelle only does C. It turns out that there is a
[Coccinelle for
Rust](https://gitlab.inria.fr/coccinelle/coccinelleforrust ), so I wrote
a small Coccinelle rule to automatically convert all rules. (This PR
only touches eslint, I am happy to run it for the whole rules directory,
this is more a test if the project is willing to accept such massive
automatic refactors).
To convert this automatically build the tool, and save the snippet below
as `with_labels.cocci` and run:
```
~/code/coccinelleforrust/target/debug/cfr --apply --coccifile with_labels.cocci crates/oxc_linter/src/rules/eslint
```
with_labels.cocci:
```
@@
expression E, OxcDiagnostic;
@@
OxcDiagnostic.
- with_labels([E.into()])
+ with_label(E)
```
2024-06-27 15:11:19 -04:00
github-actions[bot]
4e3e1a39eb
Release crates v0.16.0 ( #3930 )
...
## [0.16.0] - 2024-06-26
- 6796891#3898 ) (rzvxa)
- 1f85f1a#3899 ) (rzvxa)
- ae09a97#3846 )
(Boshen)
- 1af5ed3#3845 ) (Boshen)
- 0673677#3844 ) (Boshen)
- ee6ec4e#3841 ) (Boshen)
- 9b38119#3839 ) (Boshen)
- cfcef24#3830 ) (Boshen)
- 4456034#3820 ) (Boshen)
### Features
- 497769c#3785 ) (Dunqing)
- 4b06dc7#3775 )
(Dunqing)
- 5847e16#3767 ) (Boshen)
- 2e026e1#3888 ) (rzvxa)
- 09f4d3c#3852 ) (rzvxa)
- 3e78f98#3771 ) (rzvxa)
- 01da2f7#3792 ) (Dunqing)
- 2821e0e#3791 )
(Dunqing)
- 97575d8#3786 )
(Dunqing)
- 5e2baf3#3872 ) (Dunqing)
- 2cdb34f#3811 ) (Dunqing)
- 231b8f0#3809 ) (Dunqing)
- a37138f#3797 ) (Dunqing)
- b0d7355#3793 ) (Dunqing)
- b38c34d#3769 ) (Dunqing)
- 4134de8#3755 ) (Dunqing)
- 94202de#3754 )
(Dunqing)
- e95d8e3#3752 ) (Dunqing)
- df9971d#3750 ) (Dunqing)
- 4aea2b1#3749 ) (Dunqing)
- 9ea30c4#3748 ) (Dunqing)
- dd540c8#3803 ) (Boshen)
- f3c3970#3802 )
(Boshen)
- 4fb90eb#3765 ) (Boshen)
- d5f6aeb#3838 ) (Don
Isaac)
- 01572f0#3902 )
(DonIsaac)
- 5501d5c#3866 ) (Dunqing)
- 2a16ce0#3794 ) (Boshen)- d3cd3ea#3896 ) (underfin)
### Bug Fixes
- 063cfde#3858 )
(overlookmotel)
- 66f404c#3856 )
(overlookmotel)
- 2766594#3922 )
(Dunqing)
- 27f0531#3921 ) (Dunqing)
- 59ce38b#3920 ) (Dunqing)
- 58e54f4#3810 )
(Dunqing)
- cb8a272#3807 )
(Dunqing)
- d8ecce5#3806 ) (Dunqing)
- 4e241fc#3805 ) (Dunqing)
- 683c7b0#3804 ) (Dunqing)
- 7d47fc3#3790 ) (Dunqing)
- 8ce794d#3768 ) (Dunqing)
- d29316a#3753 ) (Dunqing)
- bf1c250#3751 ) (Dunqing)
- 275349a#3926 )
(Boshen)
- ef82c78#3885 ) (Dunqing)
- 13754cb#3853 ) (Boshen)
- 8c9fc63#3861 ) (overlookmotel)
- 99a40ce#3823 ) (Boshen)
- 08fcfb3#3911 )
(overlookmotel)
- 17ad8f7#3908 ) (overlookmotel)
- d76f34b#3837 )
(overlookmotel)
- e470731#3833 ) (overlookmotel)
- d774e54#3832 ) (overlookmotel)
- ff1da27#3831 )
(overlookmotel)
- 6dcc3f4#3816 )
(overlookmotel)
- aea3e9a#3782 ) (overlookmotel)
### Performance
- 92c21b2#3897 )
(Luca Bruno)
- 4bf405d#3894 ) (Boshen)
- 10d1de5#3867 )
(DonIsaac)- 4f7ff7e#3818 )
(overlookmotel)
### Refactor
- 6f26087#3905 ) (overlookmotel)
- 442aca3#3891 )
(overlookmotel)
- acf69fa#3859 ) (overlookmotel)
- 9e148e9#3860 ) (overlookmotel)
- 363d3d5#3855 )
(rzvxa)
- a648748#3835 ) (overlookmotel)
- 1206967#3834 ) (overlookmotel)
- 2f5d50e#3847 ) (Boshen)
- 8027b1e#3801 )
(Boshen)
- a471e62#3925 ) (Boshen)
- 3db2553#3923 )
(Boshen)
- 4cf3c76#3903 ) (Boshen)
- 187f078#3892 ) (Boshen)
- 97d59fc#3849 )
(Boshen)
- 5ef28b7#3912 ) (overlookmotel)
- d9f268d#3836 ) (overlookmotel)
- 21b0d01#3781 ) (overlookmotel)
- 7c44703#3774 ) (overlookmotel)
- 22c56d7#3764 ) (overlookmotel)
- cd56aa9#3762 )
(overlookmotel)
- 512740d#3760 ) (overlookmotel)
- 1061baa#3901 ) (overlookmotel)
- fcd21a6#3882 ) (overlookmotel)
- 24979c9#3880 )
(overlookmotel)
- 2045c92#3879 )
(overlookmotel)- d6437fe#3854 )
(Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-27 20:38:31 +08:00
underfin
9e8709f06e
fix(sourcemap): should add tokens for unordered span ( #3941 )
...
close: https://github.com/oxc-project/oxc/issues/3843
2024-06-27 20:24:22 +08:00
github-actions[bot]
06e4ce4f5d
Release oxlint v0.5.0 ( #3940 )
...
## [0.5.0] - 2024-06-27
- 6796891#3898 ) (rzvxa)
- ae09a97#3846 )
(Boshen)
- 1af5ed3#3845 ) (Boshen)
- ee6ec4e#3841 ) (Boshen)
- 4456034#3820 ) (Boshen)
- 0537d29#3728 ) (rzvxa)
- 5c38a0f#3740 ) (Boshen)
- 4bce59d#3722 ) (rzvxa)
### Features
- 3ae2628#3928 )
(Boshen)
- a89d501#3850 ) (kaykdm)
- fc48cb4#3865 )
(cinchen)
- 63b98bd#3842 )
(mysteryven)
- 328445b#3717 )
(mysteryven)
- 8c61f9c#3825 ) (kaykdm)
- 080ecbd#3673 ) (rzvxa)
- 9493fbe#3700 )
(mysteryven)
- 139adfe#3699 ) (mysteryven)
- 5f84500#3812 )
(Jelle van der Waa)
- fafe67c#3814 ) (Jelle van
der Waa)
- d5f6aeb#3838 ) (Don
Isaac)
### Bug Fixes
- 4bd2c88#3777 ) (rzvxa)
- 1190dee#3714 ) (rzvxa)
- de0690f#3693 )
(Boshen)
- cf71c23#3672 ) (rzvxa)
- 5902331#3889 ) (Luca Bruno)
- 99a40ce#3823 ) (Boshen)
- abd6ac8#3671 ) (rzvxa)
### Performance
- 4f7ff7e#3818 ) (overlookmotel)
### Refactor
- 4d2b7f1#3761 ) (rzvxa)
- 7302429#3822 ) (Boshen)
- d8ad321#3737 )
(rzvxa)
### Testing
- 887da40#3766 ) (rzvxa)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-27 15:09:13 +08:00
Boshen
cd4bd6ec7f
chore(linter): change getter-return to nursery
...
relates #3935
2024-06-27 14:38:43 +08:00
Boshen
37fceefbbf
chore(linter): change no-fallthrough to pedantic
...
Because the code is still correct.
2024-06-27 14:37:44 +08:00
Boshen
3ae2628832
feat(linter): change no-import-assign to correctness ( #3928 )
...
closes #3733
2024-06-26 22:43:45 +08:00
Jelle van der Waa
5f84500200
feat(linter/eslint-plugin-react): Implement prefer-es6-class ( #3812 )
...
Rule Detail:
[link](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/prefer-es6-class.md )
---------
Co-authored-by: Boshen <boshenc@gmail.com>
2024-06-26 22:20:16 +08:00
kaykdm
a89d501d51
feat(linter): implement @typescript-eslint/no-non-null-asserted-nulli… ( #3850 )
...
…sh-coalescing
Related issue: https://github.com/oxc-project/oxc/issues/2180
original implementation
- code:
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/no-non-null-asserted-nullish-coalescing.ts
- test:
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/no-non-null-asserted-nullish-coalescing.test.ts
- doc:
https://typescript-eslint.io/rules/no-non-null-asserted-nullish-coalescing/
2024-06-26 21:57:33 +08:00
underfin
d3cd3ea2de
feat: oxc transform binding ( #3896 )
...
closes #3877
---------
Co-authored-by: Boshen <boshenc@gmail.com>
2024-06-26 21:57:19 +08:00
cinchen
fc48cb4560
feat(linter): eslint-plugin-jest/prefer-jest-mocked ( #3865 )
...
part of https://github.com/oxc-project/oxc/issues/492
Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/prefer-jest-mocked.ts )
2024-06-26 21:46:46 +08:00
Boshen
275349a9fe
fix(parser): parse function type parameter name accessor ( #3926 )
...
fixes #3910
2024-06-26 13:34:24 +00:00
mysteryven
63b98bddd9
feat(linter): accept multiple fixes when fix code ( #3842 )
...
Want to add this because of there are bunch of fix codes in [consistent-type-import](e408b93e48/packages/eslint-plugin/src/rules/consistent-type-imports.ts (L610-L945)
2024-06-26 13:29:22 +00:00
Boshen
a471e62e2d
refactor(parser): clean up try_parse ( #3925 )
2024-06-26 11:18:02 +00:00
Dunqing
27665945f1
fix(codegen): print type parameters for MethodDefinition ( #3922 )
...
close : #3918
2024-06-26 07:21:42 +00:00
Dunqing
27f0531aac
fix(isolated-declarations): private constructor reaching unreachable ( #3921 )
...
fix : #3917
2024-06-26 07:21:38 +00:00
Dunqing
59ce38bb85
fix(isolated-declarations): inferring of UnrayExpression incorrectly ( #3920 )
...
close : #3914
2024-06-26 07:21:35 +00:00
Boshen
3db2553dc2
refactor(parser): improve parsing of TypeScript type arguments ( #3923 )
2024-06-26 07:16:18 +00:00
Boshen
4cf3c7645f
refactor(parser): improve parsing of TypeScript types ( #3903 )
...
- [x] fix everything
2024-06-26 05:58:16 +00:00
overlookmotel
1061baabbf
refactor(traverse): separate #[scope] attr ( #3901 )
...
Separate out attributes which communicate info to codegen related to scopes into `#[scope]` attr.
Before:
```rs
#[visited_node(scope(ScopeFlags::empty()))]
pub struct BlockStatement<'a> { /* ... */ }
```
After:
```rs
#[visited_node]
#[scope]
pub struct BlockStatement<'a> { /* ... */ }
```
I think this is clearer.
2024-06-26 05:43:10 +00:00
overlookmotel
5ef28b7375
refactor(transformer): shorten code ( #3912 )
...
Abbreviate `self.ctx.ast` to just `ast` to shorten code.
2024-06-26 05:16:07 +00:00
overlookmotel
08fcfb3c2f
fix(transformer): fix spans and scopes in TS enum transform ( #3911 )
...
Fix scope and spans in TS `enum` transform.
Incomplete - not yet fixed either scopes or spans for the interior of the function which TS `enum` is transformed into, only what's outside the function.
2024-06-26 05:16:05 +00:00
overlookmotel
17ad8f7d93
fix(transformer): create new scopes for new blocks in TS transform ( #3908 )
...
Create scopes for new `BlockStatement`s inserted in TS transform, and update scope tree.
2024-06-26 05:16:02 +00:00
DonIsaac
01572f037d
feat(sourcemap): impl std::fmt::Display for Error ( #3902 )
2024-06-26 05:10:48 +00:00
camc314
77a4a0b77c
feat(minifier) minify conditional expressions ( #3907 )
2024-06-26 05:06:53 +00:00
overlookmotel
6f260871d7
refactor(ast): add comment about alternatives to AstBuilder::copy ( #3905 )
...
Expand on comment added in #3891 .
2024-06-25 18:45:06 +00:00
Jelle van der Waa
fafe67c817
feat(linter/import): Implement max-dependencies ( #3814 )
...
Rule Detail:
[link](https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/max-dependencies.md )
---
This lacks the handling of `require()` which seems to be the case for
most existing `import` rules.
Another "issue" could be if you have:
```
import { foo } from "./foo";
import { bar } from "./foo";
```
But then again there should be another rule to filter these duplicate
imports out and combine them into one.
Co-authored-by: Don Isaac <donald.isaac@gmail.com>
2024-06-25 13:18:01 -04:00
rzvxa
2e026e1b7f
feat(ast_codegen): generate ast_kind.rs. ( #3888 )
...
[List of 68 blacklisted items](https://github.com/oxc-project/oxc/pull/3888/files#diff-59cbea4a1444e752992821d3429a5f27bf1027a530977d075ec89aa55995912aR11 )
2024-06-25 15:47:04 +00:00
rzvxa
6796891e2e
fix(ast)!: rename all instances of BigintLiteral to BigIntLiteral. ( #3898 )
...
Notice the casing! Just for the sake of consistency.
2024-06-25 14:39:42 +00:00
rzvxa
09f4d3c4d3
feat(ast_codegen): add ImplGetSpanGenerator. ( #3852 )
...
This one is ready to replace the handwritten module.
2024-06-25 14:39:39 +00:00
Luca Bruno
92c21b266e
perf(diagnostics): optimize string-buffer reallocations ( #3897 )
...
This improves `GraphicalReportHandler` logic by using a string-buffer
with a capacity hint. That avoids growing the buffer from zero each
time, saving a bunch of reallocations.
2024-06-25 17:55:53 +08:00
rzvxa
1f85f1a5f7
refactor(ast)!: revert adding span field to the BindingPattern type. ( #3899 )
...
Since this is a temporary solution in the time that we are waiting for the `#[span]` hint, And there are already other workarounds used in our `ast_codegen` I propose removing it right away - sorry in my opinion adding it in the first place was a mistake - in favor of adding an edge case in the codegen. It is better to do the refactoring in the codegen instead of the production code which people may depend on.
2024-06-25 09:43:48 +00:00
Boshen
4bf405ddfc
perf(parser): add a few more inline hints to cursor functions ( #3894 )
2024-06-25 06:00:46 +00:00
Boshen
187f0782c1
refactor(parser): improve parsing of parse_function_or_constructor_type ( #3892 )
...
part of #3502
2024-06-25 03:43:02 +00:00
overlookmotel
442aca3ba8
refactor(ast): add comment not to use AstBuilder::copy ( #3891 )
...
As discussed in #3483 , `AstBuilder::copy` is unsound. It's going to be a
hard slog removing all uses of it. This PR adds a comment to please not
introduce any further usages of it in meantime.
2024-06-25 09:12:43 +08:00
mysteryven
328445b4ca
feat(linter): support vitest/no-disabled-tests ( #3717 )
2024-06-24 15:16:32 +00:00
Dunqing
ef82c78a72
fix(parser): trailing comma is not allowed in ParenthesizedExpression ( #3885 )
...
close : #3878
The implementation is copied from `SeparatedList`'s `print_list`.
```diff
fn parse_list(&mut self, p: &mut ParserImpl<'a>) -> Result<()> {
p.expect(self.open())?;
let mut first = true;
while !p.at(self.close()) && !p.at(Kind::Eof) {
if first {
first = false;
} else {
p.expect(self.separator())?;
- if p.at(self.close()) {
- break;
- }
}
self.parse_element(p)?;
}
p.expect(self.close())?;
Ok(())
}
```
2024-06-24 14:56:32 +00:00
overlookmotel
fcd21a6a75
refactor(traverse): indicate scope entry point with scope(enter_before) attr ( #3882 )
...
Improve annotation of AST types for codegen.
Currently:
```rs
#[visited_node(
scope(ScopeFlags::empty()),
enter_scope_before(cases),
)]
pub struct SwitchStatement<'a> {
pub span: Span,
pub discriminant: Expression<'a>,
pub cases: Vec<'a, SwitchCase<'a>>,
pub scope_id: Cell<Option<ScopeId>>,
}
```
After this PR:
```rs
#[visited_node(scope(ScopeFlags::empty()))]
pub struct SwitchStatement<'a> {
pub span: Span,
pub discriminant: Expression<'a>,
#[scope(enter_before)]
pub cases: Vec<'a, SwitchCase<'a>>,
pub scope_id: Cell<Option<ScopeId>>,
}
```
I think this is easier to read.
In order to enable use of `#[scope]` attr, this introduces a dummy `VisitedNode` derive macro. Like the `visited_node` macro, `VisitedNode` derive macro is designed to do very minimal work and have no heavy dependencies, so it should be almost 0 cost in terms of compile time.
2024-06-24 14:12:15 +00:00
overlookmotel
24979c98b2
refactor(traverse): use camel case props internally ( #3880 )
...
Small change to internals of `oxc_traverse` codegen. Use camel-case property names.
2024-06-24 13:19:34 +00:00
overlookmotel
2045c92338
refactor(traverse): improve parsing attrs in traverse codegen ( #3879 )
...
Make parser in `oxc_traverse` codegen a bit more robust - handle trailing comma in `#[visited_node]` attrs.
2024-06-24 13:19:31 +00:00
Boshen
7f1266a37b
chore(deps): update rust crates ( #3873 )
2024-06-24 11:24:54 +00:00
Dunqing
5e2baf3edd
feat(isolated-declarations): report error for expando functions ( #3872 )
...
close : #3703
2024-06-24 10:56:23 +00:00
kaykdm
8c61f9c0b4
feat(linter): implement @typescript-eslint/no-non-null-assertion ( #3825 )
...
Related issue: https://github.com/oxc-project/oxc/issues/2180
original implementation
- code:
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/no-non-null-assertion.ts
- test:
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/tests/rules/no-non-null-assertion.test.ts
- doc: https://typescript-eslint.io/rules/no-non-null-assertion/
typescript-eslint has a feature that is manually fixable by editor
suggestions on this rule, but oxc does not have one as far as I know, so
the implementation is simple compared to typescript-eslint
2024-06-24 00:09:52 -04:00
Dunqing
5501d5ce33
feat(transformer/typescript): transform import {} from "mod" to import "mod" ( #3866 )
...
close : #3736
2024-06-24 03:27:39 +00:00
DonIsaac
10d1de584b
perf(semantic): remove uneccessary allocation in builder ( #3867 )
2024-06-24 02:57:08 +00:00
overlookmotel
8c9fc6347d
fix(semantic): apply strict mode scope flag for strict mode TS Modules ( #3861 )
...
#3830 added a `directives` field to `TSModuleBlock`. Make semantic apply strict mode scope flag if directives include `'use strict'`.
2024-06-24 02:38:59 +00:00
overlookmotel
acf69fa1b6
refactor(ast): refactor custom Serialize impls ( #3859 )
...
Store `&[T]` instead of `&Vec<'a, T>` in temp structures in custom `Serialize` impls. Slightly cleaner and removes some lifetimes.
2024-06-24 02:31:59 +00:00
overlookmotel
063cfdeb40
fix(ast): correct JSON serialization of TSModuleBlock ( #3858 )
...
Fix #3848 .
#3830 added a `directives` field to `TSModuleBlock`. ESTree AST treats directives in module blocks as `StringLiteral`s. Add a custom `Serialize` impl to combine any directives back into `body` in JS AST.
NB: `#[serde(skip)]` attr on `directives` field is for benefit of `Tsify` derive macro, so TS defs match the actual JSON AST.
2024-06-24 02:25:49 +00:00
overlookmotel
66f404c2f3
fix(ast): fix JSON serialization of BindingPattern ( #3856 )
...
#3855 added a `span` field to `BindingPattern` but it's duplicate information from `BindingPatternKind`. `BindingPatternKind`'s `span` is already included in JS AST, so serde can skip the duplicate in `BindingPattern`.
2024-06-24 02:21:40 +00:00
