Dunqing
ace4f1ff77
refactor(semantic): update the order of visit_function and Visit fields in the builder to be consistent ( #4248 )
...
Same as #4195
2024-07-14 11:39:15 +00:00
Dunqing
8bfeabfe6a
refactor(semantic): simplify adding SymbolFlags::Export ( #4249 )
...
```ts
export default class Binding {}
// ^^^^^^^ SymbolFlags::Export
export default function Binding () {}
// ^^^^^^^ SymbolFlags::Export
// No binding, so we should not have SymbolFlags::Export
export default function() {}
export default class {}
```
2024-07-14 11:39:13 +00:00
Dunqing
3e099febf6
refactor(ast): move enter_scope after visit_binding_identifier ( #4246 )
...
This is now consistent with other ASTs that require bind
2019043e72/crates/oxc_ast/src/ast/ts.rs (L814-L815)
2024-07-14 04:06:02 +00:00
Dunqing
dc2b3c44fb
refactor(semantic): add strict mode in scope flags for class definitions ( #4156 )
...
related: https://github.com/oxc-project/oxc/issues/4142#issuecomment-2219125356
Although we called `enter_node(Class)`, that doesn't mean we're in the `class` scope. It causes our must to visit decorators before `enter_node`.
Let's look at this case. It causes a syntax error if we don't visit decorators before `enter_node`
```js
// This file was procedurally generated from the following sources:
// - src/decorator/decorator-call-expr-identifier-reference-yield.case
// - src/decorator/syntax/valid/cls-expr-decorators-valid-syntax.template
/*---
description: Decorator @ DecoratorCallExpression (Valid syntax for decorator on class expression)
esid: prod-ClassExpression
features: [class, decorators]
flags: [generated, noStrict]
info: |
ClassExpression[Yield, Await] :
DecoratorList[?Yield, ?Await]opt class BindingIdentifier[?Yield, ?Await]opt ClassTail[?Yield, ?Await]
DecoratorList[Yield, Await] :
DecoratorList[?Yield, ?Await]opt Decorator[?Yield, ?Await]
Decorator[Yield, Await] :
@ DecoratorMemberExpression[?Yield, ?Await]
@ DecoratorParenthesizedExpression[?Yield, ?Await]
@ DecoratorCallExpression[?Yield, ?Await]
...
DecoratorCallExpression[Yield, Await] :
DecoratorMemberExpression[?Yield, ?Await] Arguments[?Yield, ?Await]
DecoratorMemberExpression[Yield, Await] :
IdentifierReference[?Yield, ?Await]
DecoratorMemberExpression[?Yield, ?Await] . IdentifierName
DecoratorMemberExpression[?Yield, ?Await] . PrivateIdentifier
IdentifierReference[Yield, Await] :
[~Yield] yield
...
---*/
function decorator() {
return () => {};
}
var yield = decorator;
var C = @yield() class {};
```
Errors:
```shell
× The keyword 'yield' is reserved
╭─[language/statements/class/decorator/syntax/valid/decorator-call-expr-identifier-reference-yield.js:45:2]
44 │
45 │ @yield() class C {}
· ─────
╰────
```
The changed code makes more sense. Only if we call `enter_scope` for class, the flags will contain `StrictMode`. Also, we can get the exact `flags` of the `scope` in the `class` at the transformer
For example:
```
class A {
B() {
// Before: flags is `Function`
// After: flags is `Function | StrictMode`
}
}
```
The regression tests will be fixed in follow-up PRs
2024-07-14 03:35:12 +00:00
Dunqing
20cdb1fe0a
feat(semantic): align class scope with typescript ( #4195 )
...
```ts
class Klass <T> extends Root <R> {}
// ^^^^^ ^^^ ^^^^ ^^^ ^^
// id type_paramter super_class super_type_parameters body
```
I reorder fields according to the order above
The class scope is not defined in the spec. But we need to create a scope for `class` to store `TypeParamters`
2024-07-14 03:19:30 +00:00
overlookmotel
22d56bdcac
fix(semantic): do not resolve references after FormalParameters in TS type ( #4241 )
...
Semantic resolves references when exiting `FormalParameters` to ensure references in param initializers don't get bound to bindings inside the function body.
However, it shouldn't do this for `FormalParameters` in TS types e.g. `TSTypeAnnotation` because they don't have their own scopes.
2024-07-13 02:43:01 +00:00
lucab
d7ab0b8413
refactor(semantic)!: simplify node creation ( #4226 )
...
This tweaks AST node creation and tree manipulation, directly
building new nodes with a valid node ID.
2024-07-13 02:19:02 +00:00
lucab
81ed5885a8
refactor(semantic): convert scope fields to IndexVecs ( #4208 )
...
Closes: https://github.com/oxc-project/backlog/issues/10
2024-07-12 09:43:58 +00:00
Dunqing
92ee77487f
feat(semantic): add ScopeFlags::CatchClause for use in CatchClause ( #4205 )
2024-07-12 03:47:07 +00:00
rzvxa
aab7aaaa06
refactor(ast/visit): fire node events as the outermost one. ( #4203 )
...
I'm going to be AFK today(till about 9 PM UTC). Meanwhile, I Didn't want to be a blocker so here we go.
It would fix the #4200 merge if you guys find it in the correct order otherwise feel free to close it.
2024-07-12 03:27:59 +00:00
overlookmotel
cb15303644
perf(semantic): reduce memory copies ( #4216 )
...
Reduce memory copies when resolving references in `Semantic`.
If parent scope has no unresolved references for `name`, there is no need to generate a new `Vec<ReferenceId>` for `name` and copy in contents from current scope. Just move the existing `Vec` to the parent.
2024-07-12 02:05:22 +00:00
overlookmotel
ef4c1f4e32
perf(semantic): reduce lookups ( #4214 )
...
Small performance optimization (I hope) to resolving references in `Semantic`. Look up current bindings once rather than on every turn of the loop.
2024-07-12 01:41:28 +00:00
overlookmotel
f23e54f97b
perf(semantic): recycle unresolved references hash maps ( #4213 )
...
Closes #4169 .
Reduce allocations while building `Semantic` by recycling hash maps used for tracking unresolved references, rather than creating a new one for every scope.
2024-07-12 01:41:27 +00:00
lucab
2602ce2b71
perf(semantic): reuse existing map of unresolved refs ( #4206 )
2024-07-11 15:35:22 +00:00
Dunqing
bbe5dede07
refactor(semantic): set current_scope_id to scope_id in enter_scope ( #4193 )
...
close : #4170
2024-07-11 08:45:35 +00:00
Dunqing
7f1adddaf0
refactor(semantic): correct scope in CatchClause ( #4192 )
...
close : #4186
CatchClause has two scopes. The first one is `CatchClause`, which will add a `CatchParameter` to it. The second one is `Block`, which will add binding that declares in the current block scope.
The spec has a syntax error about `CatchParameter`
- It is a Syntax Error if any element of the BoundNames of CatchParameter also occurs in the LexicallyDeclaredNames of Block.
2024-07-11 08:45:30 +00:00
github-actions[bot]
2a169d1969
Release crates v0.20.0 ( #4189 )
...
## [0.20.0] - 2024-07-11
- 5731e39#4132 ) (Luca Bruno)
### Features
- 67fe75e#4168 ) (rzvxa)
- 54cd04a#4160 ) (Boshen)
- 44a894a#4155 ) (Boshen)
- 725571a#4133 ) (Boshen)
### Bug Fixes
- 48947a2#4143 ) (rzvxa)
- 7a059ab#4177 ) (rzvxa)
- 4a656c3#4072 ) (DonIsaac)
- 28eeee0#4163 ) (Boshen)
### Performance
- ddfa343#4175 )
(DonIsaac)
- 2203143#4162 ) (lucab)
- fca9706#4140 ) (Boshen)
### Documentation
- bdcc298#4149 ) (rzvxa)
### Refactor
- 03ad1e3#4157 ) (lucab)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-11 11:05:49 +08:00
rzvxa
67fe75ec6c
feat(ast, ast_codegen): pass the scope_id to the enter_scope event. ( #4168 )
2024-07-10 15:19:23 +00:00
lucab
22031430b1
perf(semantic): store unresolved refs in a stack ( #4162 )
...
This tweaks `SemanticBuilder` logic in order to accumulate unresolved
references in a stack, getting rid of the previous index-vector which
is not required under the current access pattern.
Ref: https://github.com/oxc-project/oxc/pull/4107#issuecomment-2214167393
2024-07-10 14:59:16 +00:00
lucab
03ad1e32cc
refactor(semantic): tweak comment argument type ( #4157 )
...
Minor followup from https://github.com/oxc-project/oxc/pull/4132 .
2024-07-10 07:19:24 +00:00
Boshen
fca9706ab3
perf(semantic): faster search for leading comments ( #4140 )
...
fixes #4114
@leaysgur This is my wild guess, I need a second pairs of eyes to make
sure this is correct.
2024-07-10 09:54:26 +08:00
Luca Bruno
5731e3957f
refactor(ast)!: store span details inside comment struct ( #4132 )
...
This tweaks `Comment` definition in order to internally store the start
and end position of its span.
Closes: https://github.com/oxc-project/oxc/issues/4069
2024-07-09 23:23:43 +08:00
github-actions[bot]
714bf1dd7f
Release crates v0.19.0 ( #4137 )
...
## [0.19.0] - 2024-07-09
- b936162#4122 ) (rzvxa)
### Features
- 485c871#4124 ) (rzvxa)
### Refactor
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-09 20:32:06 +08:00
github-actions[bot]
e29cdbfe40
Release crates v0.18.0 ( #4136 )
...
## [0.18.0] - 2024-07-09
- d347aed#3890 ) (rzvxa)
### Features
- c6c16a5#4135 ) (Boshen)
- 365d9ba#4119 ) (IWANABETHATGUY)
- 3a0f2aa#4126 ) (DonIsaac)
- 2f53bdf#4127 ) (DonIsaac)
- c4ee9f8#4125 ) (Don Isaac)
- 44c7fe3#4090 ) (rzvxa)
### Bug Fixes
- cb1af04#4130 ) (Dunqing)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-09 19:56:10 +08:00
DonIsaac
2f53bdf72d
feat(semantic): check for abstract ClassElements in non-abstract classes ( #4127 )
...
feat(semantic): check for abstract ClassElements in non-abstract classes
chore: update coverage snapshots
2024-07-09 03:35:32 +00:00
Don Isaac
c4ee9f8ec6
feat(semantic): check for abstract initializations and implementations ( #4125 )
2024-07-08 17:30:16 -04:00
github-actions[bot]
c3f08ce8e0
Release crates v0.17.2 ( #4115 )
...
## [0.17.2] - 2024-07-08
### Features
- 115ac3b#4088 )
(rzvxa)
- 720983a#4113 ) (Boshen)
- e386b62#4097 )
(DonIsaac)
### Bug Fixes
- 5472b7c5c31236#4106 ) (Dunqing)
- e67c7d1#4105 ) (Dunqing)
- 3fcad5e#4077 ) (michaelm)
- f8d77e4#4068 ) (michaelm)
- 0f02608#4100 ) (Don
Isaac)
- 4413e2d#4103 ) (Don Isaac)
### Performance
- 7ed27b7#4074 ) (Dunqing)
- 9114c8e#4107 )
(Luca Bruno)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-08 19:16:33 +08:00
Luca Bruno
9114c8e01c
perf(semantic): keep a single map of unresolved references ( #4107 )
...
This reworks `ScopeTree` in order to keep a single (root) map of
unresolved references. The `SemanticBuilder` keeps track of all
intermediate ones while walking scopes, and it can get rid of all
non-root ones once done.
Ref: https://github.com/oxc-project/backlog/issues/32
2024-07-08 16:56:13 +08:00
Don Isaac
0f026089d1
fix(semantic): bind TSImportEqualsDeclarations ( #4100 )
...
Closes #4091
2024-07-08 14:03:47 +08:00
DonIsaac
e386b62331
feat(semantic): check for invalid type import assignments ( #4097 )
...
Adds checks to `TSImportEqualsDeclaration` for invalid use of `import type` modifier.
```ts
import { Foo } from './foo'
namespace Bar {
export class Baz {}
}
import type A = Foo.Baz; // not allowed
import type B = Bar.Baz; // not allowed
import type C = require('./c'); // allowed
```
2024-07-08 03:14:22 +00:00
github-actions[bot]
51d56d37ff
Release crates v0.17.1 ( #4075 )
...
## [0.17.1] - 2024-07-06
### Bug Fixes
- aa585d3#4061 ) (rzvxa)
- 564a75a#4063 ) (michaelm)
- adee728#4065 )
(michaelm)
- 1b8f208#4064 ) (michaelm)
- 719fb96#4073 ) (Boshen)
- 150f4d97fe2a2f#4067 ) (overlookmotel)
### Refactor
- 8fa98e0#4066 )
(overlookmotel)
- 65aee19#4070 ) (Luca
Bruno)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-07 01:29:52 +08:00
github-actions[bot]
224f5ef2cc
Release crates v0.17.0 ( #4059 )
...
## [0.17.0] - 2024-07-05
- e32b4bc#4045 ) (Luca Bruno)
- 1df6ac0#4000 ) (rzvxa)
- 4a0eaa0#3998 ) (rzvxa)
- c98d8aa#3995 ) (rzvxa)
### Features
- 1854a52#4012 ) (rzvxa)
- 7538af1#3954 ) (rzvxa)
- 7768d23#4035 )
(Egor Blinov)
- 0da9dfb#4058 )
(Boshen)
### Bug Fixes
- aaac2d8#4055 ) (Boshen)
- 5e5b1b1#4042 ) (Egor Blinov)
- 7844734#4022 )
(Dunqing)
- 6254a41#4021 )
(Dunqing)
- 3d29e9c#4043 ) (Dunqing)
- 02ea19a#4026 ) (Dunqing)
- 7c915f4#4025 ) (Dunqing)
- 05a047c#4024 ) (Dunqing)
- c043bec#4037 ) (Egor Blinov)
- b007553#4030 ) (Egor Blinov)
- da62839#4027 ) (Egor Blinov)
### Refactor
- b51f75b#4008 ) (rzvxa)
- edb557c#4057 )
(Boshen)
- 243c9f3#4028 ) (Boshen)
- 1dacb1f#4014 ) (Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-05 15:46:50 +08:00
rzvxa
1df6ac0427
refactor(ast)!: rename visit_enum_memeber to visit_ts_enum_member. ( #4000 )
2024-07-02 10:05:42 +00:00
rzvxa
4a0eaa02da
refactor(ast)!: rename visit_enum to visit_ts_enum_declaration. ( #3998 )
2024-07-02 09:56:15 +00:00
rzvxa
c98d8aa000
refactor(ast)!: rename visit_arrow_expression to visit_arrow_function_expression. ( #3995 )
2024-07-02 09:19:25 +00:00
github-actions[bot]
e2c9015ef6
Release crates v0.16.3 ( #4013 )
...
## [0.16.3] - 2024-07-02
### Features
- b257d53#3895 ) (mysteryven)
### Bug Fixes
- 23038ad#3999 ) (Boshen)
- d995f94#4004 ) (Dunqing)
- bdee156#3997 ) (Dunqing)
- a50ce3d#3996 )
(Dunqing)
### Refactor
- 0fe22a8#3994 )
(rzvxa)
- d0eac46#4003 ) (Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-02 12:47:29 +08:00
Dunqing
d995f94280
fix(semantic): resolve reference incorrectly when a parameter references a parameter that hasn't been defined yet ( #4004 )
...
close : #3682
The TypeScript code that handles this is [here](d8086f14b6/src/compiler/utilities.ts (L11515-L11577)
2024-07-02 02:12:15 +00:00
github-actions[bot]
3870ed5a24
Release crates v0.16.2 ( #3983 )
...
## [0.16.2] - 2024-06-30
### Features
- dc6d45e#3979 ) (Boshen)
- 63f36da#3977 ) (DonIsaac)
### Bug Fixes
- dac617d#3980 )
(Boshen)
- bd1141d#3982 ) (Dunqing)
### Performance
- b234ddd1eac3d2#3972 ) (Don Isaac)
- 0c81fbe#3970 ) (Boshen)
### Refactor
- 5845057#3978 ) (Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-30 19:59:15 +08:00
Boshen
b234ddd47c
perf(semantic): only check for jsdoc if jsdoc building is enabled
2024-06-30 13:58:06 +08:00
Boshen
54c653ebd4
Revert "perf(semantic): use Atom<'a> for References" ( #3974 )
...
Reverts oxc-project/oxc#3972
@DonIsaac As it turns out we can't have lifetimes on these structures because semantic data is exposed to downstream users to use freely, detached from the ast and allocator.
2024-06-29 15:55:04 +00:00
Don Isaac
1eac3d244d
perf(semantic): use Atom<'a> for References ( #3972 )
...
Relates to [this
issue](https://github.com/oxc-project/backlog/issues/31 ) on the backlog.
2024-06-29 23:23:36 +08:00
github-actions[bot]
fa50e9737e
Release crates v0.16.1 ( #3968 )
...
## [0.16.1] - 2024-06-29
### Features
- 7b38bde#3948 )
(DonIsaac)
- f64ad4b#3955 ) (Boshen)
### Bug Fixes
- 51e54f9#3957 ) (Dunqing)
- 31e4c3b#3956 ) (Dunqing)
### Refactor
- 2705df9#3960 ) (DonIsaac)
- 15ec254
2024-06-29 16:53:09 +08:00
DonIsaac
2705df93b3
refactor(linter): improve diagnostic labeling ( #3960 )
2024-06-29 05:19:22 +00:00
Boshen
f64ad4b7c2
feat(semantic): make jsdoc building optional (turned off by default) ( #3955 )
2024-06-29 05:12:25 +00:00
Boshen
15ec254740
refactor(semantic): remove the unused Semantic::build2 function
2024-06-28 23:15:12 +08:00
github-actions[bot]
4e3e1a39eb
Release crates v0.16.0 ( #3930 )
...
## [0.16.0] - 2024-06-26
- 6796891#3898 ) (rzvxa)
- 1f85f1a#3899 ) (rzvxa)
- ae09a97#3846 )
(Boshen)
- 1af5ed3#3845 ) (Boshen)
- 0673677#3844 ) (Boshen)
- ee6ec4e#3841 ) (Boshen)
- 9b38119#3839 ) (Boshen)
- cfcef24#3830 ) (Boshen)
- 4456034#3820 ) (Boshen)
### Features
- 497769c#3785 ) (Dunqing)
- 4b06dc7#3775 )
(Dunqing)
- 5847e16#3767 ) (Boshen)
- 2e026e1#3888 ) (rzvxa)
- 09f4d3c#3852 ) (rzvxa)
- 3e78f98#3771 ) (rzvxa)
- 01da2f7#3792 ) (Dunqing)
- 2821e0e#3791 )
(Dunqing)
- 97575d8#3786 )
(Dunqing)
- 5e2baf3#3872 ) (Dunqing)
- 2cdb34f#3811 ) (Dunqing)
- 231b8f0#3809 ) (Dunqing)
- a37138f#3797 ) (Dunqing)
- b0d7355#3793 ) (Dunqing)
- b38c34d#3769 ) (Dunqing)
- 4134de8#3755 ) (Dunqing)
- 94202de#3754 )
(Dunqing)
- e95d8e3#3752 ) (Dunqing)
- df9971d#3750 ) (Dunqing)
- 4aea2b1#3749 ) (Dunqing)
- 9ea30c4#3748 ) (Dunqing)
- dd540c8#3803 ) (Boshen)
- f3c3970#3802 )
(Boshen)
- 4fb90eb#3765 ) (Boshen)
- d5f6aeb#3838 ) (Don
Isaac)
- 01572f0#3902 )
(DonIsaac)
- 5501d5c#3866 ) (Dunqing)
- 2a16ce0#3794 ) (Boshen)- d3cd3ea#3896 ) (underfin)
### Bug Fixes
- 063cfde#3858 )
(overlookmotel)
- 66f404c#3856 )
(overlookmotel)
- 2766594#3922 )
(Dunqing)
- 27f0531#3921 ) (Dunqing)
- 59ce38b#3920 ) (Dunqing)
- 58e54f4#3810 )
(Dunqing)
- cb8a272#3807 )
(Dunqing)
- d8ecce5#3806 ) (Dunqing)
- 4e241fc#3805 ) (Dunqing)
- 683c7b0#3804 ) (Dunqing)
- 7d47fc3#3790 ) (Dunqing)
- 8ce794d#3768 ) (Dunqing)
- d29316a#3753 ) (Dunqing)
- bf1c250#3751 ) (Dunqing)
- 275349a#3926 )
(Boshen)
- ef82c78#3885 ) (Dunqing)
- 13754cb#3853 ) (Boshen)
- 8c9fc63#3861 ) (overlookmotel)
- 99a40ce#3823 ) (Boshen)
- 08fcfb3#3911 )
(overlookmotel)
- 17ad8f7#3908 ) (overlookmotel)
- d76f34b#3837 )
(overlookmotel)
- e470731#3833 ) (overlookmotel)
- d774e54#3832 ) (overlookmotel)
- ff1da27#3831 )
(overlookmotel)
- 6dcc3f4#3816 )
(overlookmotel)
- aea3e9a#3782 ) (overlookmotel)
### Performance
- 92c21b2#3897 )
(Luca Bruno)
- 4bf405d#3894 ) (Boshen)
- 10d1de5#3867 )
(DonIsaac)- 4f7ff7e#3818 )
(overlookmotel)
### Refactor
- 6f26087#3905 ) (overlookmotel)
- 442aca3#3891 )
(overlookmotel)
- acf69fa#3859 ) (overlookmotel)
- 9e148e9#3860 ) (overlookmotel)
- 363d3d5#3855 )
(rzvxa)
- a648748#3835 ) (overlookmotel)
- 1206967#3834 ) (overlookmotel)
- 2f5d50e#3847 ) (Boshen)
- 8027b1e#3801 )
(Boshen)
- a471e62#3925 ) (Boshen)
- 3db2553#3923 )
(Boshen)
- 4cf3c76#3903 ) (Boshen)
- 187f078#3892 ) (Boshen)
- 97d59fc#3849 )
(Boshen)
- 5ef28b7#3912 ) (overlookmotel)
- d9f268d#3836 ) (overlookmotel)
- 21b0d01#3781 ) (overlookmotel)
- 7c44703#3774 ) (overlookmotel)
- 22c56d7#3764 ) (overlookmotel)
- cd56aa9#3762 )
(overlookmotel)
- 512740d#3760 ) (overlookmotel)
- 1061baa#3901 ) (overlookmotel)
- fcd21a6#3882 ) (overlookmotel)
- 24979c9#3880 )
(overlookmotel)
- 2045c92#3879 )
(overlookmotel)- d6437fe#3854 )
(Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-06-27 20:38:31 +08:00
overlookmotel
17ad8f7d93
fix(transformer): create new scopes for new blocks in TS transform ( #3908 )
...
Create scopes for new `BlockStatement`s inserted in TS transform, and update scope tree.
2024-06-26 05:16:02 +00:00
rzvxa
6796891e2e
fix(ast)!: rename all instances of BigintLiteral to BigIntLiteral. ( #3898 )
...
Notice the casing! Just for the sake of consistency.
2024-06-25 14:39:42 +00:00
Boshen
187f0782c1
refactor(parser): improve parsing of parse_function_or_constructor_type ( #3892 )
...
part of #3502
2024-06-25 03:43:02 +00:00
DonIsaac
10d1de584b
perf(semantic): remove uneccessary allocation in builder ( #3867 )
2024-06-24 02:57:08 +00:00
