overlookmotel
e66da9fe41
refactor(isolated_declarations, linter, minifier, prettier, semantic, transformer): remove unnecessary ref / ref mut syntax ( #8643 )
...
While working on #8641 , I found a lot of places where we unnecessarily use `ref` / `ref mut` in match arms.
In many cases, we're creating double-references (turning a `&T` into a `&&T`). The compiler should be smart enough to remove them for us, but there doesn't seem much point in explicitly creating double-references when we don't actually want them, and relying on compiler to optimize them out again.
2025-01-21 14:20:07 +00:00
overlookmotel
b8d9a51462
refactor(span): deal only in owned Atoms ( #8641 )
...
#8596 made `Atom` a `Copy` type. Now we can deal exclusively in owned `Atom`s. Refactor code to not pass `&Atom` into functions etc.
2025-01-21 14:20:06 +00:00
branchseer
ac4f98e376
refactor(span): derive Copy on Atom ( #8596 )
...
Follow up from
https://github.com/oxc-project/oxc/pull/8543#discussion_r1918592423
> I agree. https://github.com/oxc-project/backlog/issues/155
> Originally we were considering some form of interning and
reference-counting, so we didn't make it Copy to leave the door open for
that. But now all strings are stored in the arena anyway, so even if we
did decide to intern strings, reference-counting would be irrelevant -
our bump allocator doesn't allow freeing individual allocations anyway.
Most of the changes are done automatically by `just fix` (`cargo clippy
--fix` && `cargo fmt --all`). See the commit list for the manual edits.
2025-01-19 16:14:23 +08:00
oxc-bot
8f5be07ed6
release(crates): v0.47.1 ( #8593 )
...
## [0.47.1] - 2025-01-19
### Features
- ee8ee55#8586 )
(Boshen)
- 1bef911#8584 ) (Boshen)
### Bug Fixes
- 7b219a9#8582 ) (Boshen)
- 7421a52#8543 ) (branchseer)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2025-01-19 09:44:29 +08:00
oxc-bot
d3fd7a9741
release(crates): v0.47.0 ( #8580 )
...
## [0.47.0] - 2025-01-18
- fae4cd2#8571 )
(overlookmotel)
- 95bc0d7#8569 ) (overlookmotel)
- 19d3677#8560 ) (sapphi-red)
- 4ce6329#8455 ) (Valentinas Janeiko)
- 7066d1c#8512 ) (overlookmotel)
### Features
- bf4e5e1#8553 ) (overlookmotel)
- a6d71f8#8521 ) (overlookmotel)
- 4d4e805#8577 )
(camc314)
- 991a22f#8442 )
(sapphi-red)
- 3dc2d8b#8441 ) (sapphi-red)
- a4ae450#8440 ) (sapphi-red)
- 7cc81ef#8550 ) (camc314)
- 927f43f#8534 )
(Boshen)
- 06f14d5#8525 ) (Boshen)
- 1860411#8523 )
(Boshen)
- c479a58#8540 )
(Boshen)
- 2f0314e#8579 )
(Boshen)
- f413bb5#8511 ) (Dunqing)
### Bug Fixes
- e87c001#8570 ) (overlookmotel)
- 855c839#8536 ) (Boshen)
- 65c596d#8551 ) (camc314)
- f57aac2#8542 )
(camc314)
- 946ad76#8535 )
(Boshen)
- b1d0186#8533 ) (Boshen)
- 53adde5#8528 )
(Boshen)
- 405b73d#8527 ) (Boshen)
- 92e44cb#8526 ) (Boshen)
- 209e313#8516 ) (Boshen)
- 6585463#8490 ) (Boshen)
- b552f5c#8547 ) (overlookmotel)
- 9963533#8494 ) (overlookmotel)
- 06ccb51#8500 ) (Dunqing)
- 356f0c1#8506 ) (overlookmotel)
- a048337#8549 ) (overlookmotel)
### Performance
- 76ea52b#8572 ) (overlookmotel)
- 93df57f#8567 ) (overlookmotel)
- 5a28d68#8565 ) (overlookmotel)
- d17021c#8557 ) (overlookmotel)
- 6b52d7a#8495 ) (Boshen)
- 30a869e#8554 )
(overlookmotel)
- 63eb298#8300 ) (overlookmotel)
- a43560c#8299 ) (overlookmotel)
- 3fff7d2#8298 ) (overlookmotel)
- 53ef263#8482 ) (overlookmotel)
### Documentation
- fa1a6d5#8555 ) (overlookmotel)
### Refactor
- ac05134#8568 ) (overlookmotel)
- 68fab81#8566 ) (overlookmotel)
- fcbca32#8564 )
(overlookmotel)
- 007e8c0#8519 ) (overlookmotel)
- b4c87e2#8454 ) (Alexander
S.)
- 8f57929#8561 ) (sapphi-red)
- 2857ae1#8524 )
(overlookmotel)
- b5ed58e#8297 ) (overlookmotel)
- 712633f#8548 ) (overlookmotel)
- 5206c6a#8546 )
(overlookmotel)
- 61077ca#8545 ) (overlookmotel)
- 6820d24#8529 ) (Dunqing)
- 52bd0b1#8513 ) (Dunqing)
- c30654a#8530 ) (Dunqing)
- 2bc5175#8481 )
(overlookmotel)
- 72f425f#8539 ) (overlookmotel)
- 7e61b23#8504 ) (overlookmotel)
- 04bc259#8518 )
(overlookmotel)
- a368726#8507 ) (overlookmotel)
### Testing
- e0f5d6c629c417#8497 ) (Boshen)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2025-01-18 14:26:20 +08:00
overlookmotel
b5ed58e237
refactor(span): all methods take owned Span ( #8297 )
...
`Span` is `Copy` and 8 bytes. There is no point in the extra indirection of passing `&Span` to functions (`&Span` is also 8 bytes).
2025-01-18 01:47:09 +00:00
overlookmotel
30a869ead2
perf(semantic): use oxc_allocator::HashMap in ScopeTree ( #8554 )
...
Use `oxc_allocator::HashMap` in `ScopeTree`, replacing `hashbrown::HashMap`. `oxc_allocator::HashMap` is non-drop, so it may reduce drop time of `ScopeTree` a little.
2025-01-16 23:29:58 +00:00
Valentinas Janeiko
4ce63298e8
fix(semantic)!: ensure program outlives semantic ( #8455 )
...
fixes : #8437
In semantic builder make sure `Program` reference has a lifetime of the
Arena.
---------
Co-authored-by: overlookmotel <theoverlookmotel@gmail.com>
2025-01-16 10:04:25 +08:00
oxc-bot
3e05055783
release(crates): v0.46.0 ( #8487 )
...
## [0.46.0] - 2025-01-14
- 7eb6ccd#8483 ) (Boshen)
### Features
- 8accfef#8466 ) (Boshen)
- 870a583#8447 ) (Boshen)
- 4ad695d#8478 ) (Boshen)
- 9d550aa#8479 ) (_Kerman)
### Bug Fixes
- 4071878#8477 ) (Dunqing)
- 7ee7634#8476 ) (Dunqing)
- 7252cb0#8475 ) (Dunqing)
- 4c6675c#8484 ) (Boshen)
- 1d6e84d#8464 ) (Boshen)
- 25d4bf9#8462 ) (Boshen)
- dd64340#8439 ) (Boshen)
- c444de8#8435 ) (Dunqing)
- 270245f#8463 ) (Dunqing)
- 2a400d6ab694b0#8458 ) (Dunqing)
### Performance
- 7a8200c#8472 )
(Boshen)
- 31dac22#8471 ) (Boshen)
- 8fc238a#8467 )
(Boshen)
- 372eb09#8451 ) (Boshen)
### Refactor
- 6e64eef#8450 ) (Boshen)
- de5b288#8480 ) (overlookmotel)
- c83ce5c#8459 )
(Dunqing)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2025-01-14 19:40:44 +08:00
oxc-bot
01722f34ff
release(crates): v0.45.0 ( #8434 )
...
## [0.45.0] - 2025-01-11
- 7f69561#8428 )
(overlookmotel)
- d8b27af#8283 ) (overlookmotel)
- 5106088#8280 ) (overlookmotel)
### Features
- 6c7acac#8389 )
(overlookmotel)
- 3212bcd#8417 ) (Boshen)
- ad146bb#8178 ) (Boshen)
- 41ddf60#8179 ) (Boshen)
- d56020b#8431 ) (sapphi-red)
- f935d94#8430 ) (sapphi-red)
- dab7a51#8429 ) (Boshen)
- 0e7bab8#8421 )
(Boshen)
- 5b5b844#8415 ) (Boshen)
- 438a6e7#8381 )
(Boshen)
- 793cb43#8352 ) (camc314)
- 814da55#8368 )
(sapphi-red)
- a596821#8367 )
(sapphi-red)
- 579eb60#8366 )
(sapphi-red)
- f367a16#8351 )
(camc314)
- 8d52cd0#8345 ) (sapphi-red)
- a69d15f#8344 )
(sapphi-red)
- 819c475#8343 )
(sapphi-red)
- e085d66#8340 ) (Boshen)
- 2c2e483#8339 )
(Boshen)
- 6220e05#8336 ) (Boshen)
- a76dfae#8333 )
(Boshen)
- e88a6bd#8332 ) (Boshen)
- ec88c68#8315 )
(sapphi-red)
- e6fe84d#8314 )
(sapphi-red)
- 9ea4e31#8313 ) (sapphi-red)
- 051fbb6#8316 ) (Boshen)
- a542013#8311 ) (Boshen)
- e3ff81e#8310 )
(Boshen)
- 4b68cc0#8309 ) (Boshen)
- 922c514#8308 ) (Boshen)
- 66a2443#8305 ) (camc314)
- af65c36#8304 )
(camc314)
- 76c778b#8303 ) (camc314)
- 5ed439b#8302 )
(camc314)
- 6afc590#8301 ) (camc314)
- ecc789f#8277 ) (Boshen)
- 0e3b79a#8274 ) (Boshen)
- c9cf593#8272 )
(Boshen)
- b92b2ab#8270 ) (Boshen)
- a4df387#8268 ) (camc314)
- f000596#8267 ) (camc314)
- 092aeaf#8266 )
(camc314)
- 04ec38d#8262 )
(camc314)
- e446c15#8261 )
(camc314)
- 7f19211#8256 )
(camc314)
- cec63e24d8a08d#8252 ) (Boshen)
- e84f267#8253 ) (Boshen)
- d1224f9#8251 )
(camc314)
- 65f46f5#8248 ) (Boshen)
- bd8d677#8247 ) (Boshen)
- f73dc9e#8246 ) (Boshen)
- fd5af73#8245 ) (Boshen)
- 2f52f33#8244 ) (Boshen)
- ccdc039#8240 ) (Boshen)
- 39353b2#8238 ) (Cameron)
- c90fc16#8235 ) (camc314)
- 6c8ee9f#8234 )
(Boshen)
- 51f4792#8229 ) (Boshen)
- 6e2ec17#8228 ) (Boshen)
- 574a242#8227 ) (Boshen)
- 2041477#8226 ) (Boshen)
- 9c1afa4#8221 ) (Boshen)
- 4a29845#8212 ) (Boshen)
- 2786dea#8210 ) (Boshen)
- cd274ee#8209 ) (Cameron)
- 4ae15df#8208 ) (camc314)
- 3202b4f#8207 ) (camc314)
- 3b45011#8206 )
(camc314)
- 4c2059a#8205 ) (camc314)
- 4804933#8203 ) (Boshen)
- bf266e1#8197 )
(Cameron)
- 06e1780#8194 ) (Boshen)
- 42e211a#8092 ) (Boshen)
- d0de560#8191 ) (Boshen)
- cef8eb8#8176 ) (翠 /
green)
- 8149e34#8180 ) (Boshen)
- fc43ec5#8172 )
(sapphi-red)
- 29dc0dc#8169 ) (Boshen)
- 3c5718d#8160 ) (翠 / green)
- f3a36e1#8159 ) (翠 / green)
- 37c9959#8148 )
(Boshen)
- 8fb71f5#8147 ) (Boshen)
- 6615e1e#8142 ) (翠 / green)
- 2b2a373#8137 )
(Boshen)
- 213364a#8136 ) (Boshen)
- 6b51e6d#8133 ) (Boshen)
- f615bfa#8130 ) (Boshen)
- f0b1ee5#8122 )
(Boshen)
- f8200a8#8121 )
(Boshen)
- 72d9967#8120 ) (Boshen)
- fef0b25#8119 )
(Boshen)
- 2331ea8#8112 ) (Boshen)
- ad9a0a9#8241 ) (Boshen)
- 2da4365#8222 ) (Boshen)
- 55744fd#8189 ) (Max Stoumen)
- 0592a8b#8202 ) (Dunqing)
- ad77ad5#8132 ) (Dunqing)
- e405f79#8117 ) (Dunqing)
- 3303e99#8116 ) (Dunqing)
- 0cc71cf#8106 )
(Dunqing)
- 58ed832#8102 ) (Dunqing)
- f14567a#8100 ) (Dunqing)
- 13349ef#8099 ) (Dunqing)
### Bug Fixes
- eb25bc0#8388 )
(overlookmotel)
- 97a7992#8426 ) (overlookmotel)
- a1752a0#8374 )
(Boshen)
- 5a648bc#8348 )
(Boshen)
- b6d16f4#8258 ) (camc314)
- 8ed9766#8185 )
(Dunqing)
- ad61e70#8135 ) (Boshen)
- 74572de#8144 )
(翠 / green)
- e1f8ea4#8294 ) (overlookmotel)
- 5c63414#7927 )
(翠 / green)
- 3c93549#8433 ) (Boshen)
- 52f88c0#8424 ) (camc314)
- a80460c#8420 ) (camc314)
- d4ca8d4#8419 )
(Boshen)
- 357b61d#8416 ) (Boshen)
- 0efc845#8410 ) (Boshen)
- 7ce6a7c#8406 )
(Boshen)
- 2f3a9dc#8405 )
(Boshen)
- c0a3dda#8378 )
(Boshen)
- 5516f7f#8375 ) (Boshen)
- cb098c7#8373 ) (Boshen)
- 82ee77e#8371 ) (Boshen)
- f87da16#8278 ) (Boshen)
- 62a2644#8260 ) (camc314)
- d2f8eaa#8242 )
(Boshen)
- a698def#8233 ) (Boshen)
- 05be1fc#8211 ) (Boshen)
- 56b7f13#8199 )
(Boshen)
- 75d5f17#8177 ) (sapphi-red)
- f88acb3#8193 )
(branchseer)
- 79a8fc6#8376 ) (Dunqing)
- 79af100#8134 ) (camc314)
- 3eaff2a#8192 ) (Dunqing)
- 3feac27#8382 ) (Dunqing)
- 335065d#8335 ) (Dunqing)
- e4d66e4#8331 ) (Dunqing)
- 775a289#8024 ) (Dunqing)
- ac72adb#8362 ) (overlookmotel)
- f1f129b#8361 ) (overlookmotel)
- ab61425#8360 ) (overlookmotel)
- 9a03bd2#8275 ) (Dunqing)
- 0df1866#8355 ) (overlookmotel)
- 78d7c97#8354 ) (overlookmotel)
- 2e7207f#8141 ) (underfin)
### Performance
- 07edf74#8383 ) (Dunqing)
- 62e3f7e#8322 ) (overlookmotel)
- aebe0ea#8318 ) (overlookmotel)
### Documentation
- c8e4843#8286 ) (overlookmotel)
- e0a09ab#8356 )
(overlookmotel)
- aaa009d#8404 ) (翠 /
green)
- 05cba5b#8398 )
(overlookmotel)
### Refactor
- b29655f#8425 ) (overlookmotel)
- 0db2a22#8281 ) (overlookmotel)
- aea9551#8273 ) (Dunqing)
- 9c1844a#8423 ) (overlookmotel)
- 1835687#8284 )
(overlookmotel)
- 64bfdfe#8293 ) (overlookmotel)
- 0344e98#8291 )
(overlookmotel)
- fabf116#8289 )
(overlookmotel)
- 0462edb#8288 ) (overlookmotel)
- fb2acd8#8413 )
(Boshen)
- baaec60#8411 ) (Boshen)
- 1c4658d#8380 ) (Boshen)
- 09f0f48#8349 ) (Boshen)
- 9a5c66a#8346 ) (Boshen)
- 98f2b1c#8327 ) (Boshen)
- fc662b7#8324 ) (Boshen)
- d16e598#8306 )
(Boshen)
- b8d26ea#8282 ) (Boshen)
- 08451627c7f5d7bf0fbce#8239 ) (Boshen)
- 62f8fba#8231 ) (camc314)
- cfb51f2#8184 ) (Boshen)
- bf9cafe75264ed#8139 ) (Boshen)
- c22062b#8114 )
(Boshen)
- e594c39#8111 ) (Boshen)
- 0903501#8377 ) (Dunqing)
- 109b8fc#8285 )
(overlookmotel)
- fb389f7#8338 ) (Dunqing)
- dddbd29#8386 )
(overlookmotel)
- ce6c445#8328 )
(overlookmotel)
- 73d0025#8323 )
(overlookmotel)
- 3dd08e9#8321 ) (overlookmotel)
- ea9cefb#8320 )
(overlookmotel)
- 37199a4#8319 )
(overlookmotel)
- 57e9dcf#8317 )
(overlookmotel)
- a5e3528#8279 ) (overlookmotel)
- e7c89ba#8392 )
(overlookmotel)
- 6790d1d#8357 ) (overlookmotel)
- c786a13#8105 ) (Dunqing)
- f54f48e#8104 ) (Dunqing)
- d82fb52#8103 ) (Dunqing)
- 3dad85e#8400 )
(overlookmotel)
- aa5e65f#8364 ) (overlookmotel)
- c786fd1#8363 )
(overlookmotel)
### Styling
- 4d2888d#8290 ) (overlookmotel)
- e81f34f#8296 ) (overlookmotel)
- 45e2402#8399 )
(overlookmotel)
- 0a1ffc0#8397 )
(overlookmotel)
### Testing
- 16dcdaf#8292 )
(overlookmotel)
- 3149fe0#8347 ) (sapphi-red)
- 91b42de#8250 ) (camc314)
- 1fa5341#8175 ) (sapphi-red)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2025-01-11 22:34:31 +08:00
Dunqing
0903501a98
refactor(semantic): check super usage based on scope ( #8377 )
...
No stronger opinion on both implementations, I just think the scope-based is clearer, and iterating over scope is always faster than node. The only bad point in this implementation we don't have specific ScopeFlags for class methods, thus we need to check if the parent of the function is a `MethodDefinition`
2025-01-09 06:38:09 +00:00
Dunqing
79a8fc6f7d
fix(semantic): report error for super property appearing in function body ( #8376 )
...
Missing error that super property inside plain function.
```js
class C {
constructor() {
function g() {
// * It is a Syntax Error if PropName of MethodDefinition is not "constructor" and HasDirectSuper of MethodDefinition is true.
super();
}
}
method() {
function func() {
// It is a Syntax Error if FunctionBody Contains SuperProperty is true.
super.good();
}
}
}
```
I am not sure why test262 doesn't cover tests like that
2025-01-09 06:38:09 +00:00
renovate[bot]
6a97e29c19
chore(deps): update crate-ci/typos action to v1.29.4 ( #8265 )
...
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [crate-ci/typos](https://redirect.github.com/crate-ci/typos ) | action
| minor | `v1.28.3` -> `v1.29.4` |
---
### Release Notes
<details>
<summary>crate-ci/typos (crate-ci/typos)</summary>
###
[`v1.29.4`](https://redirect.github.com/crate-ci/typos/releases/tag/v1.29.4 )
[Compare
Source](https://redirect.github.com/crate-ci/typos/compare/v1.29.3...v1.29.4 )
#### \[1.29.4] - 2025-01-03
###
[`v1.29.3`](https://redirect.github.com/crate-ci/typos/releases/tag/v1.29.3 )
[Compare
Source](https://redirect.github.com/crate-ci/typos/compare/v1.29.2...v1.29.3 )
#### \[1.29.3] - 2025-01-02
###
[`v1.29.2`](https://redirect.github.com/crate-ci/typos/compare/v1.29.1...v1.29.2 )
[Compare
Source](https://redirect.github.com/crate-ci/typos/compare/v1.29.1...v1.29.2 )
###
[`v1.29.1`](https://redirect.github.com/crate-ci/typos/releases/tag/v1.29.1 )
[Compare
Source](https://redirect.github.com/crate-ci/typos/compare/v1.29.0...v1.29.1 )
#### \[1.29.1] - 2025-01-02
##### Fixes
- Don't correct `deriver`
###
[`v1.29.0`](https://redirect.github.com/crate-ci/typos/releases/tag/v1.29.0 )
[Compare
Source](https://redirect.github.com/crate-ci/typos/compare/v1.28.4...v1.29.0 )
#### \[1.29.0] - 2024-12-31
##### Features
- Updated the dictionary with the [December
2024](https://redirect.github.com/crate-ci/typos/issues/1156 ) changes
##### Performance
- Sped up dictionary lookups
###
[`v1.28.4`](https://redirect.github.com/crate-ci/typos/releases/tag/v1.28.4 )
[Compare
Source](https://redirect.github.com/crate-ci/typos/compare/v1.28.3...v1.28.4 )
#### \[1.28.4] - 2024-12-16
##### Features
- `--format sarif` support
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - "before 11am on monday" in timezone Asia/Shanghai.
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR was generated by [Mend Renovate](https://mend.io/renovate/ ).
View the [repository job
log](https://developer.mend.io/github/oxc-project/oxc ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44NS4wIiwidXBkYXRlZEluVmVyIjoiMzkuODUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cameron Clark <cameron.clark@hey.com>
2025-01-05 22:13:32 +00:00
Max Stoumen
55744fd977
feat(semantic): allow getting mutable reference to symbols table ( #8189 )
...
Seems like the only way to get a mutable reference to the `SymbolTable`
inside `Semantic` right now is with `into_symbol_table_and_scope_tree`,
but that drops other useful info.
Since `scopes_mut` exists I figure this would be reasonable too?
Reason I'm requesting this is I have a project where I need to fill in
some symbols `oxc_semantic` doesn't yet pick up on (like function
overloads, `declare`'d symbols) and this would be the cleanest way to do
it.
2024-12-30 15:27:30 +08:00
camc314
79af10070d
fix(semantic): reference flags not correctly resolved when after an export stmt ( #8134 )
...
fixes https://github.com/oxc-project/oxc/issues/7879#issuecomment-2562574889
TLDR is curently here:
cdd121bfa4/crates/oxc_semantic/src/builder.rs (L2130-L2135)https://playground.oxc.rs/#eNpVjjuOwzAMRK8isElj7A/YxtttkVOkkR3aECCJBskkdgzdPZISG0ilGc3DcFbooQUXJmI1q/m3bJIZmII5fHx2lg9/p4hzTXWZsCL3N+RekB3qvRUxRyKDs2I8S61cEzRA0K7Al1geWaLaGVrlCzbgXdRNS08T7mYJHfnNKdsoA3GAdrBeMDUwWRbk3Jh1adn0jtYPUMsj5hOA8vP1/QuZ6OmMI5Yx2QQX3eCebLBx9K8FlYvK5I+ebiW9InckOX4uSOkBCrdvkw==
`export` **AFTER** the reference ( correct reference flags)
https://playground.oxc.rs/#eNpVjj2uwjAQhK9ibZMmen/Sa0JHwSlonLCJLNm70a6BhMh3xzEEQeUZz6fZWaCDBlwYWaJZzN6KSaYXDqb6+m6tVLsjHQmnknfeqpoDs8EpIp208Et6Q+I8Yum5ffTcqh3UwNAsIGdaH50p2gmaKGeswTuKm9aOR3yZObTsNxfFkvYsAZreesVUw2hFUXJj1mvLpl9o+YBoZcB8AlD/fn7/IRMdn3DAdUw2wZHr3YMNlgb/XFA4isL+4Pm6pheUljXHjwUp3QEtmnBd
this PR fixes this issue by resetting the reference flags after exising an export stmt
2024-12-27 14:20:17 +00:00
Yuichiro Yamashita
04c7d38287
chore(semantic): use assert_eq! instead of assert! (crates/oxc_semantic/src/scope.rs) ( #8128 )
...
related to https://github.com/oxc-project/oxc/pull/8124
2024-12-26 22:14:33 +08:00
Yuichiro Yamashita
eb0f57f40f
chore(semantic): use assert_eq! instead of assert! (crates/oxc_semantic/src/lib.rs) ( #8127 )
...
related to https://github.com/oxc-project/oxc/pull/8124
2024-12-26 13:54:21 +00:00
oxc-bot
5a1311e76c
release(crates): v0.44.0 ( #8110 )
...
## [0.44.0] - 2024-12-25
- ad2a620#8097 ) (Boshen)
### Features
- c2daa20#8048 )
(overlookmotel)
- 618b6aa#8080 )
(Boshen)
- 4727667#8078 )
(Boshen)
- 0562830#8095 )
(Boshen)
- 6237c05#8089 ) (Boshen)
- 6355b7c#8093 ) (Boshen)
- fccfda9#8088 ) (Boshen)
- f873139#8086 )
(Boshen)
- 8b8cbcd#8085 ) (Boshen)
- 414c118#8084 ) (Boshen)
- f8f067b#8083 ) (Boshen)
- 1d5ae81#8079 ) (Boshen)
- e3f78fb#8077 ) (Boshen)
- d84d60a#8074 ) (Boshen)
- 373279b#8072 )
(Boshen)
- 5397fe9#8075 ) (Boshen)
- 1932f1e#8063 ) (翠
/ green)
- 11c4bd8#8109 ) (Boshen)
- be4feb4#8041 ) (overlookmotel)
- e632a7b#8069 )
(Boshen)
### Bug Fixes
- bdc241d#8108 ) (Boshen)
- 728ed20b605baa#8096 ) (Boshen)
- de82492#8081 ) (camc314)
- 55d6eb9#8071 )
(injuly)
- be2c60d#8056 ) (Boshen)
- 708e9cf#8082 )
(camc314)
- 3057686#8049 ) (overlookmotel)
- e67cd05#8047 ) (overlookmotel)
- 6b08c6e#8042 ) (overlookmotel)
- 274f117#8053 ) (camc314)
### Performance
- 78d2e83#7926 ) (Cameron)
### Refactor
- 7110c7b#8107 ) (Boshen)
- 8b54d89#8060 ) (Boshen)
- 7cb84f3#8059 ) (Boshen)
- 77d845a#8058 ) (Boshen)
- 6123f5e#8057 ) (Boshen)
- cbd5169#8044 ) (overlookmotel)
- 98e8a72#8040 ) (overlookmotel)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-12-25 21:03:09 +08:00
camc314
708e9cfac0
fix(semantic): report errors for missing class method impls ( #8082 )
2024-12-25 12:24:33 +00:00
camc314
de82492e97
fix(parser): report syntax errors for missing constructor implementations ( #8081 )
2024-12-25 12:24:32 +00:00
Boshen
e632a7b158
feat(transformer): remove typescript symbols after transform ( #8069 )
...
part of #7460
2024-12-23 08:24:54 +00:00
oxc-bot
d69de3629d
release(crates): v0.43.0 ( #8054 )
...
## [0.43.0] - 2024-12-21
- de4c772#8031 ) (overlookmotel)
- ed75e42#7999 ) (Boshen)
### Features
- 75b775c#8017 ) (overlookmotel)
- 8547e02#8043 )
(Boshen)
- 63a95e4#7998 )
(overlookmotel)
- 897a1a8#8028 ) (overlookmotel)
- 3ea4109#7997 ) (Dunqing)
- cc57db3#7991 ) (Dunqing)
- 6b6444b#8007 ) (overlookmotel)
### Bug Fixes
- 043252d#8035 ) (overlookmotel)
- 273795d#7982 ) (overlookmotel)
### Performance
- c0dd3f8#7995 ) (overlookmotel)
- 862838f#8014 ) (Dunqing)
- 2736657#8046 )
(Boshen)
- 2e8872c#8045 ) (Boshen)
- 414e828#8012 ) (Boshen)
- 7aebed0#8021 ) (Boshen)
- 0f9308f#8018 )
(overlookmotel)
- 0deb9e6#8016 ) (overlookmotel)
- 7b70347#8013 ) (Dunqing)
### Documentation
- df5c341#7994 )
(overlookmotel)
### Refactor
- f1adf9f#8020 ) (overlookmotel)
- 02f968d#8019 )
(Boshen)
- e7476a1#8015 ) (Boshen)
- 1cf7b83#7987 ) (Dunqing)
- 48cb52b#7986 ) (Dunqing)
- 3250a47#7985 ) (Dunqing)
- efe96ec#7984 )
(Dunqing)
- ac097e9#8036 )
(overlookmotel)
- 059a5dd#8001 ) (overlookmotel)
- 0a38eea#8004 ) (overlookmotel)
- d1b7181#8006 )
(overlookmotel)
- 5a23d72#8000 )
(overlookmotel)
- b3a5f3e#7993 ) (Dunqing)
### Testing
- bcb33c0#7988 )
(Dunqing)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-12-21 15:07:21 +08:00
Boshen
2736657dcd
perf(semantic): allocate UnresolvedReferences in allocator ( #8046 )
2024-12-20 15:18:16 +00:00
Boshen
2e8872cc3f
perf(semantic): allocate child scope in allocator ( #8045 )
2024-12-20 15:18:16 +00:00
Boshen
414e8285cd
perf(semantic): allocate symbol data in Allocator ( #8012 )
2024-12-20 14:13:41 +00:00
Boshen
8547e02456
feat(ast): implement allocator_api2 for Allocator ( #8043 )
2024-12-20 13:26:48 +00:00
overlookmotel
f1adf9fa18
refactor(semantic): ScopeTree::rename_binding remove old binding first ( #8020 )
...
#8019 changed scope bindings from an ordered `IndexMap` to an unordered `FxHashMap`.
`ScopeTree::rename_binding` no longer needs to preserve order, so can remove the old binding before adding the new one. This makes it less likely that the hash map will need to reallocate.
Also remove comments about preserving ordering of bindings, which are now outdated.
2024-12-20 02:38:30 +00:00
Boshen
7aebed012d
perf(semantic): allocate Bindings in allocator ( #8021 )
2024-12-19 15:16:03 +00:00
Boshen
02f968d02d
refactor(semantic): change Bindings to a plain FxHashMap ( #8019 )
...
`IndexMap` was needed for the insertion order requirement in mangler.
Bindings (symbol ids) are monotonically increasing by binding
positions, which means we can get insertion order by sorting the symbol ids in
mangler.
Previous attempt: https://github.com/oxc-project/oxc/pull/4228
2024-12-19 14:16:28 +00:00
Boshen
e7476a1a28
refactor(semantic): remove serialize ( #8015 )
2024-12-19 09:51:12 +00:00
Boshen
ed75e42ed6
refactor(semantic)!: make SymbolTable fields pub(crate) instead of pub ( #7999 )
...
SymbolTable needs some internal changes.
2024-12-18 16:38:58 +00:00
Dunqing
bcb33c00fa
test(semantic): add a test for catch parameters reference ( #7988 )
...
I am trying to clean up Semantic, just found that we can remove this code without any test failing, but it should fail in that test case I added.
1082868855/crates/oxc_semantic/src/builder.rs (L2085-L2087)
2024-12-18 08:47:27 +00:00
Dunqing
1cf7b83431
refactor(semantic): simplify handling namespace stack ( #7987 )
...
We had a BindingIdentifier to `TSModuleDeclarationName` so that we don't need to get binding from name.
2024-12-18 07:56:13 +00:00
Dunqing
48cb52b335
refactor(semantic): remove resetting current_reference_flags in visit functions ( #7986 )
...
We have reset current_reference_flags after resolving reference flags in https://github.com/oxc-project/oxc/pull/7923 , so that we don't need to set it to empty in another place.
2024-12-18 07:56:12 +00:00
Dunqing
3250a47a97
refactor(semantic): remove unused current_symbol_flags ( #7985 )
2024-12-18 06:44:03 +00:00
Dunqing
efe96ecc12
refactor(semantic): use Stack for function stack node ids ( #7984 )
2024-12-18 06:38:59 +00:00
oxc-bot
3631eed975
release(crates): v0.42.0 ( #7983 )
...
## [0.42.0] - 2024-12-18
- 84b75a0#7935 ) (overlookmotel)
- c071494#7868 ) (overlookmotel)
### Features
- 8b7c5ae#7974 ) (overlookmotel)
- 46e2e27#7946 ) (overlookmotel)
- db9e93b#7907 ) (翠 / green)
- 075bd16#7908 ) (翠 / green)
- c16a851#7965 ) (Boshen)
- 81eedb1#7880 ) (Boshen)
- b9322c6#7886 )
(overlookmotel)
- c30a982#7973 )
(overlookmotel)
- 02b653c#7919 ) (overlookmotel)
- feac02e#7896 ) (overlookmotel)
- 6bc530d#7831 ) (Dunqing)
- 53e2bc0#7871 )
(overlookmotel)
### Bug Fixes
- 3659e6d#7862 )
(Jan Olaf Martin)
- 850dd43#7929 ) (Dunqing)
- 4799471#7937 ) (Boshen)
- de8a86e#7949 ) (翠 / green)
- 9a30910#7768 ) (IWANABETHATGUY)
- 111dc52#7963 ) (branchseer)
- 14c51ff#7932 ) (Dunqing)
- 596aead#7923 )
(Dunqing)
- 4924073#7870 ) (overlookmotel)
- bb38065#7978 ) (overlookmotel)
- e76fbb0#7872 ) (overlookmotel)
- c0576fa#7866 ) (overlookmotel)
- d660d8d#7847 ) (overlookmotel)
- 4920c6a#7832 ) (Dunqing)
### Performance
- a5f04a7#7905 ) (overlookmotel)
- 4b24335#7857 )
(Boshen)
- 71a40a2#7856 ) (Boshen)
- b31f123#7915 ) (overlookmotel)
- 8ca8fce#7904 ) (overlookmotel)
- 80d0b3e#7901 ) (overlookmotel)
- 38aafa2#7859 )
(overlookmotel)
### Documentation
- e49de81#7853 )
(overlookmotel)
- 10a86b9#7925 ) (overlookmotel)
- f4cb5d3#7918 ) (overlookmotel)
- 41a1456#7966 )
(overlookmotel)
- 18441af#7955 ) (Dunqing)
- 1317c00#7914 )
(overlookmotel)
- 9989b58#7911 ) (overlookmotel)
- 7390048#7909 )
(overlookmotel)
### Refactor
- beb982a#7848 ) (overlookmotel)
- 3858221#7883 ) (overlookmotel)
- 1314c97#7957 )
(Boshen)
- 6551dfe#7972 ) (overlookmotel)
- b8d2bd2#7924 ) (Dunqing)
- 98d7946#7887 )
(overlookmotel)
- 1cf8f8f#7869 )
(overlookmotel)
- 5d42df8#7851 ) (overlookmotel)
- 8cf9766#7863 ) (overlookmotel)
- d59bbae#7971 )
(overlookmotel)
- 2c94236#7888 )
(overlookmotel)
- 34091b2#7852 )
(overlookmotel)
- d4d7bc0#7975 ) (overlookmotel)
- 2e5ffd3#7981 ) (overlookmotel)
- 27cc6da#7980 ) (overlookmotel)
- ee282f8#7979 ) (overlookmotel)
- 94b376a#7977 ) (overlookmotel)
- ff9d1b3#7976 ) (overlookmotel)
- 6fc40f0#7968 ) (overlookmotel)
- 69eeeea#7967 ) (overlookmotel)
- 98340bb#7947 ) (overlookmotel)
- 088dd48#7913 )
(overlookmotel)
- 544ffbf#7912 ) (overlookmotel)
- dcaf674#7910 )
(overlookmotel)
- 6243980#7867 ) (overlookmotel)
- eb47d43#7854 )
(overlookmotel)
- 1380b7b#7858 ) (overlookmotel)
- 0f5e078#7855 ) (Dunqing)
- 4ea90d4#7970 ) (Dunqing)
- 15b9bff#7969 ) (overlookmotel)
### Styling
- fb897f6#7882 ) (overlookmotel)
- 7fb9d47#7877 ) (Boshen)
### Testing
- 523d48c#7922 )
(Dunqing)
- e766051#7874 ) (overlookmotel)
- f39e65e#7873 )
(overlookmotel)
Co-authored-by: Dunqing <29533304+Dunqing@users.noreply.github.com>
2024-12-18 11:48:12 +08:00
overlookmotel
6551dfef5c
refactor(semantic): pass &str instead of Cow ( #7972 )
...
As suggested by clippy...
2024-12-18 02:37:12 +00:00
Dunqing
14c51ffa1d
fix(semantic): remove inherting ScopeFlags::Modifier from parent scope ( #7932 )
...
close : #7900
After #4283 changed, we don't need to inherit `ScopeFlags` from the `constructor`, `set`, `get` anymore, I think this is a logic of forgetting to remove
2024-12-16 11:26:12 +00:00
Dunqing
b8d2bd2eba
refactor(semantic): move determining references flags for export specifier to visit_export_named_declaration ( #7924 )
...
``` ts
export type { a };
export { type b };
```
In the above cases, `a` and `b` are both type-only references. Before, we handled them in `visit_export_named_declaration` and `visit_export_specifier`, but it doesn't look intuitive due to we need to determine
if `ExportNamedSpecifier` is a type-only in `visit_export_specifier ` by checking if `current_reference_flags` is a type, and also needs to set it back before exit node.
This PR moves determining reference flags from `visit_export_specifier` to `visit_export_named_declaration` so that we don't need to check `current_reference_flags` and set it back because here we can always know the
if `ExportSpecifierNamed` is type-only by `ExportNamedDeclaration::export_kind::is_type`.
2024-12-16 02:26:53 +00:00
Dunqing
596aead0e9
fix(semantic): reset references flags when resolved ( #7923 )
...
For this case, we set `current_reference_flags` to `ReferenceFlags::Type` for `TSInterfaceHeritage`, but never unset it, which causes resolving `fowardRef` identifier reuse `current_reference_flags` of `TSInterfaceHeritage`.
```ts
import { forwardRef } from "react";
export interface MenuTriggerProps extends Object {}
export const MenuTrigger = forwardRef();
```
In this PR, reset the `current_reference_flags` when resolved, so that we don't need to reset it in individual visit functions. This is a reasonable change because the `current_reference_flags` only applies to the next encountered identifier.
2024-12-16 02:26:52 +00:00
Dunqing
523d48ccb2
test(transformer): move named test to exports folder ( #7922 )
...
I made a mistake, I should have put it in the `exports` folder and not `export`
2024-12-16 02:26:51 +00:00
overlookmotel
3858221f45
refactor(global): sort imports ( #7883 )
...
Pure refactor. Re-order imports for clarity:
1. `std`
2. External crates
3. `oxc_*` crates
4. Current crate `use crate::...`
5. Super `use super::...`
6. Local modules
This order is from "furthest away" to "closest". This makes it clearer to see what is coming from where.
`cargo +nightly fmt` (#7877 ) did a lot of the work, but unfortunately `rustfmt` does not have an option to (a) put workspace crates in a separate block from external crates and (b) move `mod` statements to after `use` statements.
2024-12-14 15:07:21 +00:00
overlookmotel
98d794673b
refactor(semantic): import flags and ID types from oxc_syntax ( #7887 )
...
`oxc_semantic` had a bit of a mess of modules importing and re-exporting symbols from `oxc_syntax` all over the place. I assume this is a leftover from when our crates were structured differently.
Make this consistent by always importing `oxc_syntax`'s symbols from `oxc_syntax`, and only re-export them from the crate root.
2024-12-14 14:48:28 +00:00
overlookmotel
b9322c68e6
feat(semantic): re-export all flags and ID types ( #7886 )
...
`oxc_semantic` already re-exports `ScopeId`, `ScopeFlags`, `SymbolId` and `SymbolFlags` from `oxc_syntax`. It seems inconsistent that it doesn't also re-export `ReferenceId`, `ReferenceFlags`, `NodeId` and `NodeFlags` too. Do that.
2024-12-14 14:48:27 +00:00
Boshen
7fb9d47460
style(rust): cargo +nightly fmt ( #7877 )
2024-12-14 06:03:31 +00:00
overlookmotel
492407386b
fix(semantic): ScopeTree::rename_binding preserve order of bindings ( #7870 )
...
`ScopeTree::rename_binding` was previously altering the order of bindings in the `FxIndexMap`. Order of bindings matters in the mangler. Reimplement `rename_binding` to preserve original order.
2024-12-14 04:28:53 +00:00
overlookmotel
1cf8f8f2ca
refactor(semantic): SymbolTable::set_name return old name ( #7869 )
...
`SymbolTable::set_name` return old symbol name. `set_name` is marked `#[inline]`, so where the caller does not use the old name, getting it should be optimized out by the compiler. So it makes the method more flexible, at no cost.
2024-12-14 04:28:52 +00:00
overlookmotel
c0714945b2
refactor(semantic)!: remove SymbolTable::rename method ( #7868 )
...
Remove `SymbolTable::rename` method. We also have `SymbolTable::set_name` method which does the same thing.
2024-12-14 04:28:51 +00:00
Jan Olaf Martin
3659e6d768
fix(cfg): include export default code in CFG instructions ( #7862 )
...
Previously any instructions happening inside of the expression passed to
`export default` were invisible in the CFG.
Example:
```
// Uncommenting this line makes the call to bar() disappear from the
// CFG view of the program:
// export default
bar();
```
2024-12-14 12:09:28 +08:00
