Boshen
4bdc202325
refactor(rust): remove some #[allow(unused)] ( #5716 )
2024-09-12 02:19:01 +00:00
overlookmotel
e02621d2d1
refactor(semantic): re-order use statements ( #5712 )
...
Pure refactor. Re-order `use` statements in `oxc_semantic` to follow this order:
1. `std`
2. External crates.
3. `oxc_*` crates.
4. Local crate.
5. `super`
6. `mod`
This is intended to be in order from "furthest above" to "furthest below".
2024-09-11 20:41:49 +00:00
overlookmotel
ac6203c891
refactor(semantic): move Counts code into counter module ( #5710 )
...
Pure refactor. Move code for counting nodes etc, and verifying counts, into `counter` module.
2024-09-11 20:41:48 +00:00
overlookmotel
339fcfc8be
refactor(semantic): rename Counts in transform checker ( #5709 )
...
Pure refactor. Just renaming.
2024-09-11 20:41:48 +00:00
overlookmotel
d8ec78192e
refactor(semantic): remove record_ast_node call for Program ( #5701 )
...
Remove a tiny bit of dead code from `SemanticBuilder`.
`record_ast_node` does nothing if `ast_node_records` is empty. It is always empty when visiting `Program`, so is a no-op.
2024-09-11 11:31:20 +00:00
overlookmotel
1857ff09eb
style(semantic): rename vars for node IDs ( #5699 )
...
`test_node_id` not `test_node` to better describe what these vars contain.
2024-09-11 10:55:42 +00:00
oxc-bot
a727ee8aca
release(oxc): crates v0.28.0 ( #5696 )
...
## [0.28.0] - 2024-09-11
- afc4548#5679 ) (Boshen)
- 7415e85#5678 ) (Boshen)
- ee4fb42#5677 ) (Boshen)
- 1fa3e56#5621 ) (overlookmotel)
- 96a1552#5620 ) (overlookmotel)
- 4a8aec1#5606 ) (Boshen)
- 603817b#5557 ) (Boshen)
- b060525#5553 ) (Boshen)
### Features
- 2da5ad1#5556 )
(overlookmotel)
- 2016bae#5676 )
(Boshen)
- 68c3cf5#5670 ) (Boshen)
- c6bbf94#5669 ) (Boshen)
- 86256ea#5666 ) (Boshen)
- e698418#5657 ) (Boshen)
- aba9194#5533 )
(underfin)
- 642295c#5558 ) (overlookmotel)
- b3cbd56#5610 ) (overlookmotel)
- 95a6d99#5630 ) (Dunqing)
- 7b543df#5638 ) (Dunqing)
- 17226dd#5559 )
(overlookmotel)
### Bug Fixes
- d62defb#5551 ) (Boshen)
- 1bc08e2#5579 ) (Boshen)
- 28b934c#5555 ) (Boshen)
- b9bf544#5681 ) (Dunqing)
- 6e8409a#5680 ) (Dunqing)
- b8f8dd6#5691 ) (Boshen)
- 304ce25#5692 ) (leaysgur)
- 0511d55#5661 ) (leaysgur)
- 41582ea#5635 ) (leaysgur)
- 28aad28#5631 ) (leaysgur)
- f9e3a41#5673 ) (Boshen)
- f49e6eb#5612 ) (Boshen)
- 919d17f#5589 ) (Boshen)
- 505d064#5560 ) (overlookmotel)
- 9b7ecc7#5508 ) (overlookmotel)
- d1ece19#5501 ) (overlookmotel)
- a1afd48#5695 ) (Dunqing)
- f2f5e5a#5693 ) (Dunqing)
- a891c31#5656 ) (Dunqing)
- 3e8b96f#5655 ) (Dunqing)
- 0739b5f#5642 ) (Dunqing)
- 3bf6aaf#5629 ) (Dunqing)
- 36d864a#5528 ) (Dunqing)
### Performance
- e8013d2#5626 )
(overlookmotel)
- 4996874#5611 )
(overlookmotel)
### Documentation
- fefbbc1#5539 )
(overlookmotel)
- 9282647#5514 ) (overlookmotel)
- 1c051ae#5607 ) (overlookmotel)
- 2e24a15#5604 ) (overlookmotel)
### Refactor
- 14ee086#5547 ) (overlookmotel)
- 2de6ea0#5650 )
(overlookmotel)
- 0ac420d#5564 )
(Don Isaac)
- 2da42ef#5665 ) (leaysgur)
- dec1395#5543 ) (leaysgur)
- 731ffaa#5686 )
(overlookmotel)
- 067f9b5#5672 ) (Boshen)
- d22a9b7#5622 )
(overlookmotel)
- 3d190a5#5609 )
(overlookmotel)
- 5532628ce71982#5554 )
(overlookmotel)
- 758a10c#5527 )
(overlookmotel)
- fad0a05#5504 )
(overlookmotel)
- 19cdcc5#5652 ) (overlookmotel)-
26d9235#5577 ) (夕舞八弦)
### Styling
- e52d006#5651 )
(overlookmotel)
- 97e99bd#5603 ) (overlookmotel)-
694f032#5542 )
(overlookmotel)
### Testing
- 2e367c9#5625 )
(overlookmotel)- dc92489#5541 ) (overlookmotel)
---------
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2024-09-11 17:57:55 +08:00
Dunqing
36d864a0c3
fix(transformer/react): don't transform if the variable does not have a value reference ( #5528 )
...
close : #4746
Solved the last two tests, but it's a coincidence. I've added a test to cover it.
2024-09-11 07:10:55 +00:00
overlookmotel
731ffaa00e
refactor(semantic): compare nodes by pointer equality ( #5686 )
...
Follow up after #5673 .
It's safer to compare nodes by pointer equality than by equality of `Span`s. Transformer can create multiple nodes of same type with same span.
Once nodes have node IDs, we can use them for comparison instead.
That said, `ptr::eq` is much cheaper, as it doesn't have to follow the pointers to check equality. https://godbolt.org/z/hsqaeKr5M
2024-09-11 02:12:12 +00:00
Boshen
f9e3a41dd2
fix(semantic): bind SymbolId to function name in if (foo) function id() {} ( #5673 )
2024-09-10 11:05:26 +00:00
Boshen
067f9b5a6f
refactor(semantic): introduce IsGlobalReference trait ( #5672 )
2024-09-10 10:12:08 +00:00
Boshen
86256ea238
feat(minifier): constant fold typeof ( #5666 )
...
closes #5628
2024-09-10 04:43:00 +00:00
overlookmotel
d22a9b72e0
refactor(semantic): SymbolTable::is_empty use is_empty ( #5622 )
...
Nit. `is_empty()` is sometimes more performant than `len() == 0`.
2024-09-09 01:07:34 +00:00
overlookmotel
1fa3e5687a
refactor(semantic)!: rename SymbolTable::iter to symbol_ids ( #5621 )
...
`symbol_ids` is a more descriptive name.
2024-09-09 01:07:33 +00:00
overlookmotel
96a15526aa
refactor(semantic)!: remove SymbolTable::iter_rev ( #5620 )
...
#5615 removed the only usage of this method, so it's now dead code.
2024-09-09 01:07:33 +00:00
Boshen
4a8aec1605
feat(span)!: change SourceType::js to SourceType::cjs and SourceType::mjs ( #5606 )
2024-09-08 14:11:02 +00:00
Boshen
63a830e08c
chore(dprint): format toml files ( #5599 )
...
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-09-08 14:26:16 +08:00
Boshen
603817bef9
feat(oxc)!: add SourceType::Unambiguous; parse .js as unambiguous ( #5557 )
...
See https://babel.dev/docs/options#misc-options for background on `unambiguous`
Once `SourceType::Unambiguous` is parsed, it will correctly set the returned `Program::source_type` to either `module` or `script`.
2024-09-07 10:48:58 +00:00
overlookmotel
642295c15a
feat(semantic): add SymbolTable::delete_resolved_reference method ( #5558 )
...
Add `SymbolTable::delete_resolved_reference` method to delete a reference for a symbol.
2024-09-07 03:51:35 +00:00
Don Isaac
0ac420d6f9
refactor(linter): use meaningful names for diagnostic parameters ( #5564 )
...
Also add `pending` fix labels to many rules.
2024-09-06 18:14:56 -04:00
Boshen
b06052501a
refactor(semantic)!: remove source_type argument from SemanticBuilder::new ( #5553 )
...
Realized we can get the source type from the AST.
The next PR will introduce `unambiguous` to `SourceType` and directly set `Program::source_type` to either `script` or `module`.
2024-09-06 16:40:10 +00:00
overlookmotel
dc924892cc
test: add trailing line breaks to conformance fixtures ( #5541 )
...
Continuation of #5537 . Ensure all conformance fixture files have a trailing line break.
2024-09-06 12:55:17 +00:00
oxc-bot
64eb2cccb7
release: crates v0.27.0 ( #5538 )
...
## [0.27.0] - 2024-09-06
- bd820f9#5480 ) (overlookmotel)
- cba93f5#5466 ) (overlookmotel)
- 87c5df2#5448 ) (overlookmotel)
### Features
- e8bdd12#5515 ) (overlookmotel)
- 90facd3#5451 ) (rzvxa)
- 23285f4#5427 ) (rzvxa)
- 59abf27#5256 ) (rzvxa)
- 68a1c01#5278 ) (rzvxa)
- c782916#5438 ) (Dunqing)
- 4cb63fe#5421 )
(IWANABETHATGUY)
- ba4b68c#5439 )
(Boshen)
- ed8ab6d#5524 )
(IWANABETHATGUY)
- 91b39c4#5474 )
(IWANABETHATGUY)
- 10279f5#5440 ) (Boshen)
- 0f50b1e#5463 ) (DonIsaac)
- 62f7fff#5461 ) (DonIsaac)
- 5407143#5460 ) (DonIsaac)
- 052e94c#5459 ) (DonIsaac)
- 32d4bbb#5495 )
(Boshen)
- c59d8b3#5387 ) (Dunqing)
- cedf7a4#5491 )
(IWANABETHATGUY)
### Bug Fixes
- 0df1d9d#5431 ) (rzvxa)
- fce549e#5526 ) (Boshen)
- ea7a52f9b984b3#5469 ) (rzvxa)
- 88b7ddb#5523 ) (leaysgur)
- 7a797ac#5525 ) (Dunqing)
- d8b9909#5441 ) (Dunqing)
- 8f9627d#5494 ) (overlookmotel)
- 2060efc#5486 ) (overlookmotel)
- cfe5497#5414 ) (overlookmotel)
- 0617249#5408 ) (Dunqing)
- 0eb32a6#5407 ) (Dunqing)- b96bea4#5507 ) (IWANABETHATGUY)
### Performance
- bfabd8f#5426 )
(overlookmotel)
- aeda84f#5425 ) (overlookmotel)
- ed8937e#5518 ) (Dunqing)
- bfab091#5484 )
(overlookmotel)
- b4765af#5483 ) (overlookmotel)
- 182ab91#5482 ) (overlookmotel)
### Documentation
- 64db1b4#5497 ) (overlookmotel)
- 3f204a9#5478 ) (overlookmotel)- 00511fd#5423 ) (IWANABETHATGUY)
### Refactor
- 9f6e0ed#5468 ) (rzvxa)
- a43e951#5447 ) (overlookmotel)
- 2224cc4#5464 ) (overlookmotel)
- a952c47#5449 ) (overlookmotel)
- d9d7e7c#5327 )
(overlookmotel)
- ccc8a27#5462 ) (rzvxa)
- fdb8857#5417 )
(rzvxa)
- e7bd49d#5429 ) (overlookmotel)
- e4ed41d#5444 ) (Dunqing)
- 94a6ac6#5476 ) (overlookmotel)
- b47aca0#5280 ) (rzvxa)
- a96866d#5499 ) (overlookmotel)
- 6abde0a#5498 )
(overlookmotel)
- 09c522a#5496 ) (overlookmotel)
- dd19823#5492 ) (overlookmotel)
- 2514cc9#5473 ) (Dunqing)
- c984219#5422 ) (Dunqing)
### Styling
- 2a43fa4#5491 and reduce
the if nesting (#5512 ) (dalaoshu)
### Testing
- 340b535#5510 ) (Don Isaac)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-09-06 19:06:29 +08:00
Dunqing
7a797ac635
fix(semantic): incorrect reference when MemberExpression used in TSPropertySignature ( #5525 )
...
close: https://github.com/oxc-project/oxc/issues/5435#issuecomment-2333032168
2024-09-06 06:24:45 +00:00
Boshen
1bed5ce2a5
chore: run cargo +nightly fmt to sort imports ( #5503 )
...
They are never going to be stable are they ... cedf7a4daa/.rustfmt.toml (L8-L16)
2024-09-06 04:04:26 +00:00
dalaoshu
2a43fa4efd
style(linter): introduce the writing style from PR #5491 and reduce the if nesting ( #5512 )
...
Related to #5491
2024-09-06 11:19:48 +08:00
Don Isaac
340b535715
test(linter/no-unused-vars): arrow functions in tagged templates ( #5510 )
...
Closes #5391
2024-09-05 14:55:39 -04:00
overlookmotel
bd820f9c16
refactor(semantic)!: remove SymbolTable::get_symbol_id_from_name and SymbolTable::get_scope_id_from_name ( #5480 )
...
Close #5456 .
2024-09-05 13:57:55 +00:00
Dunqing
e4ed41d4fa
refactor(semantic): change the reference flag to ReferenceFlags::Type if it is used within a TSTypeQuery ( #5444 )
...
So far, the `ReferenceFlags::TSTypeQuery` only used indicates it is referenced by `TSTypeQuery` that we can confirm the reference should be regarded as a type reference, namely `ReferenceFlags::Type`.
This PR adds a `ReferenceFlags::ValueAsType` instead of `ReferenceFlags::TSTypeQuery`. The new flag has the same behavior as the previous one. But it looks more general and is not only used in `TSTypeQuery`. But now it is a temporary flag. We use it to resolve the symbol correctly and replace `ReferenceFlags::ValueAsTyoe` with `ReferenceFlags::Type` after resolved.
Also, this change eliminates the inconsistency in behavior between the `Reference::is_type` and `ReferenceFlags::is_type` methods.
2024-09-05 01:50:20 +00:00
Dunqing
d8b9909bd8
fix(semantic): IdentifierReference within TSPropertySignature cannot reference type-only import binding ( #5441 )
...
close : #5435
The behavior of `IdentifierReference` in `TSPropertySignature` is the same as in `TSTypeQuery`, both allow only reference value bindings and type-only import bindings.
I still use `ReferenceFlags::TSTypeQuery` here because I want to avoid producing many changes unrelated to the bug in this PR. I will refactor it in the follow-up PR soon
2024-09-05 01:50:18 +00:00
DonIsaac
0f50b1ed6d
feat(semantic): check for initializers in ambient VariableDeclarations ( #5463 )
2024-09-05 01:33:11 +00:00
DonIsaac
62f7fff88f
feat(semantic): check for non-declared, non-abstract object accessors without bodies ( #5461 )
2024-09-05 01:33:10 +00:00
DonIsaac
540714393a
feat(semantic): check for non-declared, non-abstract class accessors without bodies ( #5460 )
...
This should be causing more negative tests to fail than it actually is. This is
because our typescript coverage tests use the "declarations" option to change
the source type to `.d.ts`, which is incorrect. This setting enables `.d.ts`
emits, it does not mean that input files should be treated as `.d.ts`
themselves.
2024-09-05 01:33:09 +00:00
DonIsaac
052e94c94e
feat(semantic): check for parameter properties in constructor overloads ( #5459 )
...
Adds checks for
```
A parameter property is only allowed in a constructor implementation.ts(2369)
```
2024-09-05 01:33:07 +00:00
oxc-bot
be1a6d4c84
Release crates v0.26.0 ( #5418 )
...
## [0.26.0] - 2024-09-03
- 1aa49af#5358 ) (Dunqing)
- 01cc2ce#5403 ) (Boshen)
- b1d0075#5398 ) (Boshen)
- 32f7300#5223 ) (Dunqing)
- 23e8456#5294 ) (overlookmotel)
- 582ce9e#5286 ) (overlookmotel)
- 234a24c#5270 ) (Kevin Deng 三咲智子)
- c100826#5110 ) (overlookmotel)
- d304d6f#5109 ) (overlookmotel)
### Features
- 180b1a1#5361 ) (DonIsaac)
- 5505749#5290 )
(Dunqing)
- 49cd5db#5182 ) (DonIsaac)
- c2fa725#5179 ) (DonIsaac)
- 292d162#5291 )
(Dunqing)
- 72740b3#5170 )
(dalaoshu)
- f81e8a1#5364 )
(DonIsaac)
- 9c22ce9#5318 )
(DonIsaac)
- d22bd20#5184 ) (Kevin Deng 三咲智子)
- 7dfd51a#5181 ) (DonIsaac)
- a563968#5180 )
(DonIsaac)
- 46b641b#5218 )
(leaysgur)
- be4642f#5410 )
(overlookmotel)
- 6e969f9#5305 ) (overlookmotel)
- 1b20ceb#5385 )
(Boshen)
- 5a137f0#5242 )
(DonIsaac)
- f5e05db#5240 ) (DonIsaac)
- d04857b#5336 )
(Dunqing)
- 3d4a64c#5335 ) (Dunqing)
- 0eb7602#5323 ) (Dunqing)
- 08dc0ad#3133 ) (magic-akari)
- 01c0c3e#5169 ) (Boshen)
- 056c667#5188 ) (Dunqing)
- 0abfc50#5399 ) (Dunqing)
### Bug Fixes
- 8ebc23f#5199 )
(Kevin Deng 三咲智子)
- 5c4c001#5303 ) (Boshen)
- 7b1546bff7fa98#5120 ) (Boshen)
- 8a17807#5343 ) (overlookmotel)
- d4c06ef#5297 ) (overlookmotel)
- e1d8b92e6fd52e#5285 ) (Boshen)
- 1686920#5225 ) (leaysgur)
- cffce11#5282 )
(leaysgur)
- 293413f#5161 ) (Dunqing)
- a6bb3b1#5239 ) (DonIsaac)
- 35f03db#5366 ) (Dunqing)
- 8d6b05c#5298 ) (Boshen)
- 47e69a8#5066 ) (Dunqing)
- 94ff94c#5356 ) (Dunqing)
- f8bb022#5190 ) (Dunqing)
- d9ba5ad#5189 )
(Dunqing)
- 3acb3f6#5255 ) (Dunqing)
- 5754c89#5292 ) (Dunqing)
- d594818#5409 ) (overlookmotel)
- 25d6e20#5118 ) (overlookmotel)
### Performance
- 292f217#5344 )
(overlookmotel)
- 12a7607#5221 ) (overlookmotel)
- fb847bd#5192 ) (Boshen)
- a1523c6#5412 ) (overlookmotel)
### Documentation
- 8334bd4#5337 ) (Dunqing)
- d51a954#5186 ) (Dunqing)
### Refactor
- c2d8c9e#5367 ) (overlookmotel)
- 946c867#5325 ) (overlookmotel)
- 960e1d5#5157 ) (overlookmotel)
- f63b568#5130 )
(overlookmotel)
- d4c3778#5222 ) (overlookmotel)
- 543cad6cd63336#5317 )
(DonIsaac)
- d236554#5345 ) (overlookmotel)
- bc59dd2#5234 )
(overlookmotel)
- a3ddfdd#5233 ) (overlookmotel)
- 3ae94b805d25e2#5262 ) (overlookmotel)
- fdedc0f#5261 ) (overlookmotel)
- 1086109#5260 ) (overlookmotel)
- af5713e#5259 ) (overlookmotel)
- 943454f#5252 ) (overlookmotel)
- 892a7fa#5253 ) (overlookmotel)
- cbb4725#5250 )
(overlookmotel)
- a17cf33#5232 ) (Boshen)
- d5a4940#5138 )
(Boshen)
- 94f60e7#5241 )
(DonIsaac)
- 0de844d#5339 ) (overlookmotel)
- 5136f01#5131 )
(overlookmotel)
- 260c9d2#5187 ) (Dunqing)
- 1645115#5319 ) (Dunqing)
- d2666fe#5320 ) (Dunqing)
- 7e2a7af#5289 ) (Dunqing)
- b43a394#5293 ) (overlookmotel)
- d71f0ed#5279 )
(overlookmotel)
- 188ce07#5277 )
(overlookmotel)
- 0f4a8b3#5272 )
(overlookmotel)
- 341e42a#5269 )
(overlookmotel)
- eba5033#5119 )
(overlookmotel)
- f771d7c#5116 ) (overlookmotel)
- c6590ae#5115 )
(overlookmotel)
- fc2e9ad#5114 )
(overlookmotel)
- 1ba11a3#5112 )
(overlookmotel)
- 40e2f6e#5111 ) (overlookmotel)
- b39c0d6#5217 ) (Kevin Deng 三咲智子)
### Testing
- 7009177be7b8c6#5224 )
(Dunqing)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-09-03 10:36:02 +08:00
overlookmotel
be4642fc02
feat(semantic): transform checker check child scope IDs ( #5410 )
...
Transform checker check child scope IDs. If we have to track child scope IDs, we should make sure they're correct!
2024-09-03 00:57:13 +00:00
overlookmotel
d594818701
fix(traverse): insert_scope_below update child scopes records ( #5409 )
...
Follow on after #5403 . Make `Traverse` update child scope IDs when inserting new scope. These lines were removed in #5232 , but not reinstated in #5403 .
2024-09-03 00:57:12 +00:00
Boshen
01cc2ceac0
feat(semantic)!: add ScopeTree:get_child_ids API behind a runtime flag ( #5403 )
...
The runtime API for enabling `get_child_ids` is `SemanticBuilder::with_scope_tree_child_ids`.
I've tested this PR in Rolldown to ensure correctness.
2024-09-02 16:22:26 +00:00
Dunqing
be7b8c6845
test(semantic): add JSXIdentifierReference-related tests ( #5224 )
...
These tests demonstrate what kind of JSX will have references.
2024-08-30 17:43:34 +00:00
Dunqing
32f730085c
feat(ast)!: add JSXElementName::IdentifierReference and JSXMemberExpressionObject::IdentifierReference ( #5223 )
...
close : #3528
part of #4746
2024-08-30 11:11:04 +00:00
Boshen
3ae94b8801
refactor(semantic): change build_module_record to accept &Path instead of PathBuf
2024-08-30 12:24:49 +08:00
overlookmotel
6e969f9fa4
feat(semantic): add ScopeTree::delete_root_unresolved_reference ( #5305 )
...
Add an API to `ScopeTree` to delete an unresolved reference.
2024-08-29 08:39:09 +00:00
Kevin Deng 三咲智子
234a24c14d
fix(ast)!: merge UsingDeclaration into VariableDeclaration ( #5270 )
...
relate #2854
2024-08-28 11:26:05 +08:00
overlookmotel
05d25e2aa3
refactor(semantic): combine add scope methods ( #5262 )
...
#5232 removed `ScopeTree::child_ids`, so it's no longer necessary to have separate `add_scope` and `add_root_scope` methods.
2024-08-27 13:00:21 +00:00
overlookmotel
fdedc0f8b1
refactor(semantic): transform checker: rename SemanticData to Scoping ( #5261 )
...
Pure refactor. Rename type and vars with a more descriptive name.
2024-08-27 11:58:21 +00:00
overlookmotel
10861096e0
refactor(semantic): transform checker do not output spans in errors ( #5260 )
...
Transform checker don't output spans in errors. They're inaccurate because (a) spans refer to the source text pre-transform, and (b) most errors relate to scopes/symbols/references newly created in transformer, which have no span.
2024-08-27 11:58:21 +00:00
overlookmotel
af5713e411
refactor(semantic): transform checker continue checks if missing IDs ( #5259 )
...
Transform checker don't bail out if some IDs missing from AST. Continue to check for other problems.
Also simplify iterating over pairs of IDs.
2024-08-27 11:58:20 +00:00
overlookmotel
943454fa5e
refactor(semantic): update transform checker for no conditional scopes ( #5252 )
...
All scopes are now unconditional (#5008 ). Update transform checker to reflect this.
2024-08-27 08:57:15 +00:00
overlookmotel
892a7fab60
refactor(semantic): replace ref syntax ( #5253 )
...
Pure code style refactor. Prefer `if let Some(y) = &x.y` over `if let Some(ref y) = x.y`.
2024-08-27 08:13:14 +00:00
overlookmotel
cbb47252ba
refactor(semantic): add comment to transform checker ( #5250 )
...
Add back a doc comment which was accidentally removed in #5232 .
2024-08-27 07:38:52 +00:00
