Hi! I have created a proof of concept of improving using oxc in
JavaScript. The method is not polished but it provides valuable insights
for future direction!
Feel free to close~ It is for reference only :)
# Context
This is a proof of concept implementation of passing binary AST to
JavaScript. JavaScript can selectively read flexbuffers-based AST nodes
on demand to avoid the deserialization toll. More context
[here](https://dev.to/herrington_darkholme/benchmark-typescript-parsers-demystify-rust-tooling-performance-2go8).
# Changes
* Add a `parseSyncBuffer` napi method to return a binary AST from Rust
to JavaScript. The AST is in flexbuffer format.
* Add a `test_buffer.js` to test usage of flexbuffers in JavaScript. It
is in cjs format because flexbuffers does not support ESM :/
# Result
Some preliminary results, for reference only.
```
~ node test_buffer.js
testJSON: 4.043s
testBuffer: 2.395s
```
Buffer based API is 100% faster than JSON.
# Future Ideas
* Flexbuffers itself is slow. A better binary protocol is desired!
* Using binary reader to traverse AST is undesirable. A proxy-based API
to emulate object behavior will be nice.
### This PR did the following things.
1. Parse specs
2. Collect `run_spec's` arguments
3. Pass the correct `PrettierOptions` to the `Prettier`
4. Printing snapshots correctly
Bumps the dependencies group with 1 update:
[env_logger](https://github.com/rust-cli/env_logger).
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/rust-cli/env_logger/blob/main/CHANGELOG.md">env_logger's
changelog</a>.</em></p>
<blockquote>
<h2>[0.10.1] - 2023-11-10</h2>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="36623f573b"><code>36623f5</code></a>
chore: Release env_logger version 0.10.1</li>
<li><a
href="8a033d8438"><code>8a033d8</code></a>
chore: Fix packaging</li>
<li><a
href="9df7e6c081"><code>9df7e6c</code></a>
Merge pull request <a
href="https://redirect.github.com/rust-cli/env_logger/issues/241">#241</a>
from ChrisDenton/simple-insert</li>
<li><a
href="46ccdd94f5"><code>46ccdd9</code></a>
perf: Replace <code>HashMap</code> with a <code>Vec</code></li>
<li><a
href="bdc96a421f"><code>bdc96a4</code></a>
Merge pull request <a
href="https://redirect.github.com/rust-cli/env_logger/issues/249">#249</a>
from atouchet/v10</li>
<li><a
href="983837c47b"><code>983837c</code></a>
Update links and remove broken badge</li>
<li><a
href="dcd220dfaf"><code>dcd220d</code></a>
Update listed version number</li>
<li><a
href="36b1508ea1"><code>36b1508</code></a>
Merge pull request <a
href="https://redirect.github.com/rust-cli/env_logger/issues/260">#260</a>
from y-yagi/2018-edition</li>
<li><a
href="6f64347c6a"><code>6f64347</code></a>
Merge pull request <a
href="https://redirect.github.com/rust-cli/env_logger/issues/282">#282</a>
from epage/syntax</li>
<li><a
href="b29735781a"><code>b297357</code></a>
chore: Update docs and examples to 2018 edition</li>
<li>Additional commits viewable in <a
href="https://github.com/rust-cli/env_logger/compare/v0.10.0...v0.10.1">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
> [!NOTE]
> This is going to be a community project because I don't have the time
and energy to work on this alone.
# Prettier
Background: 22.5K USD bounty for prettier written in Rust?!
See https://console.algora.io/challenges/prettier
> [!WARNING]
> ## Contribution Agreement
>
> You hereby agree that you contribute for fun and for the purpose of
learning, not for the goal of winning the challenge.
>
> In the unlikely event of winning the challenge, @boshen will
ultimately decide on how to spend the money.
>
> [!IMPORTANT]
Please talk to me on [discord](https://discord.com/invite/9uXCAwqQZW)
and indicate that you are willing to contribute and agree to the
contribution agreement.
## Getting started
Create a `test.js` and run the example `just example prettier` from
`crates/oxc_prettier/examples/prettier.rs`, follow the code structure
and read the references documented at the top of the files.
# Tasks
- [x] Have the basic infrastructure ready for contribution
- [ ] Implement a test runner in Rust which extracts the snapshots and
do a comparison over it
- [ ] Establish a way to pass all the tests by manually porting code
- [ ] Pass as many tests as possible in
https://github.com/prettier/prettier/tree/main/tests/format/js
Bumps the dependencies group with 4 updates:
[regex](https://github.com/rust-lang/regex),
[ropey](https://github.com/cessen/ropey),
[thiserror](https://github.com/dtolnay/thiserror) and
[codspeed-criterion-compat](https://github.com/CodSpeedHQ/codspeed-rust).
Updates `regex` from 1.10.1 to 1.10.2
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/rust-lang/regex/blob/master/CHANGELOG.md">regex's
changelog</a>.</em></p>
<blockquote>
<h1>1.10.2 (2023-10-16)</h1>
<p>This is a new patch release that fixes a search regression where
incorrect
matches could be reported.</p>
<p>Bug fixes:</p>
<ul>
<li>[BUG <a
href="https://redirect.github.com/rust-lang/regex/issues/1110">#1110</a>](<a
href="https://redirect.github.com/rust-lang/regex/issues/1110">rust-lang/regex#1110</a>):
Revert broadening of reverse suffix literal optimization introduced in
1.10.1.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="5f1f1c8b6d"><code>5f1f1c8</code></a>
1.10.2</li>
<li><a
href="1a54a829ba"><code>1a54a82</code></a>
deps: bump regex-automata to 0.4.3</li>
<li><a
href="61242b1e0e"><code>61242b1</code></a>
regex-automata-0.4.3</li>
<li><a
href="50fe7d177d"><code>50fe7d1</code></a>
changelog: 1.10.2</li>
<li><a
href="eb950f65e6"><code>eb950f6</code></a>
automata/meta: revert broadening of reverse suffix optimization</li>
<li><a
href="e7bd19dd3e"><code>e7bd19d</code></a>
regex-lite-0.1.5</li>
<li><a
href="0086dec69a"><code>0086dec</code></a>
lite: fix stack overflow test</li>
<li><a
href="4ae14720e9"><code>4ae1472</code></a>
tests: fix compilation of doctests on 32-bit architectures</li>
<li><a
href="cd79881df4"><code>cd79881</code></a>
regex-lite-0.1.4</li>
<li><a
href="466e42ca2b"><code>466e42c</code></a>
lite: fix stack overflow in NFA compiler</li>
<li>See full diff in <a
href="https://github.com/rust-lang/regex/compare/1.10.1...1.10.2">compare
view</a></li>
</ul>
</details>
<br />
Updates `ropey` from 1.6.0 to 1.6.1
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/cessen/ropey/blob/master/CHANGELOG.md">ropey's
changelog</a>.</em></p>
<blockquote>
<h2>[1.6.1] - 2023-10-18</h2>
<ul>
<li>Fixed test code that was incorrect on some platforms / with some
configurations.</li>
<li>Minor documentation improvements.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="d41ee247f2"><code>d41ee24</code></a>
Prepare for release v1.6.1.</li>
<li><a
href="c185ec562e"><code>c185ec5</code></a>
Expose tree constants for internal testing.</li>
<li><a
href="dfb0a78635"><code>dfb0a78</code></a>
Merge pull request <a
href="https://redirect.github.com/cessen/ropey/issues/91">#91</a> from
blinxen/master</li>
<li><a
href="e629850c3a"><code>e629850</code></a>
[tests] Run search_char_idx_02 and search_line_break_idx_04 only in
debug mode</li>
<li><a
href="387ea30b35"><code>387ea30</code></a>
Merge pull request <a
href="https://redirect.github.com/cessen/ropey/issues/86">#86</a> from
tshepang/patch-1</li>
<li><a
href="9e257b06c4"><code>9e257b0</code></a>
Revert "missing comma"</li>
<li><a
href="1af8c3983b"><code>1af8c39</code></a>
missing comma</li>
<li><a
href="7393572984"><code>7393572</code></a>
missing comma (for readability)</li>
<li><a
href="f1292371ca"><code>f129237</code></a>
Merge pull request <a
href="https://redirect.github.com/cessen/ropey/issues/81">#81</a> from
Johan-Mi/master</li>
<li><a
href="3485d8c9d3"><code>3485d8c</code></a>
Remove unused lifetimes</li>
<li>See full diff in <a
href="https://github.com/cessen/ropey/compare/v1.6.0...v1.6.1">compare
view</a></li>
</ul>
</details>
<br />
Updates `thiserror` from 1.0.49 to 1.0.50
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/dtolnay/thiserror/releases">thiserror's
releases</a>.</em></p>
<blockquote>
<h2>1.0.50</h2>
<ul>
<li>Improve diagnostic when a #[source], #[from], or #[transparant]
attribute refers to a type that has no std::error::Error impl (<a
href="https://redirect.github.com/dtolnay/thiserror/issues/258">#258</a>,
thanks <a
href="https://github.com/de-vri-es"><code>@de-vri-es</code></a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="a7d220d791"><code>a7d220d</code></a>
Release 1.0.50</li>
<li><a
href="4088d169ed"><code>4088d16</code></a>
Ignore module_name_repetitions pedantic clippy lint</li>
<li><a
href="ebebf77fe0"><code>ebebf77</code></a>
Format ui tests with rustfmt</li>
<li><a
href="ff0a0a5859"><code>ff0a0a5</code></a>
Source and From attributes only have single-ident path</li>
<li><a
href="7cec716420"><code>7cec716</code></a>
Remove reliance on Spanned for Member</li>
<li><a
href="c9fe739272"><code>c9fe739</code></a>
Touch up PR 258</li>
<li><a
href="4850c6f80f"><code>4850c6f</code></a>
Merge pull request <a
href="https://redirect.github.com/dtolnay/thiserror/issues/258">#258</a>
from de-vri-es/as-dyn-error-span</li>
<li><a
href="a49f7c603d"><code>a49f7c6</code></a>
Change span of <code>as_dyn_error()</code> to point compile error at
attribute.</li>
<li><a
href="f4eac7ef7b"><code>f4eac7e</code></a>
Ignore needless_raw_string_hashes clippy lint</li>
<li>See full diff in <a
href="https://github.com/dtolnay/thiserror/compare/1.0.49...1.0.50">compare
view</a></li>
</ul>
</details>
<br />
Updates `codspeed-criterion-compat` from 2.2.0 to 2.3.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/CodSpeedHQ/codspeed-rust/releases">codspeed-criterion-compat's
releases</a>.</em></p>
<blockquote>
<h2>v2.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>fix(ci): change the version of the codspeed action to main by <a
href="https://github.com/art049"><code>@art049</code></a> in <a
href="https://redirect.github.com/CodSpeedHQ/codspeed-rust/pull/18">CodSpeedHQ/codspeed-rust#18</a></li>
<li>feat(cargo-codspeed): add <code>--features vendored-openssl</code>
by <a href="https://github.com/Boshen"><code>@Boshen</code></a> in <a
href="https://redirect.github.com/CodSpeedHQ/codspeed-rust/pull/14">CodSpeedHQ/codspeed-rust#14</a></li>
<li>chore(cargo-codspeed): set verbosity to normal by <a
href="https://github.com/Boshen"><code>@Boshen</code></a> in <a
href="https://redirect.github.com/CodSpeedHQ/codspeed-rust/pull/15">CodSpeedHQ/codspeed-rust#15</a></li>
<li>chore: bump rust toolchain to 1.73 by <a
href="https://github.com/art049"><code>@art049</code></a> in <a
href="https://redirect.github.com/CodSpeedHQ/codspeed-rust/pull/21">CodSpeedHQ/codspeed-rust#21</a></li>
<li>feat(criterion): allow explicit lifetime usage with compat by <a
href="https://github.com/art049"><code>@art049</code></a> in <a
href="https://redirect.github.com/CodSpeedHQ/codspeed-rust/pull/22">CodSpeedHQ/codspeed-rust#22</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Boshen"><code>@Boshen</code></a> made
their first contribution in <a
href="https://redirect.github.com/CodSpeedHQ/codspeed-rust/pull/14">CodSpeedHQ/codspeed-rust#14</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/CodSpeedHQ/codspeed-rust/compare/v2.2.0...v2.3.0">https://github.com/CodSpeedHQ/codspeed-rust/compare/v2.2.0...v2.3.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="518659da83"><code>518659d</code></a>
Release 2.3.0</li>
<li><a
href="dd3763fea9"><code>dd3763f</code></a>
feat(criterion): allow explicit lifetime usage with compat</li>
<li><a
href="1621b664db"><code>1621b66</code></a>
chore(cargo-codspeed): set verbosity to normal</li>
<li><a
href="87506ab5ca"><code>87506ab</code></a>
chore: update readme</li>
<li><a
href="7b43e1eb7c"><code>7b43e1e</code></a>
feat(cargo-codspeed): add --features <code>vendored-openssl</code></li>
<li>See full diff in <a
href="https://github.com/CodSpeedHQ/codspeed-rust/compare/v2.2.0...v2.3.0">compare
view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
