DonIsaac
4f5a7cbf3c
refactor(semantic): mark SemanticTester and SymbolTester as must_use ( #4430 )
2024-07-24 16:58:11 +00:00
DonIsaac
4b274a8e6f
test(semantic): add more test cases for symbol references ( #4429 )
2024-07-24 16:58:09 +00:00
Dunqing
46cf7179a4
chore(semantic): fix incorrect reference id in snapshot ( #4441 )
2024-07-24 12:51:57 +00:00
oxc-bot
aa56eb4d1d
Release crates v0.22.0 ( #4434 )
...
## [0.22.0] - 2024-07-23
- 85a7cea#4329 )
(Dunqing)
- f68b659#4364 ) (Dunqing)
### Features
- d345b84#4309 )
(rzvxa)
- 3c0c709#4357 )
(Jaden Rodriguez)
- 68efcd4#4396 ) (DonIsaac)
- 0deb027#4407 )
(Boshen)
- e33ec18#4412 ) (Boshen)- 6068e6b#4334 ) (DonIsaac)
### Bug Fixes
- aece1df#4368 )
(overlookmotel)
- 44a10c4#4391 ) (Boshen)
- 3d88f20#4374 )
(Boshen)
- e624dff#4350 ) (Boshen)
- ac08de8#4395 ) (DonIsaac)
- 267f7c4#4409 ) (Boshen)
- bc8d4e5#4410 ) (overlookmotel)
- 6ffce86#4366 ) (Dunqing)
- 4cd5df0#4348 ) (underfin)
- f8565ae#4351 ) (Dunqing)- ea33f94#4352 ) (DonIsaac)
### Performance
- 1b51511#4401 ) (Dunqing)
- 40f9356#4367 ) (Dunqing)
- da13d93#4390 ) (overlookmotel)
- e70c67b#4384 )
(overlookmotel)
- 402006f#4383 ) (overlookmotel)
- 7469e01#4361 )
(overlookmotel)
- 7eb2864#4356 )
(overlookmotel)- a207923#4377 ) (DonIsaac)
### Refactor
- 504daed#4431 )
(overlookmotel)
- d213773#4376 )
(overlookmotel)
- abfccbd#4375 )
(overlookmotel)
- 5f1c7ec#4289 )
(rzvxa)
- 58f6ec2#4347 ) (Dunqing)
- 59aea73#4346 )
(Dunqing)
- 7a3e925#4371 ) (rzvxa)
- 0e1ea90#4420 )
(Dunqing)
- 7a75e0f#4349 ) (DonIsaac)
- a2eabe1#4335 ) (DonIsaac)
- 5d77b36#4370 )
(overlookmotel)
- f7b9ada#4369 )
(overlookmotel)
- 729b288#4358 ) (overlookmotel)
- 21d0eee#4336 )
(DonIsaac)
Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
2024-07-24 08:23:27 +08:00
Dunqing
426016d1d6
Revert "Release crates v0.22.0" ( #4418 )
...
Still release failed. Reverts oxc-project/oxc#4417
2024-07-23 15:51:01 +08:00
github-actions[bot]
f76113cd8f
Release crates v0.22.0 ( #4417 )
...
## [0.22.0] - 2024-07-23
- 85a7cea#4329 )
(Dunqing)
- f68b659#4364 ) (Dunqing)
### Features
- d345b84#4309 )
(rzvxa)
- 3c0c709#4357 )
(Jaden Rodriguez)
- 68efcd4#4396 ) (DonIsaac)
- 0deb027#4407 )
(Boshen)
- e33ec18#4412 ) (Boshen)- 6068e6b#4334 ) (DonIsaac)
### Bug Fixes
- aece1df#4368 )
(overlookmotel)
- 44a10c4#4391 ) (Boshen)
- 3d88f20#4374 )
(Boshen)
- e624dff#4350 ) (Boshen)
- ac08de8#4395 ) (DonIsaac)
- 267f7c4#4409 ) (Boshen)
- bc8d4e5#4410 ) (overlookmotel)
- 6ffce86#4366 ) (Dunqing)
- 4cd5df0#4348 ) (underfin)
- f8565ae#4351 ) (Dunqing)- ea33f94#4352 ) (DonIsaac)
### Performance
- 1b51511#4401 ) (Dunqing)
- 40f9356#4367 ) (Dunqing)
- da13d93#4390 ) (overlookmotel)
- e70c67b#4384 )
(overlookmotel)
- 402006f#4383 ) (overlookmotel)
- 7469e01#4361 )
(overlookmotel)
- 7eb2864#4356 )
(overlookmotel)- a207923#4377 ) (DonIsaac)
### Refactor
- d213773#4376 )
(overlookmotel)
- abfccbd#4375 )
(overlookmotel)
- 5f1c7ec#4289 )
(rzvxa)
- 58f6ec2#4347 ) (Dunqing)
- 59aea73#4346 )
(Dunqing)
- 7a3e925#4371 ) (rzvxa)
- 7a75e0f#4349 ) (DonIsaac)
- a2eabe1#4335 ) (DonIsaac)
- 5d77b36#4370 )
(overlookmotel)
- f7b9ada#4369 )
(overlookmotel)
- 729b288#4358 ) (overlookmotel)
- 21d0eee#4336 )
(DonIsaac)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-23 13:24:08 +08:00
Dunqing
c1cf0e6dd9
Revert "Release crates v0.22.0" ( #4415 )
...
Reverts oxc-project/oxc#4414
2024-07-23 09:59:38 +08:00
DonIsaac
ac08de817e
fix(linter/react_perf): allow new objects, array, fns, etc in top scope ( #4395 )
...
Consider the following code:
```tsx
import { FC } from 'react'
import { SvgIcon } from '@mui/material'
const StyledIcon = <SvgIcon sx={{ padding: 1, color: '#ff0000' }} />
// reported violation ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
export const MyComponent: FC = () => {
return (
<div>
{StyledIcon}
{/* ... */}
</div>
)
}
```
This should not be a violation since the JSX is pre-computed and re-used, which
does not break React's `Object.is()` checks.
2024-07-23 01:39:07 +00:00
github-actions[bot]
00c7b7dad4
Release crates v0.22.0 ( #4414 )
...
## [0.22.0] - 2024-07-22
- 85a7cea#4329 )
(Dunqing)
- f68b659#4364 ) (Dunqing)
### Features
- d345b84#4309 )
(rzvxa)
- 3c0c709#4357 )
(Jaden Rodriguez)
- 0deb027#4407 )
(Boshen)
- e33ec18#4412 ) (Boshen)- 6068e6b#4334 ) (DonIsaac)
### Bug Fixes
- aece1df#4368 )
(overlookmotel)
- 44a10c4#4391 ) (Boshen)
- 3d88f20#4374 )
(Boshen)
- e624dff#4350 ) (Boshen)
- 267f7c4#4409 ) (Boshen)
- bc8d4e5#4410 ) (overlookmotel)
- 6ffce86#4366 ) (Dunqing)
- 4cd5df0#4348 ) (underfin)
- f8565ae#4351 ) (Dunqing)- ea33f94#4352 ) (DonIsaac)
### Performance
- 1b51511#4401 ) (Dunqing)
- 40f9356#4367 ) (Dunqing)
- da13d93#4390 ) (overlookmotel)
- e70c67b#4384 )
(overlookmotel)
- 402006f#4383 ) (overlookmotel)
- 7469e01#4361 )
(overlookmotel)
- 7eb2864#4356 )
(overlookmotel)- a207923#4377 ) (DonIsaac)
### Refactor
- d213773#4376 )
(overlookmotel)
- abfccbd#4375 )
(overlookmotel)
- 5f1c7ec#4289 )
(rzvxa)
- 58f6ec2#4347 ) (Dunqing)
- 59aea73#4346 )
(Dunqing)
- 7a3e925#4371 ) (rzvxa)
- 7a75e0f#4349 ) (DonIsaac)
- a2eabe1#4335 ) (DonIsaac)
- 5d77b36#4370 )
(overlookmotel)
- f7b9ada#4369 )
(overlookmotel)
- 729b288#4358 ) (overlookmotel)
- 21d0eee#4336 )
(DonIsaac)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-23 09:38:03 +08:00
Dunqing
85a7cea9d1
refactor(semantic)!: remove name from reference ( #4329 )
...
related to: https://github.com/oxc-project/backlog/issues/32
2024-07-22 15:59:23 +00:00
Dunqing
1b51511bb6
perf(semantic): use Atom instead of CompactStr for UnresolvedReferencesStack ( #4401 )
...
related: #4394
The `UnresolvedReferencesStack` is only used for resolving references, and the `Atom` clone is cheap, So we can safely change `CompactStr`to `Atom`
2024-07-22 12:18:37 +00:00
overlookmotel
bc8d4e5876
fix(semantic): correct comment ( #4410 )
...
Correct a code comment.
2024-07-22 12:14:33 +00:00
overlookmotel
d79b60afc4
example(semantic): examples print parser errors ( #4405 )
...
Examples for `Semantic` print parser errors if parsing fails.
2024-07-22 11:05:03 +00:00
Dunqing
40f93564ac
perf(semantic): calculate number of nodes, scopes, symbols, references before visiting AST ( #4367 )
...
context: #4328
2024-07-22 10:47:54 +00:00
overlookmotel
da13d9338f
perf(semantic): remove bounds checks on unresolved references stack ( #4390 )
...
`SemanticBuilder` keeps a stack of hashmaps to track unresolved references. This stack only grows, never shrinks. Use that invariant to remove bounds checks.
2024-07-21 15:49:52 +00:00
overlookmotel
e70c67b2e2
perf(semantic): remove a branch from add_scope ( #4384 )
...
Similar to #4361 .
`ScopeTree::add_scope` had a branch specifically to handle `Program`. Remove that by inlining the special logic for `Program` into `visit_program`.
Probably won't have much effect on benchmarks as the branch is easy to predict, but still removes a few instructions and makes `add_scope` easier for compiler to inline.
2024-07-21 12:43:34 +00:00
overlookmotel
402006f28d
perf(semantic): simplify logic in enter_scope + leave_scope ( #4383 )
...
`SemanticBuilder::enter_scope` contained multiple checks purely to handle when called for `Program` scope (where scope has no parent). This is a very uncommon case as `Program` is visited only once, but these checks run for every scope.
So don't call `enter_scope` from `visit_program`, and inline the special logic for root scope there instead, to simplify `enter_scope`.
A branch in `leave_scope` also gets more predictable (always taken).
2024-07-21 12:33:24 +00:00
DonIsaac
a207923af1
perf: replace some CompactStr usages with Cows ( #4377 )
...
Reduce memory allocations in semantic and linter by using `Cow<'a, str>` over `CompactStr`
2024-07-20 19:19:55 +00:00
overlookmotel
5d77b36f24
refactor(semantic): visit_program visit hashbang field ( #4370 )
...
The visit was missing previously, though it didn't matter, because semantic doesn't do anything with `Hashbang` anyway. But is needed for #4367 .
2024-07-19 16:32:32 +00:00
overlookmotel
f7b9ada372
refactor(semantic): Program visitor leave scope before node ( #4369 )
...
Bring the order of calls in `SemanticBuilder::visit_program` into line with `Visit`'s `walk_program`.
2024-07-19 16:32:27 +00:00
Dunqing
6ffce865d1
fix(semantic): align visit_arrow_function_expression field visit order with ast ( #4366 )
...
related: #4364
2024-07-19 14:51:59 +00:00
overlookmotel
7469e018b0
perf(semantic): remove branch from Nodes::add_node ( #4361 )
...
`AstNodes::add_node` had a branch specifically to handle `Program`. Remove that by inlining the special logic for `Program` into `visit_program`.
Probably won't have much effect on benchmarks as the branch is easy to predict, but still removes a few instructions and makes `add_node` easier for compiler to inline.
2024-07-19 11:34:03 +00:00
overlookmotel
729b288c5d
refactor(semantic): shorten code ( #4358 )
...
Code style: Remove unnecessary assignments to `_`.
2024-07-19 10:29:27 +00:00
Dunqing
58f6ec21f3
refactor(ast): enter node before scope ( #4347 )
...
close : #4276
2024-07-18 19:18:01 +00:00
Dunqing
f8565ae3cd
fix(transformer/typescript): unexpectedly removed class binding from ExportNamedDeclaration ( #4351 )
...
The original `SymbolFlags` methods were a bit confusing I renamed and re-implemented them.
2024-07-18 16:44:38 +00:00
DonIsaac
21d0eee182
refactor(semantic): use error codes for ts diagnostics ( #4336 )
...
Part of #4333
2024-07-18 16:09:28 +00:00
github-actions[bot]
7d751898b3
Release crates v0.21.0 ( #4344 )
...
## [0.21.0] - 2024-07-18
- d7ab0b8#4226 )
(lucab)
### Features
- af4dc01#4253 ) (Dunqing)
- 83c2c62#4219 ) (Boshen)
- 5d17675#4314 ) (Boshen)
- e3e663b#4197 )
(Boshen)
- c818472#4190 )
(Boshen)
- 8a190eb20cdb1f#4195 ) (Dunqing)
- 92ee774#4205 ) (Dunqing)
- 205c259#4220 )
(underfin)
- 7eb960d#4235 ) (Boshen)
### Bug Fixes
- bf3d8d3#4290 ) (Boshen)
- 084ab76e167ef7#4245 ) (Boshen)
- c65198f#4236 ) (Boshen)
- be82c28#4231 ) (Boshen)
- 3df9e69#4319 ) (Boshen)
- f144082#4268 ) (underfin)
- 66b455a#4230 ) (IWANABETHATGUY)
- 9a87e41#4267 )
(lucab)
- 641a78b#4254 ) (overlookmotel)
- 9badac0#4337 ) (Dunqing)
- 95e15b6#4320 ) (Dunqing)
- c362bf7#4311 ) (Dunqing)
- 351ecf2#4310 ) (Dunqing)
- 1108f2a#4280 )
(Dunqing)
- 22d56bd#4241 ) (overlookmotel)- 1c117eb#4199 ) (IWANABETHATGUY)
### Performance
- a8dc4f3#4259 )
(overlookmotel)
- b94540d#4258 )
(overlookmotel)
- a7b328c#4257 ) (overlookmotel)
- f9d3f2e#4272 ) (overlookmotel)
- 8fad7db#4264 ) (overlookmotel)
- 23743db#4263 ) (overlookmotel)
- da69076#4262 )
(overlookmotel)
- cb15303#4216 ) (overlookmotel)
- ef4c1f4#4214 ) (overlookmotel)
- f23e54f#4213 )
(overlookmotel)
- 2602ce2#4206 )
(lucab)
### Refactor
- 2c7bb9f#4283 )
(overlookmotel)
- 3e099fe#4246 ) (Dunqing)
- aab7aaa#4203 )
(rzvxa)
- d1c4be006197b8aa22073#4196 ) (Boshen)
- c5731a5#4286 )
(overlookmotel)
- 16698bc#4278 ) (overlookmotel)
- ee16668#4277 ) (overlookmotel)
- 25f0771#4275 )
(overlookmotel)
- 639fd48#4274 )
(overlookmotel)
- c418bf5#4265 ) (Dunqing)
- ace4f1f#4248 ) (Dunqing)
- 8bfeabf#4249 )
(Dunqing)
- dc2b3c4#4156 ) (Dunqing)
- 81ed588#4208 ) (lucab)
- bbe5ded#4193 ) (Dunqing)
- 7f1addd#4192 ) (Dunqing)
- fc0b17d#4308 ) (rzvxa)
- a197e01#4321 )
(Dunqing)
- 1458d81#4330 )
(overlookmotel)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-18 14:39:07 +08:00
Dunqing
fc39ffa009
Revert "Release crates v0.21.0" ( #4342 )
...
Reverts oxc-project/oxc#4338
https://github.com/oxc-project/oxc/actions/runs/9986290706/job/27598542089
Release failed
2024-07-18 14:11:42 +08:00
github-actions[bot]
0abcf499b7
Release crates v0.21.0 ( #4338 )
...
## [0.21.0] - 2024-07-18
- d7ab0b8#4226 )
(lucab)
### Features
- af4dc01#4253 ) (Dunqing)
- 83c2c62#4219 ) (Boshen)
- 5d17675#4314 ) (Boshen)
- e3e663b#4197 )
(Boshen)
- c818472#4190 )
(Boshen)
- 8a190eb20cdb1f#4195 ) (Dunqing)
- 92ee774#4205 ) (Dunqing)
- 205c259#4220 )
(underfin)
- 7eb960d#4235 ) (Boshen)
### Bug Fixes
- bf3d8d3#4290 ) (Boshen)
- 084ab76e167ef7#4245 ) (Boshen)
- c65198f#4236 ) (Boshen)
- be82c28#4231 ) (Boshen)
- 3df9e69#4319 ) (Boshen)
- f144082#4268 ) (underfin)
- 66b455a#4230 ) (IWANABETHATGUY)
- 9a87e41#4267 )
(lucab)
- 641a78b#4254 ) (overlookmotel)
- 9badac0#4337 ) (Dunqing)
- 95e15b6#4320 ) (Dunqing)
- c362bf7#4311 ) (Dunqing)
- 351ecf2#4310 ) (Dunqing)
- 1108f2a#4280 )
(Dunqing)
- 22d56bd#4241 ) (overlookmotel)- 1c117eb#4199 ) (IWANABETHATGUY)
### Performance
- a8dc4f3#4259 )
(overlookmotel)
- b94540d#4258 )
(overlookmotel)
- a7b328c#4257 ) (overlookmotel)
- f9d3f2e#4272 ) (overlookmotel)
- 8fad7db#4264 ) (overlookmotel)
- 23743db#4263 ) (overlookmotel)
- da69076#4262 )
(overlookmotel)
- cb15303#4216 ) (overlookmotel)
- ef4c1f4#4214 ) (overlookmotel)
- f23e54f#4213 )
(overlookmotel)
- 2602ce2#4206 )
(lucab)
### Refactor
- 2c7bb9f#4283 )
(overlookmotel)
- 3e099fe#4246 ) (Dunqing)
- aab7aaa#4203 )
(rzvxa)
- d1c4be006197b8aa22073#4196 ) (Boshen)
- c5731a5#4286 )
(overlookmotel)
- 16698bc#4278 ) (overlookmotel)
- ee16668#4277 ) (overlookmotel)
- 25f0771#4275 )
(overlookmotel)
- 639fd48#4274 )
(overlookmotel)
- c418bf5#4265 ) (Dunqing)
- ace4f1f#4248 ) (Dunqing)
- 8bfeabf#4249 )
(Dunqing)
- dc2b3c4#4156 ) (Dunqing)
- 81ed588#4208 ) (lucab)
- bbe5ded#4193 ) (Dunqing)
- 7f1addd#4192 ) (Dunqing)
- fc0b17d#4308 ) (rzvxa)
- a197e01#4321 )
(Dunqing)
- 1458d81#4330 )
(overlookmotel)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-18 13:56:35 +08:00
Dunqing
9badac030d
fix(semantic): avoid var hosting insert the var variable to the CatchClause scope ( #4337 )
...
related: #4192 #4323
I will figure it out #4323 later
2024-07-18 02:52:14 +00:00
Dunqing
95e15b6dc5
fix(semantic): incorrect resolve references for ExportSpecifier ( #4320 )
...
```ts
type A = any;
const B = 0;
export { A, B }
^^^^^^^^ ExportSpecifiers
export { A }
^^^^^ type-only ExportSpecifiers
```
non-type-only `ExportSpecifier` can reference value and type symbols. but currently, `IdentifierReference` in ExportSpecifier only has a `ReferenceFlags::Read`
2024-07-17 09:52:58 +00:00
Dunqing
a88d588a07
feat(semantic): add ReferenceFlags::TSTypeQuery to indicate referenced by TSTypeQuery ( #4317 )
...
`ReferenceFlags::TSTypeQuery` can be used to help us insist on whether the reference is referenced by the type or not.
2024-07-17 09:52:57 +00:00
Dunqing
c362bf7edf
fix(semantic): incorrect resolve references for TSInterfaceHeritage ( #4311 )
...
related issue: https://github.com/oxc-project/oxc/issues/3963
fixes: https://github.com/oxc-project/monitor-oxc/actions/runs/9960183591/job/27518854841
2024-07-17 03:33:02 +00:00
Dunqing
351ecf2707
fix(semantic): incorrect resolve references for TSTypeQuery ( #4310 )
...
```ts
type A = typeof Foo
^^^ Only allow reference to value symbol
```
I have verified the changed snapshot. That's correct
2024-07-17 03:33:00 +00:00
Dunqing
48724a0d44
chore(semantic): copy tests from typescript-eslint’s scope-manager ( #3990 )
...
close: #2947
These fixtures were copied from a5b652da1e/packages/scope-manager/tests/fixtures
2024-07-17 02:50:50 +00:00
Dunqing
1108f2a700
fix(semantic): resolve references to the incorrect symbol ( #4280 )
...
close : #3799
related: #3863
2024-07-17 02:50:48 +00:00
Dunqing
af4dc0112e
feat(ast): align ts ast scope with typescript ( #4253 )
...
close : #3969
close : #2023
We need to add scope according to [this](d8086f14b6/src/compiler/binder.ts (L3883-L3962)
2024-07-17 02:50:47 +00:00
rzvxa
fc0b17d5a0
refactor(syntax): turn the AstNodeId::dummy into a constant field. ( #4308 )
2024-07-16 22:43:21 +00:00
overlookmotel
c5731a5431
refactor(semantic): remove defunct code setting ScopeFlags twice ( #4286 )
...
Scope flags for functions is set when the scope is created. Remove redundant code that sets them again.
2024-07-16 07:32:36 +00:00
overlookmotel
2c7bb9f6c8
refactor(ast): pass final ScopeFlags into visit_function ( #4283 )
...
We have a strange workaround for `visit_function` where we pass in `ScopeFlags`, to support creating the scope inside `Function`, but setting different flags for `MethodDefinition`s.
Previously `visit_function` took `Option<ScopeFlags>` and then did `flags.unwrap_or(ScopeFlags::empty()) | ScopeFlags::Function` to it. Personally, I found this confusing. When I was looking at `MethodDefinition`, I was wondering "It's a function, why doesn't it set Function flag too?"
This changes makes it more explicit and clear what `ScopeFlags` everything has.
2024-07-16 07:22:07 +00:00
overlookmotel
16698bc191
refactor(semantic): move function/class-specific code into specific visitors ( #4278 )
...
Instead of calling `bind_function_or_class_expression` for every scope, and then branching on the AST node kind, insert the relevant code into the visitors for functions and classes. This reduces work on all other kinds of scopes e.g. block statements.
2024-07-15 18:36:20 +00:00
overlookmotel
ee16668168
refactor(semantic): rename function param ( #4277 )
...
Small style nit. It's nicer to have Rust Analyser's param name hint show `builder` rather than `_builder`.
2024-07-15 15:06:59 +00:00
overlookmotel
25f0771185
refactor(semantic): alter syntax of control_flow! macro ( #4275 )
...
Previously:
```rs
let ix = control_flow!(|self, cfg| cfg.current_node_ix);
```
after this PR:
```rs
let ix = control_flow!(self, |cfg| cfg.current_node_ix);
```
It expands to:
```rs
let ix = if let Some(ref mut cfg) = self.cfg {
cfg.current_node_ix
} else {
Default::default()
};
```
So rationale for this change is that it makes it clearer that `self` is passed *in* and `cfg` comes *out* into the "closure".
2024-07-15 14:31:04 +00:00
overlookmotel
639fd48227
refactor(semantic): comment why extra CFG enabled check ( #4274 )
...
Add a comment referencing conclusions of #4273 .
2024-07-15 12:11:04 +00:00
overlookmotel
f9d3f2ef55
perf(semantic): inline ast record functions ( #4272 )
...
Inline these functions so that when CFG is disabled, it doesn't cost a function call just for the trivial `if self.cfg.is_some()` check.
Based on @rzvxa's suggestion in https://github.com/oxc-project/oxc/pull/4263#pullrequestreview-2176762670 .
2024-07-15 11:43:48 +00:00
overlookmotel
23743dbd59
perf(semantic): do not record ast nodes for cfg if cfg disabled ( #4263 )
...
Control flow graph builder records AST node IDs in a temp structure `ast_node_records`. Disable this if CFG is disabled.
2024-07-15 04:31:47 +00:00
overlookmotel
da69076c98
perf(semantic): reduce overhead of cfg recording ast nodes ( #4262 )
...
Control flow graph builder records AST node IDs in a temp structure `ast_nodes_records`. Only the first AST node ID inserted into the `Vec` is ever used, so turn it into just a single value.
Using `AstNodeId::dummy()` as sentinel for "not set" instead of using `Option<AstNodeId>` to reduce size of the records stack. `Option<AstNodeId>` is 16 bytes.
2024-07-15 04:31:43 +00:00
Dunqing
c418bf53ce
refactor(semantic): directly record current_node_id when adding a scope ( #4265 )
...
close : #4234
2024-07-15 03:02:18 +00:00
Dunqing
ace4f1ff77
refactor(semantic): update the order of visit_function and Visit fields in the builder to be consistent ( #4248 )
...
Same as #4195
2024-07-14 11:39:15 +00:00
Dunqing
8bfeabfe6a
refactor(semantic): simplify adding SymbolFlags::Export ( #4249 )
...
```ts
export default class Binding {}
// ^^^^^^^ SymbolFlags::Export
export default function Binding () {}
// ^^^^^^^ SymbolFlags::Export
// No binding, so we should not have SymbolFlags::Export
export default function() {}
export default class {}
```
2024-07-14 11:39:13 +00:00
