Boshen
54cd04aead
feat(minifier): implement dce with var hoisting ( #4160 )
2024-07-10 11:03:21 +00:00
Boshen
44a894a2f9
feat(minifier): implement return statement dce ( #4155 )
...
This isn't complete, I need to figure out `var` hoisting 🙃
2024-07-10 11:03:14 +00:00
lucab
03ad1e32cc
refactor(semantic): tweak comment argument type ( #4157 )
...
Minor followup from https://github.com/oxc-project/oxc/pull/4132 .
2024-07-10 07:19:24 +00:00
DonIsaac
cc586145ab
feat(linter): better schemas for allow/warn/deny ( #4150 )
2024-07-10 02:51:10 +00:00
rzvxa
48947a26d2
fix(ast): put decorators before everything else. ( #4143 )
...
Won't fix #4142
It is similar to #3994 but for those types that weren't relying on this order. It seems to be the right order.
technically speaking it is a breaking change but I know as a fact that it won't have a big difference on our downstream. If you want it to be chronically correct feel free to merge as a breaking change.
2024-07-10 02:03:05 +00:00
Boshen
fca9706ab3
perf(semantic): faster search for leading comments ( #4140 )
...
fixes #4114
@leaysgur This is my wild guess, I need a second pairs of eyes to make
sure this is correct.
2024-07-10 09:54:26 +08:00
rzvxa
bdcc2986f7
docs(ast): update the note regarding the ast_codegen markers. ( #4149 )
2024-07-09 22:52:08 +00:00
Luca Bruno
5731e3957f
refactor(ast)!: store span details inside comment struct ( #4132 )
...
This tweaks `Comment` definition in order to internally store the start
and end position of its span.
Closes: https://github.com/oxc-project/oxc/issues/4069
2024-07-09 23:23:43 +08:00
github-actions[bot]
714bf1dd7f
Release crates v0.19.0 ( #4137 )
...
## [0.19.0] - 2024-07-09
- b936162#4122 ) (rzvxa)
### Features
- 485c871#4124 ) (rzvxa)
### Refactor
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-09 20:32:06 +08:00
rzvxa
485c871e8d
feat(ast): allow conversion from Expression into Statement with FromIn trait. ( #4124 )
...
Our downstream rolldown is using this, If we want them to adopt our traits we should provide this implementation for them.
2cd2a367ee/crates/rolldown_ecmascript/src/allocator_helpers/into_in.rs (L24)
2024-07-09 12:16:40 +00:00
rzvxa
b936162093
refactor(ast/ast_builder)!: shorter allocator utility method names. ( #4122 )
...
This PR serves two purposes, First off it would lower the amount of characters we have to type in for a simple operation such as wrapping an expression in a vector. Secondly, it would follow the generated names more closely since nowhere else in the builder we do have `new_xxx`, We always say `xxx` since a builder always constructs something.
```
new_vec -> vec
new_vec_single -> vec1*
new_vec_from_iter -> vec_from_iter
new_vec_with_capacity -> vec_with_capacity
new_str -> str
new_atom -> atom
```
`*` This one is the main motivation behind this PR, It saves 10 characters!
2024-07-09 12:16:38 +00:00
github-actions[bot]
e29cdbfe40
Release crates v0.18.0 ( #4136 )
...
## [0.18.0] - 2024-07-09
- d347aed#3890 ) (rzvxa)
### Features
- c6c16a5#4135 ) (Boshen)
- 365d9ba#4119 ) (IWANABETHATGUY)
- 3a0f2aa#4126 ) (DonIsaac)
- 2f53bdf#4127 ) (DonIsaac)
- c4ee9f8#4125 ) (Don Isaac)
- 44c7fe3#4090 ) (rzvxa)
### Bug Fixes
- cb1af04#4130 ) (Dunqing)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-09 19:56:10 +08:00
Boshen
c6c16a5fc9
feat(minifier): dce all conditional expressions ( #4135 )
2024-07-09 18:28:33 +08:00
Dunqing
cb1af043b8
fix(isolated-declarations): remove the async and generator keywords from MethodDefinition ( #4130 )
...
close : #4120
2024-07-09 03:58:47 +00:00
DonIsaac
2f53bdf72d
feat(semantic): check for abstract ClassElements in non-abstract classes ( #4127 )
...
feat(semantic): check for abstract ClassElements in non-abstract classes
chore: update coverage snapshots
2024-07-09 03:35:32 +00:00
DonIsaac
c5b4be021e
feat(linter): add fixer for prefer-node-protocol ( #4129 )
2024-07-09 03:13:24 +00:00
DonIsaac
2334515247
fix(linter): panic in get_enclosing_function ( #4121 )
...
Fixes one of the panics described in #4111
2024-07-09 02:59:08 +00:00
DonIsaac
3a0f2aa7ef
feat(parser): check for illegal modifiers in modules and namespaces ( #4126 )
2024-07-09 02:54:06 +00:00
rzvxa
d347aedfda
feat(ast)!: generate ast_builder.rs. ( #3890 )
...
### Every structure has 2 builder methods:
1. `xxx` e.g. `block_statement`
```rust
#[inline]
pub fn block_statement(self, span: Span, body: Vec<'a, Statement<'a>>) -> BlockStatement<'a> {
BlockStatement { span, body, scope_id: Default::default() }
}
```
2. `alloc_xxx` e.g. `alloc_block_statement`
```rust
#[inline]
pub fn alloc_block_statement(
self,
span: Span,
body: Vec<'a, Statement<'a>>,
) -> Box<'a, BlockStatement<'a>> {
self.block_statement(span, body).into_in(self.allocator)
}
```
### We generate 3 types of methods for enums:
1. `yyy_xxx` e.g. `statement_block`
```rust
#[inline]
pub fn statement_block(self, span: Span, body: Vec<'a, Statement<'a>>) -> Statement<'a> {
Statement::BlockStatement(self.alloc(self.block_statement(span, body)))
}
```
2. `yyy_from_xxx` e.g. `statement_from_block`
```rust
#[inline]
pub fn statement_from_block<T>(self, inner: T) -> Statement<'a>
where
T: IntoIn<'a, Box<'a, BlockStatement<'a>>>,
{
Statement::BlockStatement(inner.into_in(self.allocator))
}
```
3. `yyy_xxx` where `xxx` is inherited e.g. `statement_declaration`
```rust
#[inline]
pub fn statement_declaration(self, inner: Declaration<'a>) -> Statement<'a> {
Statement::from(inner)
}
```
------------
### Generic parameters:
We no longer accept `Box<'a, ADT>`, `Atom` or `&'a str`, Instead we use `IntoIn<'a, Box<'a, ADT>>`, `IntoIn<'a, Atom<'a>>` and `IntoIn<'a, &'a str>` respectively.
It allows us to rewrite things like this:
```rust
let ident = IdentifierReference::new(SPAN, Atom::from("require"));
let number_literal_expr = self.ast.expression_numeric_literal(
right_expr.span(),
num,
raw,
self.ast.new_str(num.to_string().as_str()),
NumberBase::Decimal,
);
```
As this:
```rust
let ident = IdentifierReference::new(SPAN, "require");
let number_literal_expr = self.ast.expression_numeric_literal(
right_expr.span(),
num,
raw,
num.to_string(),
NumberBase::Decimal,
);
```
2024-07-09 00:57:26 +00:00
Don Isaac
1b91d40da2
fix(linter): incorrect fixer for no-unused-labels ( #4123 )
2024-07-08 17:58:59 -04:00
Don Isaac
c4ee9f8ec6
feat(semantic): check for abstract initializations and implementations ( #4125 )
2024-07-08 17:30:16 -04:00
IWANABETHATGUY
365d9ba252
feat(oxc_codegen): generate annotation comments before CallExpression and NewExpression ( #4119 )
...
1. test case copy from `vue/core`, here are all usages of `#__PURE__` in
`vue/core`
https://gist.github.com/IWANABETHATGUY/c7911ecd98467a2969b2a994a34d32bc#file-pure_annotation_in_vue_repo-sh
2. Also took a look in other codebase,
https://github.com/search?q=%23__PURE__&type=code , most of the usage of
`#__PURE__` attached as leading comment before `CallExpression` and
`NewExpression`
2024-07-09 00:22:28 +08:00
rzvxa
44c7fe39ee
feat(span): add various implementations of FromIn for Atom. ( #4090 )
2024-07-08 15:32:57 +00:00
github-actions[bot]
c3f08ce8e0
Release crates v0.17.2 ( #4115 )
...
## [0.17.2] - 2024-07-08
### Features
- 115ac3b#4088 )
(rzvxa)
- 720983a#4113 ) (Boshen)
- e386b62#4097 )
(DonIsaac)
### Bug Fixes
- 5472b7c5c31236#4106 ) (Dunqing)
- e67c7d1#4105 ) (Dunqing)
- 3fcad5e#4077 ) (michaelm)
- f8d77e4#4068 ) (michaelm)
- 0f02608#4100 ) (Don
Isaac)
- 4413e2d#4103 ) (Don Isaac)
### Performance
- 7ed27b7#4074 ) (Dunqing)
- 9114c8e#4107 )
(Luca Bruno)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-08 19:16:33 +08:00
Jelle van der Waa
2687ebc1c5
refactor(react): use find_binding helper for finding React binding ( #4108 )
...
Discovered `find_binding()` when hacking on
https://github.com/oxc-project/oxc/pull/4087 seemed like a nice
refactor.
2024-07-08 18:35:48 +08:00
Jelle van der Waa
ed4c54c0de
fix(eslint/radix): detect yield Number.parseInt variant ( #4110 )
...
The eslint rule perfer-numeric-literals has a test for the yield variant
which the radix testsuite did not have. See
https://github.com/oxc-project/oxc/pull/4109
2024-07-08 18:33:18 +08:00
Luca Bruno
9114c8e01c
perf(semantic): keep a single map of unresolved references ( #4107 )
...
This reworks `ScopeTree` in order to keep a single (root) map of
unresolved references. The `SemanticBuilder` keeps track of all
intermediate ones while walking scopes, and it can get rid of all
non-root ones once done.
Ref: https://github.com/oxc-project/backlog/issues/32
2024-07-08 16:56:13 +08:00
rzvxa
115ac3b81b
feat(allocator): introduce FromIn and IntoIn traits. ( #4088 )
2024-07-08 07:07:17 +00:00
Dunqing
5c31236d4b
fix(isolated-declarations): keep literal value for readonly property ( #4106 )
...
close : #4036
2024-07-08 06:51:33 +00:00
Dunqing
e67c7d1b01
fix(isolated-declarations): do not infer type for private parameters ( #4105 )
...
close : #4033
2024-07-08 06:51:28 +00:00
Don Isaac
0f026089d1
fix(semantic): bind TSImportEqualsDeclarations ( #4100 )
...
Closes #4091
2024-07-08 14:03:47 +08:00
Don Isaac
4413e2d298
fix(transformer): missing initializer for readonly consructor properties ( #4103 )
2024-07-08 12:45:50 +08:00
DonIsaac
e386b62331
feat(semantic): check for invalid type import assignments ( #4097 )
...
Adds checks to `TSImportEqualsDeclaration` for invalid use of `import type` modifier.
```ts
import { Foo } from './foo'
namespace Bar {
export class Baz {}
}
import type A = Foo.Baz; // not allowed
import type B = Bar.Baz; // not allowed
import type C = require('./c'); // allowed
```
2024-07-08 03:14:22 +00:00
michaelm
3fcad5e16f
fix(isolated_declarations): Remove nested AssignmentPatterns from inside parameters ( #4077 )
...
The default values in destructured parameters are retained in
declarations, which can cause captured variables to be part of the emit
when they shouldn't be. This can also lead to unnecessary isolated
declaration errors when those variables are themselves missing type
annotations and can't be inferred.
For example:
```ts
const x = 42;
const y = '';
export function fooGood3({a = x, b: [{c = y}]}: object): void {}
```
before this change will be emitted as:
```ts
declare const x = 42;
declare const y = '';
export declare function fooGood3({ a = x, b: [{ c = y }] }: object): void;
```
and after this change will be emitted as:
```ts
export declare function fooGood3({ a, b: [{ c }] }: object): void;
```
Co-authored-by: MichaelMitchell-at <=>
2024-07-08 11:06:26 +08:00
DonIsaac
17292491b4
fix(linter): incorrect fix in no-single-promise-in-promise-methods rule; ( #4094 )
...
Closes #4093
2024-07-08 02:34:19 +00:00
michaelm
f8d77e4d7a
fix(isolated_declarations): Infer type of template literal expressions as string ( #4068 )
...
In a "non-`const`" context, a template literal string can just be
inferred a `string`. This is consistent with TypeScript's behavior.
Co-authored-by: MichaelMitchell-at <=>
2024-07-08 00:41:33 +08:00
Boshen
5472b7c990
fix(codegen): 256 indentations level is not enough for codegen
2024-07-08 00:25:37 +08:00
Dunqing
7ed27b75f9
perf(isolated-declarations): use FxHashSet instead of Vec to speed up the contain ( #4074 )
2024-07-08 00:16:25 +08:00
github-actions[bot]
0c7f3eecc6
Release oxlint v0.5.3 ( #4082 )
...
## [0.5.3] - 2024-07-07
### Features
- 1681b11#4053 )
(cinchen)
- 6876490#4041 ) (jordan boyer)
- bf04dee#4034 ) (Nissim Chekroun)
- aa45604#4038 ) (Jelle van der
Waa)
### Bug Fixes
- 7b2dc3b#4080 ) (Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-07 19:31:03 +08:00
Boshen
0ec12cf38d
chore(linter): change no-negation-in-equality-check to pedantic
2024-07-07 19:19:09 +08:00
Boshen
7b2dc3b92b
fix(linter): fix panic in import/namespace ( #4080 )
2024-07-07 11:04:20 +00:00
github-actions[bot]
51d56d37ff
Release crates v0.17.1 ( #4075 )
...
## [0.17.1] - 2024-07-06
### Bug Fixes
- aa585d3#4061 ) (rzvxa)
- 564a75a#4063 ) (michaelm)
- adee728#4065 )
(michaelm)
- 1b8f208#4064 ) (michaelm)
- 719fb96#4073 ) (Boshen)
- 150f4d97fe2a2f#4067 ) (overlookmotel)
### Refactor
- 8fa98e0#4066 )
(overlookmotel)
- 65aee19#4070 ) (Luca
Bruno)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-07 01:29:52 +08:00
Boshen
719fb9672b
fix(minifier): omit dce undefined which can be a shadowed variable ( #4073 )
...
```
// Shadowed `undefined` as a variable should not be erased.
test(
"function foo(undefined) { if (!undefined) { } }",
"function foo(undefined){if(!undefined){}}",
);
```
I'm not using the cheap `ident.reference_id.get().is_some()` here yet
because I don't know what I'm doing - how should minifier consume
`Semantic`?
2024-07-07 01:25:54 +08:00
michaelm
adee7280d7
fix(isolated_declarations): Don't report an error for parameters if they are ObjectPattern or ArrayPattern with an explicit type ( #4065 )
...
The logic in https://github.com/oxc-project/oxc/pull/3810 was slightly
off as demonstrated by the snapshot test.
Co-authored-by: MichaelMitchell-at <=>
2024-07-06 22:58:07 +08:00
Luca Bruno
65aee19098
refactor(isolated-declarations): reorganize scope tree ( #4070 )
...
This reorganizes scope fields into levels which atomically follow the
enter/leave pattern. It avoids tracking the same lenght and capacity
separately for each property, and does not need to grow multiple vectors
while traversing.
2024-07-06 22:53:00 +08:00
Jelle van der Waa
aa45604bd3
feat(linter/eslint): Implement no-multi-str ( #4038 )
...
Rule Detail:
[link](https://eslint.org/docs/latest/rules/no-multi-str )
---------
Co-authored-by: wenzhe <mysteryven@gmail.com>
2024-07-06 22:12:10 +08:00
overlookmotel
7fe2a2f681
perf(parser): do not copy comments ( #4067 )
...
Follow-on from #4045 . `.from_iter()` copies the `Vec` of comments into another `Vec` before converting to a boxed slice. This copy is unnecessary - just convert direct.
2024-07-06 09:56:41 +00:00
overlookmotel
8fa98e03ae
refactor(ast): inline trivial functions and shorten code ( #4066 )
...
Follow on from #4045 . Mark trivial functions related to `Trivias` as `#[inline]` and remove a couple of unnecessary `matches!` macro calls.
2024-07-06 09:56:36 +00:00
michaelm
564a75ab37
fix(codegen): missing TypeParameters in TSConstructSignature ( #4063 )
2024-07-06 13:59:49 +08:00
michaelm
1b8f208572
fix(isolated_declarations): correct emit for private static methods ( #4064 )
2024-07-06 12:30:13 +08:00
