DonIsaac
3a0f2aa7ef
feat(parser): check for illegal modifiers in modules and namespaces ( #4126 )
2024-07-09 02:54:06 +00:00
rzvxa
d347aedfda
feat(ast)!: generate ast_builder.rs. ( #3890 )
...
### Every structure has 2 builder methods:
1. `xxx` e.g. `block_statement`
```rust
#[inline]
pub fn block_statement(self, span: Span, body: Vec<'a, Statement<'a>>) -> BlockStatement<'a> {
BlockStatement { span, body, scope_id: Default::default() }
}
```
2. `alloc_xxx` e.g. `alloc_block_statement`
```rust
#[inline]
pub fn alloc_block_statement(
self,
span: Span,
body: Vec<'a, Statement<'a>>,
) -> Box<'a, BlockStatement<'a>> {
self.block_statement(span, body).into_in(self.allocator)
}
```
### We generate 3 types of methods for enums:
1. `yyy_xxx` e.g. `statement_block`
```rust
#[inline]
pub fn statement_block(self, span: Span, body: Vec<'a, Statement<'a>>) -> Statement<'a> {
Statement::BlockStatement(self.alloc(self.block_statement(span, body)))
}
```
2. `yyy_from_xxx` e.g. `statement_from_block`
```rust
#[inline]
pub fn statement_from_block<T>(self, inner: T) -> Statement<'a>
where
T: IntoIn<'a, Box<'a, BlockStatement<'a>>>,
{
Statement::BlockStatement(inner.into_in(self.allocator))
}
```
3. `yyy_xxx` where `xxx` is inherited e.g. `statement_declaration`
```rust
#[inline]
pub fn statement_declaration(self, inner: Declaration<'a>) -> Statement<'a> {
Statement::from(inner)
}
```
------------
### Generic parameters:
We no longer accept `Box<'a, ADT>`, `Atom` or `&'a str`, Instead we use `IntoIn<'a, Box<'a, ADT>>`, `IntoIn<'a, Atom<'a>>` and `IntoIn<'a, &'a str>` respectively.
It allows us to rewrite things like this:
```rust
let ident = IdentifierReference::new(SPAN, Atom::from("require"));
let number_literal_expr = self.ast.expression_numeric_literal(
right_expr.span(),
num,
raw,
self.ast.new_str(num.to_string().as_str()),
NumberBase::Decimal,
);
```
As this:
```rust
let ident = IdentifierReference::new(SPAN, "require");
let number_literal_expr = self.ast.expression_numeric_literal(
right_expr.span(),
num,
raw,
num.to_string(),
NumberBase::Decimal,
);
```
2024-07-09 00:57:26 +00:00
Don Isaac
1b91d40da2
fix(linter): incorrect fixer for no-unused-labels ( #4123 )
2024-07-08 17:58:59 -04:00
Don Isaac
c4ee9f8ec6
feat(semantic): check for abstract initializations and implementations ( #4125 )
2024-07-08 17:30:16 -04:00
IWANABETHATGUY
365d9ba252
feat(oxc_codegen): generate annotation comments before CallExpression and NewExpression ( #4119 )
...
1. test case copy from `vue/core`, here are all usages of `#__PURE__` in
`vue/core`
https://gist.github.com/IWANABETHATGUY/c7911ecd98467a2969b2a994a34d32bc#file-pure_annotation_in_vue_repo-sh
2. Also took a look in other codebase,
https://github.com/search?q=%23__PURE__&type=code , most of the usage of
`#__PURE__` attached as leading comment before `CallExpression` and
`NewExpression`
2024-07-09 00:22:28 +08:00
rzvxa
44c7fe39ee
feat(span): add various implementations of FromIn for Atom. ( #4090 )
2024-07-08 15:32:57 +00:00
github-actions[bot]
c3f08ce8e0
Release crates v0.17.2 ( #4115 )
...
## [0.17.2] - 2024-07-08
### Features
- 115ac3b#4088 )
(rzvxa)
- 720983a#4113 ) (Boshen)
- e386b62#4097 )
(DonIsaac)
### Bug Fixes
- 5472b7c5c31236#4106 ) (Dunqing)
- e67c7d1#4105 ) (Dunqing)
- 3fcad5e#4077 ) (michaelm)
- f8d77e4#4068 ) (michaelm)
- 0f02608#4100 ) (Don
Isaac)
- 4413e2d#4103 ) (Don Isaac)
### Performance
- 7ed27b7#4074 ) (Dunqing)
- 9114c8e#4107 )
(Luca Bruno)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-08 19:16:33 +08:00
Jelle van der Waa
2687ebc1c5
refactor(react): use find_binding helper for finding React binding ( #4108 )
...
Discovered `find_binding()` when hacking on
https://github.com/oxc-project/oxc/pull/4087 seemed like a nice
refactor.
2024-07-08 18:35:48 +08:00
Jelle van der Waa
ed4c54c0de
fix(eslint/radix): detect yield Number.parseInt variant ( #4110 )
...
The eslint rule perfer-numeric-literals has a test for the yield variant
which the radix testsuite did not have. See
https://github.com/oxc-project/oxc/pull/4109
2024-07-08 18:33:18 +08:00
Luca Bruno
9114c8e01c
perf(semantic): keep a single map of unresolved references ( #4107 )
...
This reworks `ScopeTree` in order to keep a single (root) map of
unresolved references. The `SemanticBuilder` keeps track of all
intermediate ones while walking scopes, and it can get rid of all
non-root ones once done.
Ref: https://github.com/oxc-project/backlog/issues/32
2024-07-08 16:56:13 +08:00
rzvxa
115ac3b81b
feat(allocator): introduce FromIn and IntoIn traits. ( #4088 )
2024-07-08 07:07:17 +00:00
Dunqing
5c31236d4b
fix(isolated-declarations): keep literal value for readonly property ( #4106 )
...
close : #4036
2024-07-08 06:51:33 +00:00
Dunqing
e67c7d1b01
fix(isolated-declarations): do not infer type for private parameters ( #4105 )
...
close : #4033
2024-07-08 06:51:28 +00:00
Don Isaac
0f026089d1
fix(semantic): bind TSImportEqualsDeclarations ( #4100 )
...
Closes #4091
2024-07-08 14:03:47 +08:00
Don Isaac
4413e2d298
fix(transformer): missing initializer for readonly consructor properties ( #4103 )
2024-07-08 12:45:50 +08:00
DonIsaac
e386b62331
feat(semantic): check for invalid type import assignments ( #4097 )
...
Adds checks to `TSImportEqualsDeclaration` for invalid use of `import type` modifier.
```ts
import { Foo } from './foo'
namespace Bar {
export class Baz {}
}
import type A = Foo.Baz; // not allowed
import type B = Bar.Baz; // not allowed
import type C = require('./c'); // allowed
```
2024-07-08 03:14:22 +00:00
michaelm
3fcad5e16f
fix(isolated_declarations): Remove nested AssignmentPatterns from inside parameters ( #4077 )
...
The default values in destructured parameters are retained in
declarations, which can cause captured variables to be part of the emit
when they shouldn't be. This can also lead to unnecessary isolated
declaration errors when those variables are themselves missing type
annotations and can't be inferred.
For example:
```ts
const x = 42;
const y = '';
export function fooGood3({a = x, b: [{c = y}]}: object): void {}
```
before this change will be emitted as:
```ts
declare const x = 42;
declare const y = '';
export declare function fooGood3({ a = x, b: [{ c = y }] }: object): void;
```
and after this change will be emitted as:
```ts
export declare function fooGood3({ a, b: [{ c }] }: object): void;
```
Co-authored-by: MichaelMitchell-at <=>
2024-07-08 11:06:26 +08:00
DonIsaac
17292491b4
fix(linter): incorrect fix in no-single-promise-in-promise-methods rule; ( #4094 )
...
Closes #4093
2024-07-08 02:34:19 +00:00
michaelm
f8d77e4d7a
fix(isolated_declarations): Infer type of template literal expressions as string ( #4068 )
...
In a "non-`const`" context, a template literal string can just be
inferred a `string`. This is consistent with TypeScript's behavior.
Co-authored-by: MichaelMitchell-at <=>
2024-07-08 00:41:33 +08:00
Boshen
5472b7c990
fix(codegen): 256 indentations level is not enough for codegen
2024-07-08 00:25:37 +08:00
Dunqing
7ed27b75f9
perf(isolated-declarations): use FxHashSet instead of Vec to speed up the contain ( #4074 )
2024-07-08 00:16:25 +08:00
github-actions[bot]
0c7f3eecc6
Release oxlint v0.5.3 ( #4082 )
...
## [0.5.3] - 2024-07-07
### Features
- 1681b11#4053 )
(cinchen)
- 6876490#4041 ) (jordan boyer)
- bf04dee#4034 ) (Nissim Chekroun)
- aa45604#4038 ) (Jelle van der
Waa)
### Bug Fixes
- 7b2dc3b#4080 ) (Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-07 19:31:03 +08:00
Boshen
0ec12cf38d
chore(linter): change no-negation-in-equality-check to pedantic
2024-07-07 19:19:09 +08:00
Boshen
7b2dc3b92b
fix(linter): fix panic in import/namespace ( #4080 )
2024-07-07 11:04:20 +00:00
github-actions[bot]
51d56d37ff
Release crates v0.17.1 ( #4075 )
...
## [0.17.1] - 2024-07-06
### Bug Fixes
- aa585d3#4061 ) (rzvxa)
- 564a75a#4063 ) (michaelm)
- adee728#4065 )
(michaelm)
- 1b8f208#4064 ) (michaelm)
- 719fb96#4073 ) (Boshen)
- 150f4d97fe2a2f#4067 ) (overlookmotel)
### Refactor
- 8fa98e0#4066 )
(overlookmotel)
- 65aee19#4070 ) (Luca
Bruno)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-07 01:29:52 +08:00
Boshen
719fb9672b
fix(minifier): omit dce undefined which can be a shadowed variable ( #4073 )
...
```
// Shadowed `undefined` as a variable should not be erased.
test(
"function foo(undefined) { if (!undefined) { } }",
"function foo(undefined){if(!undefined){}}",
);
```
I'm not using the cheap `ident.reference_id.get().is_some()` here yet
because I don't know what I'm doing - how should minifier consume
`Semantic`?
2024-07-07 01:25:54 +08:00
michaelm
adee7280d7
fix(isolated_declarations): Don't report an error for parameters if they are ObjectPattern or ArrayPattern with an explicit type ( #4065 )
...
The logic in https://github.com/oxc-project/oxc/pull/3810 was slightly
off as demonstrated by the snapshot test.
Co-authored-by: MichaelMitchell-at <=>
2024-07-06 22:58:07 +08:00
Luca Bruno
65aee19098
refactor(isolated-declarations): reorganize scope tree ( #4070 )
...
This reorganizes scope fields into levels which atomically follow the
enter/leave pattern. It avoids tracking the same lenght and capacity
separately for each property, and does not need to grow multiple vectors
while traversing.
2024-07-06 22:53:00 +08:00
Jelle van der Waa
aa45604bd3
feat(linter/eslint): Implement no-multi-str ( #4038 )
...
Rule Detail:
[link](https://eslint.org/docs/latest/rules/no-multi-str )
---------
Co-authored-by: wenzhe <mysteryven@gmail.com>
2024-07-06 22:12:10 +08:00
overlookmotel
7fe2a2f681
perf(parser): do not copy comments ( #4067 )
...
Follow-on from #4045 . `.from_iter()` copies the `Vec` of comments into another `Vec` before converting to a boxed slice. This copy is unnecessary - just convert direct.
2024-07-06 09:56:41 +00:00
overlookmotel
8fa98e03ae
refactor(ast): inline trivial functions and shorten code ( #4066 )
...
Follow on from #4045 . Mark trivial functions related to `Trivias` as `#[inline]` and remove a couple of unnecessary `matches!` macro calls.
2024-07-06 09:56:36 +00:00
michaelm
564a75ab37
fix(codegen): missing TypeParameters in TSConstructSignature ( #4063 )
2024-07-06 13:59:49 +08:00
michaelm
1b8f208572
fix(isolated_declarations): correct emit for private static methods ( #4064 )
2024-07-06 12:30:13 +08:00
cinchen
1681b11adb
feat(linter): eslint-plugin-jest/consistent-test-it ( #4053 )
...
part of https://github.com/oxc-project/oxc/issues/492
Rule Detail:
[link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/consistent-test-it.ts )
2024-07-06 11:03:14 +08:00
rzvxa
aa585d31e1
fix(ast_codegen, ast): visit ExpressionArrayElement as Expression. ( #4061 )
...
hotfix for #4060
I just added an edge case, We can come back to it later on and make it a
standard in our codegen.
The diff is big because it causes the code to reorder, The edge case
generated code doesn't follow the order in which they are defined in the
source of truth(eg `js.rs`)
2024-07-06 00:29:36 +08:00
Boshen
74aae108da
chore(minifier): add dce example
2024-07-05 16:23:51 +08:00
github-actions[bot]
224f5ef2cc
Release crates v0.17.0 ( #4059 )
...
## [0.17.0] - 2024-07-05
- e32b4bc#4045 ) (Luca Bruno)
- 1df6ac0#4000 ) (rzvxa)
- 4a0eaa0#3998 ) (rzvxa)
- c98d8aa#3995 ) (rzvxa)
### Features
- 1854a52#4012 ) (rzvxa)
- 7538af1#3954 ) (rzvxa)
- 7768d23#4035 )
(Egor Blinov)
- 0da9dfb#4058 )
(Boshen)
### Bug Fixes
- aaac2d8#4055 ) (Boshen)
- 5e5b1b1#4042 ) (Egor Blinov)
- 7844734#4022 )
(Dunqing)
- 6254a41#4021 )
(Dunqing)
- 3d29e9c#4043 ) (Dunqing)
- 02ea19a#4026 ) (Dunqing)
- 7c915f4#4025 ) (Dunqing)
- 05a047c#4024 ) (Dunqing)
- c043bec#4037 ) (Egor Blinov)
- b007553#4030 ) (Egor Blinov)
- da62839#4027 ) (Egor Blinov)
### Refactor
- b51f75b#4008 ) (rzvxa)
- edb557c#4057 )
(Boshen)
- 243c9f3#4028 ) (Boshen)
- 1dacb1f#4014 ) (Boshen)
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-05 15:46:50 +08:00
Boshen
0da9dfbf09
feat(minifier): add constant folding to remove dead code ( #4058 )
2024-07-05 15:44:01 +08:00
Boshen
edb557c02b
refactor(minifier): add a folder struct for constant folding ( #4057 )
2024-07-05 15:11:08 +08:00
Boshen
aaac2d8775
fix(codegen): preserve parentheses from AST instead calculating from operator precedence ( #4055 )
...
…operator precedence
Calculating from operator precedence is currently unsafe and will result
incorrect semantics.
2024-07-05 14:01:17 +08:00
jordan boyer
6876490baa
feat(linter): add rule no-undefined ( #4041 )
...
Implementing rule https://eslint.org/docs/latest/rules/no-undefined
This is my first time contributing here, I wanted to started with a
simple rule before contributing more.
related to #479
2024-07-04 23:50:46 -04:00
Nissim Chekroun
bf04dee861
feat(linter): implement unicorn/no-negation-in-equality-check ( #4034 )
...
Fixes https://github.com/oxc-project/oxc/issues/3869
Hey there, thought I'd give this a try as it's tagged "good first issue"
:) Let me know if there's anything that needs to change, I wasn't sure
about the rule category so left as TODO.
2024-07-04 23:05:47 +08:00
Luca Bruno
e32b4bc57c
refactor(ast)!: store trivia comments in a sorted slice ( #4045 )
...
This gets rid of `TriviasMap`, introducing `SortedComments` in order to
store trivia comments in a sorted slice.
Closes: https://github.com/oxc-project/backlog/issues/38
2024-07-04 01:57:36 +08:00
Dunqing
3d29e9cb75
fix(isolated-declarations): eliminate imports incorrectly when they are used in TSInferType ( #4043 )
...
close : #4018
2024-07-03 15:32:27 +00:00
Egor Blinov
5e5b1b14a1
fix(codegen): correct accessibility emit for class formal-parameters/methods/properties ( #4042 )
2024-07-03 17:27:41 +08:00
Egor Blinov
7768d233c6
feat(isolated-declarations): support optional class methods ( #4035 )
...
Example class
```
export class A {
m1?(): void;
m2(): void {}
}
```
Before the fix:
```
export declare class A {
m1(): void;
}
```
with the fix:
```
export declare class A {
m1?(): void;
m2(): void;
}
```
2024-07-03 09:46:59 +08:00
Egor Blinov
c043bec674
fix(isolated_declarations): add mapped-type constraint to the scope ( #4037 )
...
Fixes https://github.com/oxc-project/oxc/issues/4020
Example:
```ts
import {K} from 'foo'
import {T} from 'bar'
export interface I {
prop: {[key in K]: T}
}
```
Before:
```ts
import {T} from 'bar'
export interface I {
prop: {[key in K]: T}
}
```
After:
```ts
import {K} from 'foo'
import {T} from 'bar'
export interface I {
prop: {[key in K]: T}
}
```
TSC:
```ts
import { K } from 'foo';
import { T } from 'bar';
export interface I {
prop: {
[key in K]: T;
};
}
```
2024-07-03 09:45:03 +08:00
Egor Blinov
b007553ebe
fix(isolated_declarations): Fix readonly specifier on class constructor params ( #4030 )
2024-07-02 23:26:19 +08:00
Egor Blinov
da628399fa
fix(isolated_declarations): inferring literal types for readonly class fileds ( #4027 )
2024-07-02 23:00:37 +08:00
github-actions[bot]
b66ad0b675
Release oxlint v0.6.0 ( #4029 )
...
## [0.6.0] - 2024-07-02
- c98d8aa#3995 ) (rzvxa)
### Features
- dc6d45e#3979 ) (Boshen)
- b257d53#3895 ) (mysteryven)
- 2114475#3971 )
(kaykdm)
- 10a3c9a#3975 )
(Jelle van der Waa)
### Bug Fixes
- 432d6d9#4010 ) (rzvxa)
- dbbb6fc#3973 ) (Boshen)
### Performance
- 1eac3d2#3972 ) (Don Isaac)
### Refactor
Co-authored-by: Boshen <Boshen@users.noreply.github.com>
2024-07-02 22:07:52 +08:00
