dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-21 21:29:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(diagnostics): improve "file is too long to fit on the screen" (#5120)

Browse source 
closes #4322

Setting the threshold to 1200 because graphical output may contain ansi escape codes and other decorations.
This commit is contained in:
Boshen 2024-08-23 11:17:12 +00:00
parent 76c66b4326
commit ff7fa987db
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
crates/oxc_diagnostics/src/service.rs
View file

@ -150,8 +150,9 @@ impl DiagnosticService {
} }
if let Some(mut err_str) = self.reporter.render_error(diagnostic) { if let Some(mut err_str) = self.reporter.render_error(diagnostic) {
// Skip large output and print only once // Skip large output and print only once.
if err_str.lines().any(|line| line.len() >= 400) { // Setting to 1200 because graphical output may contain ansi escape codes and other decorations.
if err_str.lines().any(|line| line.len() >= 1200) {
let minified_diagnostic = Error::new( let minified_diagnostic = Error::new(
OxcDiagnostic::warn("File is too long to fit on the screen") OxcDiagnostic::warn("File is too long to fit on the screen")
.with_help(format!("{path:?} seems like a minified file")), .with_help(format!("{path:?} seems like a minified file")),