dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(transformer): arrow function transform more efficient scope search (#5842)

Browse source 
Micro-optimization. Match scopes with a single comparison, instead of 2.
This commit is contained in:
overlookmotel 2024-09-18 02:23:36 +00:00
parent 03e02a0eac
commit fd70c4b885
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
crates/oxc_transformer/src/es2015/arrow_functions.rs
View file

@ -252,16 +252,20 @@ impl<'a> ArrowFunctions<'a> {
// <https://github.com/oxc-project/oxc/pull/5840>
let this_var = self.this_var_stack.last_mut().unwrap();
if this_var.is_none() {
let target_scope_id =
ctx.scopes().ancestors(ctx.current_scope_id()).skip(1).find(|&scope_id| {
let target_scope_id = ctx
.scopes()
.ancestors(ctx.current_scope_id())
.skip(1)
.find(|&scope_id| {
let scope_flags = ctx.scopes().get_flags(scope_id);
scope_flags.intersects(ScopeFlags::Function | ScopeFlags::Top)
&& !scope_flags.contains(ScopeFlags::Arrow)
});
// Function but not arrow function
scope_flags & (ScopeFlags::Function | ScopeFlags::Arrow) == ScopeFlags::Function
})
.unwrap_or(ctx.scopes().root_scope_id());
this_var.replace(BoundIdentifier::new_uid(
"this",
target_scope_id.unwrap(),
target_scope_id,
SymbolFlags::FunctionScopedVariable,
ctx,
));