dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): disable rule react/rules-of-hook by file extension (#8168)

Browse source
This commit is contained in:
Alexander S. 2024-12-28 19:52:10 +01:00 committed by GitHub
parent d8d2ec6257
commit faf7464733
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crates/oxc_linter/src/rules/react/rules_of_hooks.rs
View file

@ -16,7 +16,7 @@ use crate::{
context::LintContext,
rule::Rule,
utils::{is_react_component_or_hook_name, is_react_function_call, is_react_hook},
AstNode, FrameworkFlags,
AstNode,
};
mod diagnostics {
@ -110,8 +110,9 @@ declare_oxc_lint!(
impl Rule for RulesOfHooks {
fn should_run(&self, ctx: &crate::rules::ContextHost) -> bool {
// disable this rule in vue/nuxt and svelte(kit) files
// top level useFunction are very common
!ctx.frameworks().contains(FrameworkFlags::SvelteKit | FrameworkFlags::Nuxt)
// react hook can be build in only `.ts` files,
// but `useX` functions are popular and can be false positive in other frameworks
!ctx.file_path().extension().is_some_and(|ext| ext == "vue" || ext == "svelte")
}
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {