dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 20:28:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(linter): use CompactStr in no-bitwise (#6398)

Browse source
This commit is contained in:
camchenry 2024-10-10 00:34:48 +00:00
parent 84aa2a237c
commit f5f00a1b0e
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
crates/oxc_linter/src/rules/eslint/no_bitwise.rs
View file

@ -1,7 +1,7 @@
use oxc_ast::AstKind; use oxc_ast::AstKind;
use oxc_diagnostics::OxcDiagnostic; use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint; use oxc_macros::declare_oxc_lint;
use oxc_span::Span; use oxc_span::{CompactStr, Span};
use oxc_syntax::operator::BinaryOperator; use oxc_syntax::operator::BinaryOperator;
use crate::{context::LintContext, rule::Rule, AstNode}; use crate::{context::LintContext, rule::Rule, AstNode};
@ -17,7 +17,7 @@ pub struct NoBitwise(Box<NoBitwiseConfig>);
#[derive(Debug, Default, Clone)] #[derive(Debug, Default, Clone)]
pub struct NoBitwiseConfig { pub struct NoBitwiseConfig {
allow: Vec<String>, allow: Vec<CompactStr>,
int32_hint: bool, int32_hint: bool,
} }
@ -57,10 +57,7 @@ impl Rule for NoBitwise {
.and_then(|v| v.get("allow")) .and_then(|v| v.get("allow"))
.and_then(serde_json::Value::as_array) .and_then(serde_json::Value::as_array)
.map(|v| { .map(|v| {
v.iter() v.iter().filter_map(serde_json::Value::as_str).map(CompactStr::from).collect()
.filter_map(serde_json::Value::as_str)
.map(ToString::to_string)
.collect()
}) })
.unwrap_or_default(), .unwrap_or_default(),
int32_hint: obj int32_hint: obj
@ -107,7 +104,7 @@ impl Rule for NoBitwise {
} }
} }
fn allowed_operator(allow: &[String], operator: &str) -> bool { fn allowed_operator(allow: &[CompactStr], operator: &str) -> bool {
allow.iter().any(|s| s == operator) allow.iter().any(|s| s == operator)
} }