dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): jsx no undef match scope should check with ancestors (#2027)

Browse source
This commit is contained in:
西了意 2024-01-27 11:38:32 +08:00 committed by GitHub
parent 1b5bbb954c
commit f32228e0b7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 24 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
crates/oxc_linter/src/rules/react/jsx_no_undef.rs
View file

@ -63,14 +63,13 @@ impl Rule for JsxNoUndef {
if ident.name.as_str() == "this" {
return;
}
let has_binding = ctx
.symbols()
.get_scope_id_from_name(&ident.name)
.map_or(false, |scope_id| ctx.scopes().has_binding(scope_id, &ident.name));
if !has_binding {
ctx.diagnostic(JsxNoUndefDiagnostic(ident.name.clone(), ident.span));
let jsx_scope_id = node.scope_id();
for scope_id in ctx.scopes().ancestors(jsx_scope_id) {
if ctx.scopes().has_binding(scope_id, &ident.name) {
return;
}
}
ctx.diagnostic(JsxNoUndefDiagnostic(ident.name.clone(), ident.span));
}
}
}
@ -110,6 +109,8 @@ fn test() {
"#,
None,
),
("var App; var React; enum A { App }; React.render(<App />);", None),
("var React; enum A { App }; var App; React.render(<App />);", None),
];
let fail = vec![
@ -119,6 +120,8 @@ fn test() {
("var React; React.render(<appp.foo.Bar />);", None),
("var React; React.render(<Foo />);", None),
("var React; Unknown; React.render(<Unknown />)", None),
("var React; { const App = null; }; React.render(<App />);", None),
("var React; enum A { App }; React.render(<App />);", None),
];
Tester::new(JsxNoUndef::NAME, pass, fail).test_and_snapshot();

14
crates/oxc_linter/src/snapshots/jsx_no_undef.snap
View file

@ -44,4 +44,18 @@ expression: jsx_no_undef
╰────
help: 'Unknown' is not defined.
⚠ eslint-plugin-react(jsx-no-undef): Disallow undeclared variables in JSX
╭─[jsx_no_undef.tsx:1:1]
1 │ var React; { const App = null; }; React.render(<App />);
· ───
╰────
help: 'App' is not defined.
⚠ eslint-plugin-react(jsx-no-undef): Disallow undeclared variables in JSX
╭─[jsx_no_undef.tsx:1:1]
1 │ var React; enum A { App }; React.render(<App />);
· ───
╰────
help: 'App' is not defined.