dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(isolated-declarations): should not transform signature that has type annotation (#5927)

Browse source
This commit is contained in:
Dunqing 2024-09-20 14:19:04 +00:00
parent b6a9178075
commit f07ff14876
3 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_isolated_declarations/src/signatures.rs
View file

@ -30,12 +30,12 @@ impl<'a> IsolatedDeclarations<'a> {
}; };
let entry = method_annotations.entry(name).or_default(); let entry = method_annotations.entry(name).or_default();
entry.0 |= first_param.pattern.type_annotation.is_some(); entry.0 |= first_param.pattern.type_annotation.is_none();
entry.1 = Some(&mut first_param.pattern.type_annotation); entry.1 = Some(&mut first_param.pattern.type_annotation);
} }
TSMethodSignatureKind::Get => { TSMethodSignatureKind::Get => {
let entry = method_annotations.entry(name).or_default(); let entry = method_annotations.entry(name).or_default();
entry.0 |= method.return_type.is_some(); entry.0 |= method.return_type.is_none();
entry.2 = Some(&mut method.return_type); entry.2 = Some(&mut method.return_type);
} }
}; };

7
crates/oxc_isolated_declarations/tests/fixtures/signatures.ts vendored
View file

@ -11,3 +11,10 @@ export interface I {
set value(_); set value(_);
get value(): string; get value(): string;
} }
// Do nothing
export interface Ref<T = any, S = T> {
get value(): T
set value(_: S)
}

7
crates/oxc_isolated_declarations/tests/snapshots/signatures.snap
View file

@ -23,3 +23,10 @@ export interface I {
set value(_: string); set value(_: string);
get value(): string; get value(): string;
} }
export interface Ref<
T = any,
S = T
> {
get value(): T;
set value(_: S);
}