docs(linter): update rule documentation (#7684)

This commit is contained in:
camc314 2024-12-05 16:17:46 +00:00
parent be9863a415
commit f029090d65
4 changed files with 34 additions and 9 deletions

View file

@ -56,11 +56,15 @@ impl Default for ValidExpectConfig {
declare_oxc_lint!(
/// ### What it does
///
/// This rule triggers a warning if `expect()` is called with more than one argument
/// or without arguments. It would also issue a warning if there is nothing called
/// on `expect()`, e.g.:
/// Checks that `expect()` is called correctly.
///
/// Why is this bad?
///
/// `expect()` is a function that is used to assert values in tests. It should be called with a single argument, which is the value to be tested. If you call `expect()` with no arguments, or with more than one argument, it will not work as expected.
///
/// ### Example
///
/// Examples of **incorrect** code for this rule:
/// ```javascript
/// expect();
/// expect('something');
@ -68,6 +72,13 @@ declare_oxc_lint!(
/// expect(Promise.resolve('Hi!')).resolves.toBe('Hi!');
/// ```
///
/// Examples of **correct** code for this rule:
/// ```javascript
/// expect('something').toEqual('something');
/// expect(true).toBeDefined();
/// expect(Promise.resolve('Hi!')).resolves.toBe('Hi!');
/// ```
///
/// This rule is compatible with [eslint-plugin-vitest](https://github.com/veritem/eslint-plugin-vitest/blob/v1.1.9/docs/rules/valid-expect.md),
/// to use it, add the following configuration to your `.eslintrc.json`:
///

View file

@ -44,14 +44,21 @@ impl std::ops::Deref for ValidTitle {
declare_oxc_lint!(
/// ### What it does
///
/// Checks that the title of Jest blocks are valid by ensuring that titles are:
/// Checks that the titles of Jest blocks are valid.
///
/// Titles must be:
/// - not empty,
/// - is a string,
/// - strings,
/// - not prefixed with their block name,
/// - have no leading or trailing spaces
/// - have no leading or trailing spaces.
///
/// Why is this bad?
///
/// Titles that are not valid can be misleading and make it harder to understand the purpose of the test.
///
/// ### Example
///
/// Examples of **incorrect** code for this rule:
/// ```javascript
/// describe('', () => {});
/// describe('foo', () => {
@ -63,6 +70,11 @@ declare_oxc_lint!(
/// xit('', () => {});
/// xtest('', () => {});
/// ```
/// Examples of **correct** code for this rule:
/// ```javascript
/// describe('foo', () => {});
/// it('bar', () => {});
/// test('baz', () => {});
ValidTitle,
correctness,
conditional_fix

View file

@ -27,7 +27,7 @@ declare_oxc_lint!(
///
/// Enforce iframe elements have a title attribute.
///
/// ### Why is this necessary?
/// ### Why is this bad?
///
/// Screen reader users rely on a iframe title to describe the contents of the iframe.
/// Navigating through iframe and iframe elements quickly becomes difficult and confusing for users of this technology if the markup does not contain a title attribute.

View file

@ -25,10 +25,12 @@ pub struct NoChildrenProp;
declare_oxc_lint!(
/// ### What it does
///
/// Checks that children are not passed using a prop.
///
/// Why is this bad?
///
/// Children should always be actual children, not passed in as a prop.
///
/// When using JSX, the children should be nested between the opening and closing tags.
///
/// When not using JSX, the children should be passed as additional arguments to `React.createElement`.
///
/// ### Example