dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-22 05:38:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): false positive in jsx-a11y/iframe-has-title (#7253)

Browse source 
closes #7243
This commit is contained in:
dalaoshu 2024-11-12 21:14:50 +08:00 committed by GitHub
parent 44375a5662
commit ef847dab9c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_linter/src/rules/jsx_a11y/iframe_has_title.rs
View file

@ -99,6 +99,9 @@ impl Rule for IframeHasTitle {
return; return;
} }
} }
JSXExpression::CallExpression(_) => {
return;
}
expr @ JSXExpression::Identifier(_) => { expr @ JSXExpression::Identifier(_) => {
if !expr.is_undefined() { if !expr.is_undefined() {
return; return;
@ -124,6 +127,7 @@ fn test() {
(r"<iframe title='Unique title' />", None, None), (r"<iframe title='Unique title' />", None, None),
(r"<iframe title={foo} />", None, None), (r"<iframe title={foo} />", None, None),
(r"<FooComponent />", None, None), (r"<FooComponent />", None, None),
(r"<iframe title={titleGenerator('hello')} />", None, None),
// CUSTOM ELEMENT TESTS FOR COMPONENTS SETTINGS // CUSTOM ELEMENT TESTS FOR COMPONENTS SETTINGS
( (
r"<FooComponent title='Unique title' />", r"<FooComponent title='Unique title' />",