dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(semantic): add SymbolFlags::Function for FunctionDeclaration (#1713)

Browse source 
Co-authored-by: Boshen <boshenc@gmail.com>
This commit is contained in:
Dunqing 2023-12-18 11:26:33 +08:00 committed by GitHub
parent ef08892027
commit edc6fa4830
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
crates/oxc_semantic/src/binder.rs
View file

@ -122,7 +122,10 @@ impl<'a> Binder for Function<'a> {
if (parent_flags.is_strict_mode() || self.r#async || self.generator) if (parent_flags.is_strict_mode() || self.r#async || self.generator)
&& !function_as_var(parent_flags, builder.source_type) && !function_as_var(parent_flags, builder.source_type)
{ {
(SymbolFlags::BlockScopedVariable, SymbolFlags::BlockScopedVariableExcludes) (
SymbolFlags::Function | SymbolFlags::BlockScopedVariable,
SymbolFlags::BlockScopedVariableExcludes,
)
} else { } else {
( (
SymbolFlags::FunctionScopedVariable, SymbolFlags::FunctionScopedVariable,

1
crates/oxc_semantic/tests/symbols.rs
View file

@ -18,7 +18,6 @@ fn test_class_simple() {
.test(); .test();
} }
#[ignore = "function symbols currently lack SymbolFlags::Function"]
#[test] #[test]
fn test_function_simple() { fn test_function_simple() {
SemanticTester::js("function foo() { return }") SemanticTester::js("function foo() { return }")