dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): handle import { default as foo } in import/named (#3255)

Browse source
This commit is contained in:
Boshen 2024-05-13 08:56:30 +00:00
parent 34dd53cc98
commit edb30e1be8
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
crates/oxc_linter/src/rules/import/named.rs
View file

@ -53,20 +53,26 @@ impl Rule for Named {
if remote_module_record.not_esm {
continue;
}
let import_span = import_name.span();
let import_name = import_name.name();
// Check `import { default as foo } from 'bar'`
if import_name.as_str() == "default" && remote_module_record.export_default.is_some() {
continue;
}
// Check remote bindings
if remote_module_record.exported_bindings.contains_key(import_name.name()) {
if remote_module_record.exported_bindings.contains_key(import_name) {
continue;
}
// check re-export
if remote_module_record
.exported_bindings_from_star_export
.iter()
.any(|entry| entry.value().contains(import_name.name()))
.any(|entry| entry.value().contains(import_name))
{
continue;
}
ctx.diagnostic(named_diagnostic(import_name.name(), specifier, import_name.span()));
ctx.diagnostic(named_diagnostic(import_name, specifier, import_span));
}
for export_entry in &module_record.indirect_export_entries {
@ -82,6 +88,9 @@ impl Rule for Named {
continue;
};
let remote_module_record = remote_module_record_ref.value();
if remote_module_record.not_esm {
continue;
}
// Check remote bindings
let name = import_name.name();
// `export { default as foo } from './source'` <> `export default xxx`
@ -172,6 +181,7 @@ fn test() {
// TypeScript export assignment
"import x from './typescript-export-assign-object'",
"export { default as foo } from './typescript-export-default'",
"import { default as foo } from './typescript-export-default'",
];
let fail = vec![