dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(eslint/radix): detect yield Number.parseInt variant (#4110)

Browse source 
The eslint rule perfer-numeric-literals has a test for the yield variant
which the radix testsuite did not have. See
https://github.com/oxc-project/oxc/pull/4109
This commit is contained in:
Jelle van der Waa 2024-07-08 12:33:18 +02:00 committed by GitHub
parent a873522ee1
commit ed4c54c0de
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
crates/oxc_linter/src/rules/eslint/radix.rs
View file

@ -83,6 +83,17 @@ impl Rule for Radix {
{ {
Self::check_arguments(self, call_expr, ctx); Self::check_arguments(self, call_expr, ctx);
} }
} else if let Expression::ParenthesizedExpression(paren_expr) =
&member_expr.object
{
if let Expression::Identifier(ident) = &paren_expr.expression {
if ident.name == "Number"
&& member_expr.property.name == "parseInt"
&& ctx.symbols().get_symbol_id_from_name("Number").is_none()
{
Self::check_arguments(self, call_expr, ctx);
}
}
} }
} }
Expression::ChainExpression(chain_expr) => { Expression::ChainExpression(chain_expr) => {
@ -192,6 +203,7 @@ fn test() {
("var Number; Number.parseInt(foo, 10);", Some(json!(["as-needed"]))), ("var Number; Number.parseInt(foo, 10);", Some(json!(["as-needed"]))),
// ("/* globals parseInt:off */ parseInt(foo);", Some(json!(["always"]))), // ("/* globals parseInt:off */ parseInt(foo);", Some(json!(["always"]))),
// ("Number.parseInt(foo, 10);", Some(json!(["as-needed"]))), // { globals: { Number: "off" } } // ("Number.parseInt(foo, 10);", Some(json!(["as-needed"]))), // { globals: { Number: "off" } }
(r#"function *f(){ yield(Number).parseInt("10", foo) }"#, None), // { "ecmaVersion": 6 },
]; ];
let fail = vec![ let fail = vec![
@ -220,6 +232,7 @@ fn test() {
(r#"Number.parseInt?.("10");"#, None), (r#"Number.parseInt?.("10");"#, None),
(r#"Number?.parseInt("10");"#, None), (r#"Number?.parseInt("10");"#, None),
(r#"(Number?.parseInt)("10");"#, None), (r#"(Number?.parseInt)("10");"#, None),
("function *f(){ yield(Number).parseInt() }", None), // { "ecmaVersion": 6 },
]; ];
Tester::new(Radix::NAME, pass, fail).test_and_snapshot(); Tester::new(Radix::NAME, pass, fail).test_and_snapshot();

6
crates/oxc_linter/src/snapshots/radix.snap
View file

@ -150,3 +150,9 @@ source: crates/oxc_linter/src/tester.rs
1 │ (Number?.parseInt)("10"); 1 │ (Number?.parseInt)("10");
· ──────────────────────── · ────────────────────────
╰──── ╰────
⚠ eslint(radix): Missing parameters.
╭─[radix.tsx:1:21]
1 │ function *f(){ yield(Number).parseInt() }
· ───────────────────
╰────