From ecdd7bc33b6cd0586fda291dd6b3b5bb8fa2de76 Mon Sep 17 00:00:00 2001 From: Boshen Date: Fri, 30 Jun 2023 17:04:31 +0800 Subject: [PATCH] fix(linter): fix error message for no_dupe_keys --- .../src/rules/eslint/no_dupe_keys.rs | 2 +- .../src/snapshots/no_dupe_keys.snap | 32 +++++++++---------- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/crates/oxc_linter/src/rules/eslint/no_dupe_keys.rs b/crates/oxc_linter/src/rules/eslint/no_dupe_keys.rs index 66910667e..430a0aa62 100644 --- a/crates/oxc_linter/src/rules/eslint/no_dupe_keys.rs +++ b/crates/oxc_linter/src/rules/eslint/no_dupe_keys.rs @@ -13,7 +13,7 @@ use rustc_hash::FxHashMap; use crate::{ast_util::calculate_hash, context::LintContext, rule::Rule, AstNode}; #[derive(Debug, Error, Diagnostic)] -#[error("eslint(no-dupe_keys): Disallow duplicate keys in object literals")] +#[error("eslint(no-dupe-keys): Disallow duplicate keys in object literals")] #[diagnostic(severity(warning), help("Consider removing the duplicated key"))] struct NoDupeKeysDiagnostic(#[label] pub Span, #[label] pub Span); diff --git a/crates/oxc_linter/src/snapshots/no_dupe_keys.snap b/crates/oxc_linter/src/snapshots/no_dupe_keys.snap index 4cbb59935..68b400d8c 100644 --- a/crates/oxc_linter/src/snapshots/no_dupe_keys.snap +++ b/crates/oxc_linter/src/snapshots/no_dupe_keys.snap @@ -2,84 +2,84 @@ source: crates/oxc_linter/src/tester.rs expression: no_dupe_keys --- - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { a: b, ['a']: b }; · ─ ─── ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { y: 1, y: 2 }; · ─ ─ ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { '': 1, '': 2 }; · ── ── ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { '': 1, [``]: 2 }; · ── ── ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var foo = { 0x1: 1, 1: 2}; · ─── ─ ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { 012: 1, 10: 2 }; · ─── ── ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { 0b1: 1, 1: 2 }; · ─── ─ ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { 0o1: 1, 1: 2 }; · ─── ─ ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { 1n: 1, 1: 2 }; · ── ─ ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { 1_0: 1, 10: 2 }; · ─── ── ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { "z": 1, z: 2 }; · ─── ─ ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var foo = { 2 │ bar: 1, @@ -90,28 +90,28 @@ expression: no_dupe_keys ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { a: 1, get a() {} }; · ─ ─ ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { a: 1, set a(value) {} }; · ─ ─ ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = { a: 1, b: { a: 2 }, get b() {} }; · ─ ─ ╰──── help: Consider removing the duplicated key - ⚠ eslint(no-dupe_keys): Disallow duplicate keys in object literals + ⚠ eslint(no-dupe-keys): Disallow duplicate keys in object literals ╭─[no_dupe_keys.tsx:1:1] 1 │ var x = ({ '/(?0)/': 1, [/(?0)/]: 2 }) · ────────────── ────────────