dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 12:51:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(ast): AcessorProperty is missing decorators (#2176)

Browse source
This commit is contained in:
Dunqing 2024-01-26 15:43:05 +08:00 committed by GitHub
parent 2e3153e16f
commit ea8cc98c34
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
crates/oxc_ast/src/ast/js.rs
View file

@ -2052,6 +2052,7 @@ pub struct AccessorProperty<'a> {
pub value: Option<Expression<'a>>, pub value: Option<Expression<'a>>,
pub computed: bool, pub computed: bool,
pub r#static: bool, pub r#static: bool,
pub decorators: Vec<'a, Decorator<'a>>,
} }
#[derive(Debug, Hash)] #[derive(Debug, Hash)]

2
crates/oxc_ast/src/ast_builder.rs
View file

@ -886,6 +886,7 @@ impl<'a> AstBuilder<'a> {
value: Option<Expression<'a>>, value: Option<Expression<'a>>,
computed: bool, computed: bool,
r#static: bool, r#static: bool,
decorators: Vec<'a, Decorator<'a>>,
) -> ClassElement<'a> { ) -> ClassElement<'a> {
ClassElement::AccessorProperty(self.alloc(AccessorProperty { ClassElement::AccessorProperty(self.alloc(AccessorProperty {
span, span,
@ -893,6 +894,7 @@ impl<'a> AstBuilder<'a> {
value, value,
computed, computed,
r#static, r#static,
decorators,
})) }))
} }

9
crates/oxc_parser/src/js/class.rs
View file

@ -478,6 +478,13 @@ impl<'a> Parser<'a> {
) -> Result<ClassElement<'a>> { ) -> Result<ClassElement<'a>> {
let value = let value =
self.eat(Kind::Eq).then(|| self.parse_assignment_expression_base()).transpose()?; self.eat(Kind::Eq).then(|| self.parse_assignment_expression_base()).transpose()?;
Ok(self.ast.accessor_property(self.end_span(span), key, value, computed, r#static)) Ok(self.ast.accessor_property(
self.end_span(span),
key,
value,
computed,
r#static,
self.state.consume_decorators(),
))
} }
} }

4
tasks/coverage/codegen_typescript.snap
View file

@ -1,6 +1,6 @@
codegen_typescript Summary: codegen_typescript Summary:
AST Parsed : 5243/5243 (100.00%) AST Parsed : 5243/5243 (100.00%)
Positive Passed: 5214/5243 (99.45%) Positive Passed: 5216/5243 (99.49%)
Expect to Parse: "compiler/binopAssignmentShouldHaveType.ts" Expect to Parse: "compiler/binopAssignmentShouldHaveType.ts"
Expect to Parse: "compiler/castExpressionParentheses.ts" Expect to Parse: "compiler/castExpressionParentheses.ts"
Expect to Parse: "compiler/elidedEmbeddedStatementsReplacedWithSemicolon.ts" Expect to Parse: "compiler/elidedEmbeddedStatementsReplacedWithSemicolon.ts"
@ -14,8 +14,6 @@ Expect to Parse: "compiler/modularizeLibrary_Dom.asynciterable.ts"
Expect to Parse: "compiler/modularizeLibrary_Worker.asynciterable.ts" Expect to Parse: "compiler/modularizeLibrary_Worker.asynciterable.ts"
Expect to Parse: "compiler/typeAliasDeclarationEmit3.ts" Expect to Parse: "compiler/typeAliasDeclarationEmit3.ts"
Expect to Parse: "conformance/constEnums/constEnum4.ts" Expect to Parse: "conformance/constEnums/constEnum4.ts"
Expect to Parse: "conformance/decorators/legacyDecorators-contextualTypes.ts"
Expect to Parse: "conformance/esDecorators/esDecorators-contextualTypes.ts"
Expect to Parse: "conformance/expressions/asOperator/asOpEmitParens.ts" Expect to Parse: "conformance/expressions/asOperator/asOpEmitParens.ts"
Expect to Parse: "conformance/expressions/elementAccess/letIdentifierInElementAccess01.ts" Expect to Parse: "conformance/expressions/elementAccess/letIdentifierInElementAccess01.ts"
Expect to Parse: "conformance/jsx/jsxReactTestSuite.tsx" Expect to Parse: "conformance/jsx/jsxReactTestSuite.tsx"