dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): fixer for no-debugger creates incorrect code (#4184)

Browse source 
Part of #4179.

Fixes cases like:
```js
if (foo) debugger
// got fixed into
if (foo)
// but now gets fixed to
if (foo) {}
```
This commit is contained in:
DonIsaac 2024-07-11 04:33:43 +00:00
parent 278c3e9313
commit e9ad03bb62
1 changed files with 31 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
crates/oxc_linter/src/rules/eslint/no_debugger.rs
View file

@ -35,7 +35,28 @@ impl Rule for NoDebugger {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
if let AstKind::DebuggerStatement(stmt) = node.kind() {
ctx.diagnostic_with_fix(no_debugger_diagnostic(stmt.span), |fixer| {
fixer.delete(&stmt.span)
let Some(parent) = ctx
.nodes()
.iter_parents(node.id())
.skip(1)
.find(|p| !matches!(p.kind(), AstKind::ParenthesizedExpression(_)))
else {
return fixer.delete(&stmt.span);
};
// For statements like `if (foo) debugger;`, we can't just
// delete the `debugger` statement; we need to replace it with an empty block.
match parent.kind() {
AstKind::IfStatement(_)
| AstKind::WhileStatement(_)
| AstKind::ForStatement(_)
| AstKind::ForInStatement(_)
| AstKind::ForOfStatement(_) => return fixer.replace(stmt.span, "{}"),
// NOTE: no need to check for
// AstKind::ArrowFunctionExpression because
// `const x = () => debugger` is a parse error
_ => fixer.delete(&stmt.span),
}
});
}
}
@ -48,6 +69,14 @@ fn test() {
let pass = vec![("var test = { debugger: 1 }; test.debugger;", None)];
let fail = vec![("if (foo) debugger", None)];
let fix = vec![
("let x; debugger; let y;", "let x; let y;", None),
("if (foo) debugger", "if (foo) {}", None),
("for (;;) debugger", "for (;;) {}", None),
("while (i > 0) debugger", "while (i > 0) {}", None),
("if (foo) { debugger; }", "if (foo) { }", None),
("if (foo) { debugger }", "if (foo) { }", None),
];
Tester::new(NoDebugger::NAME, pass, fail).test_and_snapshot();
Tester::new(NoDebugger::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
}