dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(minifier): minimize !0 + null !== 1 -> !0 + null != 1 (#8332)

Browse source
This commit is contained in:
Boshen 2025-01-08 04:36:41 +00:00
parent 98f2b1ccd5
commit e88a6bdd94
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
crates/oxc_ecmascript/src/constant_evaluation/value_type.rs
View file

@ -103,15 +103,20 @@ impl<'a> From<&BinaryExpression<'a>> for ValueType {
fn from(e: &BinaryExpression<'a>) -> Self {
match e.operator {
BinaryOperator::Addition => {
let left_ty = Self::from(&e.left);
let right_ty = Self::from(&e.right);
if left_ty == Self::String || right_ty == Self::String {
let left = Self::from(&e.left);
let right = Self::from(&e.right);
if left == Self::Boolean
&& matches!(right, Self::Undefined | Self::Null | Self::Number)
{
return Self::Number;
}
if left == Self::String || right == Self::String {
return Self::String;
}
// There are some pretty weird cases for object types:
// {} + [] === "0"
// [] + {} === "[object Object]"
if left_ty == Self::Object || right_ty == Self::Object {
if left == Self::Object || right == Self::Object {
return Self::Undetermined;
}
Self::Undetermined

1
crates/oxc_minifier/src/ast_passes/peephole_minimize_conditions.rs
View file

@ -1755,6 +1755,7 @@ mod test {
test("(x = 1) === 1", "(x = 1) == 1");
test("(x = 1) !== 1", "(x = 1) != 1");
test("!0 + null !== 1", "!0 + null != 1");
}
#[test]