dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(transformer/jsx): incorrect isStaticChildren argument for Fragment with multiple children (#8713)

Browse source 
close: #8650
This commit is contained in:
Dunqing 2025-01-25 16:11:28 +00:00
parent bf8be23f11
commit e7ab96cbb6
5 changed files with 24 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crates/oxc_transformer/src/jsx/jsx_impl.rs
View file

@ -719,10 +719,9 @@ impl<'a> JsxImpl<'a, '_> {
// isStaticChildren
if is_development {
arguments.push(Argument::from(ctx.ast.expression_boolean_literal(
SPAN,
if is_fragment { false } else { children_len > 1 },
)));
arguments.push(Argument::from(
ctx.ast.expression_boolean_literal(SPAN, children_len > 1),
));
}
// Fragment doesn't have source and self

4
tasks/transform_conformance/snapshots/oxc.snap.md
View file

@ -1,6 +1,6 @@
commit: acbc09a8
Passed: 132/154
Passed: 133/155
# All Passed:
* babel-plugin-transform-class-static-block
@ -261,7 +261,7 @@ rebuilt : SymbolId(2): []
x Output mismatch
# babel-plugin-transform-react-jsx (34/37)
# babel-plugin-transform-react-jsx (35/38)
* refresh/does-not-transform-it-because-it-is-not-used-in-the-AST/input.jsx
x Output mismatch

4
tasks/transform_conformance/tests/babel-plugin-transform-react-jsx/test/fixtures/fragment-static-children/input.jsx vendored Normal file
View file

@ -0,0 +1,4 @@
<>
<div></div>
<div></div>
</>

4
tasks/transform_conformance/tests/babel-plugin-transform-react-jsx/test/fixtures/fragment-static-children/options.json vendored Normal file
View file

@ -0,0 +1,4 @@
{
"plugins": [["transform-react-jsx-development"]],
"sourceType": "module"
}

11
tasks/transform_conformance/tests/babel-plugin-transform-react-jsx/test/fixtures/fragment-static-children/output.js vendored Normal file
View file

@ -0,0 +1,11 @@
var _jsxFileName = "<CWD>/tests/babel-plugin-transform-react-jsx/test/fixtures/fragment-static-children/input.jsx";
import { jsxDEV as _jsxDEV, Fragment as _Fragment } from "react/jsx-dev-runtime";
_jsxDEV(_Fragment, { children: [_jsxDEV("div", {}, void 0, false, {
fileName: _jsxFileName,
lineNumber: 2,
columnNumber: 3
}, this), _jsxDEV("div", {}, void 0, false, {
fileName: _jsxFileName,
lineNumber: 3,
columnNumber: 3
}, this)] }, void 0, true);