dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer/class-properties): placeholder method for transforming private field assignment patterns (#7482)

Browse source 
Add a no-op placeholder method for transforming private fields as `AssignmentPattern`s. e.g. `[object.#prop] = []`.

Implementation will be added later.
This commit is contained in:
overlookmotel 2024-11-25 20:10:07 +00:00
parent 97de0b7be1
commit e5d49db360
2 changed files with 50 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
crates/oxc_transformer/src/es2022/class_properties/mod.rs
View file

@ -302,12 +302,18 @@ impl<'a, 'ctx> Traverse<'a> for ClassProperties<'a, 'ctx> {
// TODO: `transform_tagged_template_expression` is no-op at present
self.transform_tagged_template_expression(expr, ctx);
}
// TODO: `[object.#prop] = value`
// TODO: `({x: object.#prop} = value)`
_ => {}
}
}
fn enter_assignment_target(
&mut self,
target: &mut AssignmentTarget<'a>,
ctx: &mut TraverseCtx<'a>,
) {
self.transform_assignment_target(target, ctx);
}
fn enter_statement(&mut self, stmt: &mut Statement<'a>, ctx: &mut TraverseCtx<'a>) {
match stmt {
// `class C {}`

42
crates/oxc_transformer/src/es2022/class_properties/private.rs
View file

@ -815,6 +815,48 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
// See `private/tagged-template` fixture.
}
/// Transform private field in assignment pattern.
///
/// Instance prop:
/// * `[object.#prop] = arr` -> `[_toSetter(_classPrivateFieldSet, [_prop, object])._] = arr`
/// * `({x: object.#prop} = obj)` -> `({ x: _toSetter(_classPrivateFieldSet, [_prop, object])._ } = obj)`
///
/// Static prop:
/// (same as `Expression::PrivateFieldExpression` is transformed to)
/// * `[object.#prop] = arr` -> `[_assertClassBrand(Class, object, _prop)._] = arr`
/// * `({x: object.#prop} = obj)` -> `({ x: _assertClassBrand(Class, object, _prop)._ } = obj)`
//
// `#[inline]` because most `AssignmentTarget`s are not `PrivateFieldExpression`s.
// So we want to bail out in that common case without the cost of a function call.
// Transform of `PrivateFieldExpression`s in broken out into `transform_assignment_target_impl` to
// keep this function as small as possible.
#[inline]
pub(super) fn transform_assignment_target(
&mut self,
target: &mut AssignmentTarget<'a>,
ctx: &mut TraverseCtx<'a>,
) {
// `object.#prop` in assignment pattern.
// Must be in assignment pattern, as `enter_expression` already transformed `AssignmentExpression`s.
if matches!(target, AssignmentTarget::PrivateFieldExpression(_)) {
self.transform_assignment_target_impl(target, ctx);
}
}
#[expect(clippy::unused_self)]
fn transform_assignment_target_impl(
&mut self,
target: &mut AssignmentTarget<'a>,
_ctx: &mut TraverseCtx<'a>,
) {
let AssignmentTarget::PrivateFieldExpression(_private_field) = target else {
unreachable!()
};
// TODO: `[object.#prop] = value`
// TODO: `({x: object.#prop} = value)`
}
/// Duplicate object to be used in get/set pair.
///
/// If `object` may have side effects, create a temp var `_object` and assign to it.