dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(linter): use Expression::is_super (#7850)

Browse source 
Simplify code by using `Expression::is_super` which was introduced in #7831.

Also remove a lifetime bound which is unnecessary and replace use of `bool::then` (which I always find hard to read) with more explicit code.
This commit is contained in:
overlookmotel 2024-12-13 14:47:31 +00:00
parent 1eab12a03a
commit e55ab24cc9
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
crates/oxc_linter/src/rules/eslint/no_useless_constructor.rs
View file

@ -192,17 +192,21 @@ fn is_overriding(params: &FormalParameters) -> bool {
params.items.iter().any(|param| param.r#override)
}
/// Check if a function body only contains a single super call. Ignores directives.
/// Check if a function body only contains a single `super()` call. Ignores directives.
///
/// Returns the call expression if the body contains a single super call, otherwise [`None`].
fn is_single_super_call<'f, 'a: 'f>(body: &'f FunctionBody<'a>) -> Option<&'f CallExpression<'a>> {
/// Returns the call expression if the body contains a single `super()` call, otherwise [`None`].
fn is_single_super_call<'a, 'f>(body: &'f FunctionBody<'a>) -> Option<&'f CallExpression<'a>> {
if body.statements.len() != 1 {
return None;
}
let Statement::ExpressionStatement(expr) = &body.statements[0] else { return None };
let Expression::CallExpression(call) = &expr.expression else { return None };
matches!(call.callee, Expression::Super(_)).then(|| call.as_ref())
if call.callee.is_super() {
Some(call)
} else {
None
}
}
/// Returns `false` if any parameter is an array/object unpacking binding or an