feat(linter/eslint): implement fixer for prefer-numeric-literals (#4591)

This commit is contained in:
Jelle van der Waa 2024-08-01 03:24:42 +02:00 committed by GitHub
parent 4c6d19d440
commit e116ae0832
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 186 additions and 57 deletions

View file

@ -8,9 +8,12 @@ use oxc_ast::{
use oxc_diagnostics::OxcDiagnostic; use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint; use oxc_macros::declare_oxc_lint;
use oxc_span::Span; use oxc_span::Span;
use phf::{phf_map, Map}; use phf::{phf_map, phf_ordered_set, Map};
use crate::{ast_util::get_symbol_id_of_variable, context::LintContext, rule::Rule, AstNode}; use crate::{
ast_util::get_symbol_id_of_variable, context::LintContext, fixer::RuleFixer, rule::Rule,
AstNode,
};
fn prefer_numeric_literals_diagnostic(span0: Span, x0: &str) -> OxcDiagnostic { fn prefer_numeric_literals_diagnostic(span0: Span, x0: &str) -> OxcDiagnostic {
OxcDiagnostic::warn(format!("Use {x0} literals instead of parseInt().")).with_label(span0) OxcDiagnostic::warn(format!("Use {x0} literals instead of parseInt().")).with_label(span0)
@ -19,10 +22,10 @@ fn prefer_numeric_literals_diagnostic(span0: Span, x0: &str) -> OxcDiagnostic {
#[derive(Debug, Default, Clone)] #[derive(Debug, Default, Clone)]
pub struct PreferNumericLiterals; pub struct PreferNumericLiterals;
const RADIX_MAP: Map<&'static str, &'static str> = phf_map! { const RADIX_MAP: Map<&'static str, phf::OrderedSet<&'static str>> = phf_map! {
"2" => "binary", "2" => phf_ordered_set!{"binary", "0b"},
"8" => "octal", "8" => phf_ordered_set!{"octal", "0o"},
"16" => "hexadecimal", "16" => phf_ordered_set!{"hexadecimal", "0x"},
}; };
declare_oxc_lint!( declare_oxc_lint!(
@ -50,6 +53,7 @@ declare_oxc_lint!(
/// ``` /// ```
PreferNumericLiterals, PreferNumericLiterals,
style, style,
conditional_fix
); );
impl Rule for PreferNumericLiterals { impl Rule for PreferNumericLiterals {
@ -126,11 +130,88 @@ fn check_arguments<'a>(call_expr: &CallExpression<'a>, ctx: &LintContext<'a>) {
return; return;
}; };
if let Some(name) = RADIX_MAP.get(numeric_lit.raw) { if let Some(name_prefix_set) = RADIX_MAP.get(numeric_lit.raw) {
ctx.diagnostic(prefer_numeric_literals_diagnostic(call_expr.span, name)); let name = name_prefix_set.index(0).unwrap();
let prefix = name_prefix_set.index(1).unwrap();
match is_fixable(call_expr, numeric_lit.raw) {
Ok(argument) => {
ctx.diagnostic_with_fix(
prefer_numeric_literals_diagnostic(call_expr.span, name),
|fixer| {
fixer.replace(
call_expr.span,
generate_fix(fixer, ctx, call_expr, &argument, prefix),
)
},
);
}
Err(_) => ctx.diagnostic(prefer_numeric_literals_diagnostic(call_expr.span, name)),
}
} }
} }
fn is_fixable(
call_expr: &CallExpression,
radix: &str,
) -> Result<String, Box<dyn std::error::Error>> {
let Some(string_argument) = get_string_argument(call_expr) else {
return Err("".into());
};
if string_argument.is_empty() {
return Err("".into());
}
let radix_num = radix.parse::<u32>()?;
i64::from_str_radix(&string_argument, radix_num)?;
Ok(string_argument)
}
fn get_string_argument(call_expr: &CallExpression) -> Option<String> {
if let Argument::StringLiteral(ident) = &call_expr.arguments[0] {
return Some(ident.value.to_string());
} else if let Argument::TemplateLiteral(temp) = &call_expr.arguments[0] {
if temp.quasis.is_empty() {
return None;
}
return Some(temp.quasis[0].value.raw.to_string());
}
None
}
fn generate_fix<'a>(
fixer: RuleFixer<'_, 'a>,
ctx: &LintContext<'a>,
call_expr: &CallExpression<'a>,
argument: &str,
prefix: &str,
) -> String {
let mut formatter = fixer.codegen();
let span = call_expr.span;
if span.start > 1 {
let start = ctx.source_text().as_bytes()[span.start as usize - 1];
if start.is_ascii_alphabetic() || !start.is_ascii() {
formatter.print_str(" ");
}
}
formatter.print_str(prefix);
formatter.print_str(argument);
if (span.end as usize) < ctx.source_text().len() {
let end = ctx.source_text().as_bytes()[span.end as usize];
if end.is_ascii_alphabetic() || !end.is_ascii() {
formatter.print_str(" ");
}
}
formatter.into_source_text()
}
#[test] #[test]
fn test() { fn test() {
use crate::tester::Tester; use crate::tester::Tester;
@ -239,53 +320,53 @@ fn test() {
"#, "#,
]; ];
// let fix = vec![ let fix = vec![
// (r#"parseInt("111110111", 2) === 503;"#, "0b111110111 === 503;", None), (r#"parseInt("111110111", 2) === 503;"#, "0b111110111 === 503;", None),
// (r#"parseInt("767", 8) === 503;"#, "0o767 === 503;", None), (r#"parseInt("767", 8) === 503;"#, "0o767 === 503;", None),
// (r#"parseInt("1F7", 16) === 255;"#, "0x1F7 === 255;", None), (r#"parseInt("1F7", 16) === 255;"#, "0x1F7 === 255;", None),
// (r#"Number.parseInt("111110111", 2) === 503;"#, "0b111110111 === 503;", None), (r#"Number.parseInt("111110111", 2) === 503;"#, "0b111110111 === 503;", None),
// (r#"Number.parseInt("767", 8) === 503;"#, "0o767 === 503;", None), (r#"Number.parseInt("767", 8) === 503;"#, "0o767 === 503;", None),
// (r#"Number.parseInt("1F7", 16) === 255;"#, "0x1F7 === 255;", None), (r#"Number.parseInt("1F7", 16) === 255;"#, "0x1F7 === 255;", None),
// ("parseInt(`111110111`, 2) === 503;", "0b111110111 === 503;", None), ("parseInt(`111110111`, 2) === 503;", "0b111110111 === 503;", None),
// ("parseInt(`767`, 8) === 503;", "0o767 === 503;", None), ("parseInt(`767`, 8) === 503;", "0o767 === 503;", None),
// ("parseInt(`1F7`, 16) === 255;", "0x1F7 === 255;", None), ("parseInt(`1F7`, 16) === 255;", "0x1F7 === 255;", None),
// ("parseInt('11', 2)", "0b11", None), ("parseInt('11', 2)", "0b11", None),
// ("Number.parseInt('67', 8)", "0o67", None), ("Number.parseInt('67', 8)", "0o67", None),
// ("5+parseInt('A', 16)", "5+0xA", None), ("5+parseInt('A', 16)", "5+0xA", None),
// ("function *f(){ yield(Number).parseInt('11', 2) }", "function *f(){ yield 0b11 }", None), ("function *f(){ yield(Number).parseInt('11', 2) }", "function *f(){ yield 0b11 }", None),
// ("function *f(){ yield(Number.parseInt)('67', 8) }", "function *f(){ yield 0o67 }", None), ("function *f(){ yield(Number.parseInt)('67', 8) }", "function *f(){ yield 0o67 }", None),
// ("function *f(){ yield(parseInt)('A', 16) }", "function *f(){ yield 0xA }", None), ("function *f(){ yield(parseInt)('A', 16) }", "function *f(){ yield 0xA }", None),
// ("function *f(){ yield Number.parseInt('11', 2) }", "function *f(){ yield 0b11 }", None), ("function *f(){ yield Number.parseInt('11', 2) }", "function *f(){ yield 0b11 }", None),
// ( (
// "function *f(){ yield/**/Number.parseInt('67', 8) }", "function *f(){ yield/**/Number.parseInt('67', 8) }",
// "function *f(){ yield/**/0o67 }", "function *f(){ yield/**/0o67 }",
// None, None,
// ), ),
// ("function *f(){ yield(parseInt('A', 16)) }", "function *f(){ yield(0xA) }", None), ("function *f(){ yield(parseInt('A', 16)) }", "function *f(){ yield(0xA) }", None),
// ("parseInt('11', 2)+5", "0b11+5", None), ("parseInt('11', 2)+5", "0b11+5", None),
// ("Number.parseInt('17', 8)+5", "0o17+5", None), ("Number.parseInt('17', 8)+5", "0o17+5", None),
// ("parseInt('A', 16)+5", "0xA+5", None), ("parseInt('A', 16)+5", "0xA+5", None),
// ("parseInt('11', 2)in foo", "0b11 in foo", None), ("parseInt('11', 2)in foo", "0b11 in foo", None),
// ("Number.parseInt('17', 8)in foo", "0o17 in foo", None), ("Number.parseInt('17', 8)in foo", "0o17 in foo", None),
// ("parseInt('A', 16)in foo", "0xA in foo", None), ("parseInt('A', 16)in foo", "0xA in foo", None),
// ("parseInt('11', 2) in foo", "0b11 in foo", None), ("parseInt('11', 2) in foo", "0b11 in foo", None),
// ("Number.parseInt('17', 8)/**/in foo", "0o17/**/in foo", None), ("Number.parseInt('17', 8)/**/in foo", "0o17/**/in foo", None),
// ("(parseInt('A', 16))in foo", "(0xA)in foo", None), ("(parseInt('A', 16))in foo", "(0xA)in foo", None),
// ("/* comment */Number.parseInt('11', 2);", "/* comment */0b11;", None), ("/* comment */Number.parseInt('11', 2);", "/* comment */0b11;", None),
// ("Number.parseInt('11', 2)/* comment */;", "0b11/* comment */;", None), ("Number.parseInt('11', 2)/* comment */;", "0b11/* comment */;", None),
// ( (
// "parseInt('11', 2)//comment "parseInt('11', 2)//comment
// ;", ;",
// "0b11//comment "0b11//comment
// ;", ;",
// None, None,
// ), ),
// (r#"parseInt?.("1F7", 16) === 255;"#, "0x1F7 === 255;", None), (r#"parseInt?.("1F7", 16) === 255;"#, "0x1F7 === 255;", None),
// (r#"Number?.parseInt("1F7", 16) === 255;"#, "0x1F7 === 255;", None), (r#"Number?.parseInt("1F7", 16) === 255;"#, "0x1F7 === 255;", None),
// (r#"Number?.parseInt?.("1F7", 16) === 255;"#, "0x1F7 === 255;", None), (r#"Number?.parseInt?.("1F7", 16) === 255;"#, "0x1F7 === 255;", None),
// (r#"(Number?.parseInt)("1F7", 16) === 255;"#, "0x1F7 === 255;", None), (r#"(Number?.parseInt)("1F7", 16) === 255;"#, "0x1F7 === 255;", None),
// (r#"(Number?.parseInt)?.("1F7", 16) === 255;"#, "0x1F7 === 255;", None), (r#"(Number?.parseInt)?.("1F7", 16) === 255;"#, "0x1F7 === 255;", None),
// ]; ];
// Tester::new(PreferNumericLiterals::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
Tester::new(PreferNumericLiterals::NAME, pass, fail).test_and_snapshot(); Tester::new(PreferNumericLiterals::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
} }

View file

@ -6,36 +6,42 @@ source: crates/oxc_linter/src/tester.rs
1 │ parseInt("111110111", 2) === 503; 1 │ parseInt("111110111", 2) === 503;
· ──────────────────────── · ────────────────────────
╰──── ╰────
help: Replace `parseInt("111110111", 2)` with `0b111110111`.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt("767", 8) === 503; 1 │ parseInt("767", 8) === 503;
· ────────────────── · ──────────────────
╰──── ╰────
help: Replace `parseInt("767", 8)` with `0o767`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt("1F7", 16) === 255; 1 │ parseInt("1F7", 16) === 255;
· ─────────────────── · ───────────────────
╰──── ╰────
help: Replace `parseInt("1F7", 16)` with `0x1F7`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt("111110111", 2) === 503; 1 │ Number.parseInt("111110111", 2) === 503;
· ─────────────────────────────── · ───────────────────────────────
╰──── ╰────
help: Replace `Number.parseInt("111110111", 2)` with `0b111110111`.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt("767", 8) === 503; 1 │ Number.parseInt("767", 8) === 503;
· ───────────────────────── · ─────────────────────────
╰──── ╰────
help: Replace `Number.parseInt("767", 8)` with `0o767`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt("1F7", 16) === 255; 1 │ Number.parseInt("1F7", 16) === 255;
· ────────────────────────── · ──────────────────────────
╰──── ╰────
help: Replace `Number.parseInt("1F7", 16)` with `0x1F7`.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
@ -90,18 +96,21 @@ source: crates/oxc_linter/src/tester.rs
1 │ parseInt(`111110111`, 2) === 503; 1 │ parseInt(`111110111`, 2) === 503;
· ──────────────────────── · ────────────────────────
╰──── ╰────
help: Replace `parseInt(`111110111`, 2)` with `0b111110111`.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt(`767`, 8) === 503; 1 │ parseInt(`767`, 8) === 503;
· ────────────────── · ──────────────────
╰──── ╰────
help: Replace `parseInt(`767`, 8)` with `0o767`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt(`1F7`, 16) === 255; 1 │ parseInt(`1F7`, 16) === 255;
· ─────────────────── · ───────────────────
╰──── ╰────
help: Replace `parseInt(`1F7`, 16)` with `0x1F7`.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
@ -138,180 +147,212 @@ source: crates/oxc_linter/src/tester.rs
1 │ parseInt('11', 2) 1 │ parseInt('11', 2)
· ───────────────── · ─────────────────
╰──── ╰────
help: Replace `parseInt('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt('67', 8) 1 │ Number.parseInt('67', 8)
· ──────────────────────── · ────────────────────────
╰──── ╰────
help: Replace `Number.parseInt('67', 8)` with `0o67`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:3] ╭─[prefer_numeric_literals.tsx:1:3]
1 │ 5+parseInt('A', 16) 1 │ 5+parseInt('A', 16)
· ───────────────── · ─────────────────
╰──── ╰────
help: Replace `parseInt('A', 16)` with `0xA`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:21] ╭─[prefer_numeric_literals.tsx:1:21]
1 │ function *f(){ yield(Number).parseInt('11', 2) } 1 │ function *f(){ yield(Number).parseInt('11', 2) }
· ────────────────────────── · ──────────────────────────
╰──── ╰────
help: Replace `(Number).parseInt('11', 2)` with ` 0b11`.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:21] ╭─[prefer_numeric_literals.tsx:1:21]
1 │ function *f(){ yield(Number.parseInt)('67', 8) } 1 │ function *f(){ yield(Number.parseInt)('67', 8) }
· ────────────────────────── · ──────────────────────────
╰──── ╰────
help: Replace `(Number.parseInt)('67', 8)` with ` 0o67`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:21] ╭─[prefer_numeric_literals.tsx:1:21]
1 │ function *f(){ yield(parseInt)('A', 16) } 1 │ function *f(){ yield(parseInt)('A', 16) }
· ─────────────────── · ───────────────────
╰──── ╰────
help: Replace `(parseInt)('A', 16)` with ` 0xA`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:22] ╭─[prefer_numeric_literals.tsx:1:22]
1 │ function *f(){ yield Number.parseInt('11', 2) } 1 │ function *f(){ yield Number.parseInt('11', 2) }
· ──────────────────────── · ────────────────────────
╰──── ╰────
help: Replace `Number.parseInt('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:25] ╭─[prefer_numeric_literals.tsx:1:25]
1 │ function *f(){ yield/**/Number.parseInt('67', 8) } 1 │ function *f(){ yield/**/Number.parseInt('67', 8) }
· ──────────────────────── · ────────────────────────
╰──── ╰────
help: Replace `Number.parseInt('67', 8)` with `0o67`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:22] ╭─[prefer_numeric_literals.tsx:1:22]
1 │ function *f(){ yield(parseInt('A', 16)) } 1 │ function *f(){ yield(parseInt('A', 16)) }
· ───────────────── · ─────────────────
╰──── ╰────
help: Replace `parseInt('A', 16)` with `0xA`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt('11', 2)+5 1 │ parseInt('11', 2)+5
· ───────────────── · ─────────────────
╰──── ╰────
help: Replace `parseInt('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt('17', 8)+5 1 │ Number.parseInt('17', 8)+5
· ──────────────────────── · ────────────────────────
╰──── ╰────
help: Replace `Number.parseInt('17', 8)` with `0o17`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt('A', 16)+5 1 │ parseInt('A', 16)+5
· ───────────────── · ─────────────────
╰──── ╰────
help: Replace `parseInt('A', 16)` with `0xA`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt('11', 2)in foo 1 │ parseInt('11', 2)in foo
· ───────────────── · ─────────────────
╰──── ╰────
help: Replace `parseInt('11', 2)` with `0b11 `.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt('17', 8)in foo 1 │ Number.parseInt('17', 8)in foo
· ──────────────────────── · ────────────────────────
╰──── ╰────
help: Replace `Number.parseInt('17', 8)` with `0o17 `.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt('A', 16)in foo 1 │ parseInt('A', 16)in foo
· ───────────────── · ─────────────────
╰──── ╰────
help: Replace `parseInt('A', 16)` with `0xA `.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt('11', 2) in foo 1 │ parseInt('11', 2) in foo
· ───────────────── · ─────────────────
╰──── ╰────
help: Replace `parseInt('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use octal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt('17', 8)/**/in foo 1 │ Number.parseInt('17', 8)/**/in foo
· ──────────────────────── · ────────────────────────
╰──── ╰────
help: Replace `Number.parseInt('17', 8)` with `0o17`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:2] ╭─[prefer_numeric_literals.tsx:1:2]
1 │ (parseInt('A', 16))in foo 1 │ (parseInt('A', 16))in foo
· ───────────────── · ─────────────────
╰──── ╰────
help: Replace `parseInt('A', 16)` with `0xA`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:14] ╭─[prefer_numeric_literals.tsx:1:14]
1 │ /* comment */Number.parseInt('11', 2); 1 │ /* comment */Number.parseInt('11', 2);
· ──────────────────────── · ────────────────────────
╰──── ╰────
help: Replace `Number.parseInt('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number/**/.parseInt('11', 2); 1 │ Number/**/.parseInt('11', 2);
· ──────────────────────────── · ────────────────────────────
╰──── ╰────
help: Replace `Number/**/.parseInt('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ ╭─▶ Number// 1 │ ╭─▶ Number//
2 │ ╰─▶ .parseInt('11', 2); 2 │ ╰─▶ .parseInt('11', 2);
╰──── ╰────
help: Replace `Number//
.parseInt('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number./**/parseInt('11', 2); 1 │ Number./**/parseInt('11', 2);
· ──────────────────────────── · ────────────────────────────
╰──── ╰────
help: Replace `Number./**/parseInt('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt(/**/'11', 2); 1 │ Number.parseInt(/**/'11', 2);
· ──────────────────────────── · ────────────────────────────
╰──── ╰────
help: Replace `Number.parseInt(/**/'11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt('11', /**/2); 1 │ Number.parseInt('11', /**/2);
· ──────────────────────────── · ────────────────────────────
╰──── ╰────
help: Replace `Number.parseInt('11', /**/2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number.parseInt('11', 2)/* comment */; 1 │ Number.parseInt('11', 2)/* comment */;
· ──────────────────────── · ────────────────────────
╰──── ╰────
help: Replace `Number.parseInt('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt/**/('11', 2); 1 │ parseInt/**/('11', 2);
· ───────────────────── · ─────────────────────
╰──── ╰────
help: Replace `parseInt/**/('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ ╭─▶ parseInt(// 1 │ ╭─▶ parseInt(//
2 │ ╰─▶ '11', 2); 2 │ ╰─▶ '11', 2);
╰──── ╰────
help: Replace `parseInt(//
'11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt('11'/**/, 2); 1 │ parseInt('11'/**/, 2);
· ───────────────────── · ─────────────────────
╰──── ╰────
help: Replace `parseInt('11'/**/, 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt(`11`/**/, 2); 1 │ parseInt(`11`/**/, 2);
· ───────────────────── · ─────────────────────
╰──── ╰────
help: Replace `parseInt(`11`/**/, 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt('11', 2 /**/); 1 │ parseInt('11', 2 /**/);
· ────────────────────── · ──────────────────────
╰──── ╰────
help: Replace `parseInt('11', 2 /**/)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
@ -319,36 +360,42 @@ source: crates/oxc_linter/src/tester.rs
· ───────────────── · ─────────────────
2 │ ; 2 │ ;
╰──── ╰────
help: Replace `parseInt('11', 2)` with `0b11`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ parseInt?.("1F7", 16) === 255; 1 │ parseInt?.("1F7", 16) === 255;
· ───────────────────── · ─────────────────────
╰──── ╰────
help: Replace `parseInt?.("1F7", 16)` with `0x1F7`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number?.parseInt("1F7", 16) === 255; 1 │ Number?.parseInt("1F7", 16) === 255;
· ─────────────────────────── · ───────────────────────────
╰──── ╰────
help: Replace `Number?.parseInt("1F7", 16)` with `0x1F7`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ Number?.parseInt?.("1F7", 16) === 255; 1 │ Number?.parseInt?.("1F7", 16) === 255;
· ───────────────────────────── · ─────────────────────────────
╰──── ╰────
help: Replace `Number?.parseInt?.("1F7", 16)` with `0x1F7`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ (Number?.parseInt)("1F7", 16) === 255; 1 │ (Number?.parseInt)("1F7", 16) === 255;
· ───────────────────────────── · ─────────────────────────────
╰──── ╰────
help: Replace `(Number?.parseInt)("1F7", 16)` with `0x1F7`.
⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use hexadecimal literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
1 │ (Number?.parseInt)?.("1F7", 16) === 255; 1 │ (Number?.parseInt)?.("1F7", 16) === 255;
· ─────────────────────────────── · ───────────────────────────────
╰──── ╰────
help: Replace `(Number?.parseInt)?.("1F7", 16)` with `0x1F7`.
⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt(). ⚠ eslint(prefer-numeric-literals): Use binary literals instead of parseInt().
╭─[prefer_numeric_literals.tsx:1:1] ╭─[prefer_numeric_literals.tsx:1:1]
@ -381,3 +428,4 @@ source: crates/oxc_linter/src/tester.rs
· ────────────────── · ──────────────────
3 │ function foo() { 3 │ function foo() {
╰──── ╰────
help: Replace `parseInt("767", 8)` with `0o767`.