dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): improve the boundary for eslint/for-direction (#4590)

Browse source 
is_sign_positive() will treat 0.0 as true, which may cause some errors.

https://eslint.org/docs/latest/rules/for-direction#rule-details

demo

[oxc](https://oxc-project.github.io/oxc/playground/?code=3YCAAICfgICAgICAgICzm0omL6Rfsn9X7Kj61BmzN0yVAOAXkgdgAKNr9vvkaX9%2FKzKAgA%3D%3D)

[eslint](https://eslint.org/play/#eyJ0ZXh0IjoiZm9yKGxldCBpID0gMDsgaSA8IDEwOyBpLT0wKXtcbn0iLCJvcHRpb25zIjp7InJ1bGVzIjp7ImZvci1kaXJlY3Rpb24iOlsiZXJyb3IiXX0sImxhbmd1YWdlT3B0aW9ucyI6eyJwYXJzZXJPcHRpb25zIjp7ImVjbWFGZWF0dXJlcyI6e319fX19)

---------

Co-authored-by: Don Isaac <donald.isaac@gmail.com>
This commit is contained in:
heygsc 2024-08-01 23:40:16 +08:00 committed by GitHub
parent c7f1d48c0e
commit e0b03f85d6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/oxc_linter/src/rules/eslint/for_direction.rs
View file

@ -127,7 +127,10 @@ fn get_assignment_direction(assign: &AssignmentExpression) -> UpdateDirection {
let operator = &assign.operator;
let right = &assign.right;
let positive = match right {
Expression::NumericLiteral(r) => r.value.is_sign_positive(),
Expression::NumericLiteral(r) => match r.value {
0.0 => return UNKNOWN,
_ => r.value.is_sign_positive(),
},
Expression::UnaryExpression(right) => right.operator != UnaryOperator::UnaryNegation,
_ => return UNKNOWN,
};
@ -175,6 +178,10 @@ fn test() {
("for(var i = 10; i >= 0;){}", None),
("for(var i = 10; i < 0;){}", None),
("for(var i = 10; i <= 0;){}", None),
("for(var i = 0; i < 10; i+=0){}", None),
("for(var i = 0; i < 10; i-=0){}", None),
("for(var i = 10; i > 0; i+=0){}", None),
("for(var i = 10; i > 0; i-=0){}", None),
("for(var i = 10; i <= 0; j++){}", None),
("for(var i = 10; i <= 0; j--){}", None),
("for(var i = 10; i >= 0; j++){}", None),