feat(resolver): port incorrect description file test (#557)

crates/oxc_resolver/README.md

@@ -48,7 +48,7 @@ Tests ported from [enhanced-resolve](https://github.com/webpack/enhanced-resolve
 - [ ] getPaths.test.js
 - [ ] identifier.test.js
 - [ ] importsField.test.js
-- [ ] incorrect-description-file.test.js
+- [x] incorrect-description-file.test.js (need to add ctx.fileDependencies)
 - [ ] missing.test.js
 - [ ] path.test.js
 - [ ] plugins.test.js

crates/oxc_resolver/tests/enhanced_resolve/test/extension_alias.rs

@@ -50,8 +50,8 @@ fn extension_alias() -> Result<(), ResolveError> {
 }
 
 #[test]
-// should not apply extension alias to extensions or mainFiles field
 fn not_apply_to_extension_nor_main_files() -> Result<(), ResolveError> {
+    // should not apply extension alias to extensions or mainFiles field
     let options = ResolveOptions {
         extensions: vec![".js".into()],
         main_files: vec!["index.js".into()],

crates/oxc_resolver/tests/enhanced_resolve/test/incorrect_description_file.rs

@@ -0,0 +1,47 @@
+//! <https://github.com/webpack/enhanced-resolve/blob/main/test/incorrect-description-file.test.js>
+
+use std::path::PathBuf;
+
+use oxc_resolver::{JSONError, ResolveError, Resolver};
+
+fn fixture() -> PathBuf {
+    super::fixture().join("incorrect-package")
+}
+
+// TODO: add `ctx with fileDependencies and then check file dependencies
+
+#[test]
+fn incorrect_description_file_1() {
+    // should not resolve main in incorrect description file #1
+    let f = fixture();
+    let resolution = Resolver::default().resolve(f.join("pack1"), ".");
+    let error = ResolveError::JSON(JSONError {
+        path: f.join("pack1/package.json"),
+        message: String::from("EOF while parsing a value at line 3 column 0"),
+        line: 3,
+        column: 0,
+    });
+    assert_eq!(resolution, Err(error));
+}
+
+#[test]
+fn incorrect_description_file_2() {
+    // should not resolve main in incorrect description file #2
+    let f = fixture();
+    let resolution = Resolver::default().resolve(f.join("pack2"), ".");
+    let error = ResolveError::JSON(JSONError {
+        path: f.join("pack2/package.json"),
+        message: String::from("EOF while parsing a value at line 1 column 0"),
+        line: 1,
+        column: 0,
+    });
+    assert_eq!(resolution, Err(error));
+}
+
+#[test]
+fn incorrect_description_file_3() {
+    // should not resolve main in incorrect description file #3
+    let f = fixture();
+    let resolution = Resolver::default().resolve(f.join("pack2"), ".");
+    assert!(resolution.is_err());
+}

crates/oxc_resolver/tests/enhanced_resolve/test/mod.rs

@@ -1,5 +1,6 @@
 mod extension_alias;
 mod extensions;
+mod incorrect_description_file;
 mod resolve;
 mod simple;
 

crates/oxc_resolver/tests/error_handling/broken_package_json/package.json

@@ -1 +0,0 @@
-broken json

crates/oxc_resolver/tests/error_handling/mod.rs

@@ -1,17 +0,0 @@
-use std::env;
-
-use oxc_resolver::{JSONError, ResolveError, Resolver};
-
-#[test]
-fn broken_json() {
-    let dir = env::current_dir().unwrap().join("tests/error_handling/");
-    let resolver = Resolver::default();
-    let resolution = resolver.resolve(&dir, "./broken_package_json");
-    let error = ResolveError::JSON(JSONError {
-        path: dir.join("broken_package_json").join("package.json"),
-        message: String::from("expected value at line 1 column 1"),
-        line: 1,
-        column: 1,
-    });
-    assert_eq!(resolution, Err(error));
-}

crates/oxc_resolver/tests/mod.rs

@@ -1,5 +1,4 @@
 mod enhanced_resolve;
-mod error_handling;
 
 use std::{env, sync::Arc, thread};