mirror of
https://github.com/danbulant/oxc
synced 2026-05-19 12:19:15 +00:00
fix(linter): revert unmatched rule error (#7257)
- related to https://github.com/oxc-project/oxc/issues/6988 This is causing a lot of errors currently such as https://github.com/oxc-project/oxc/issues/7233. I think we need to handle rule names more robustly first: - https://github.com/oxc-project/oxc/issues/7240 - https://github.com/oxc-project/oxc/issues/7082 - https://github.com/oxc-project/oxc/discussions/7242 then, I think we can revisit this and maybe implement it as an actual lint plugin too? https://github.com/oxc-project/oxc/discussions/7086
This commit is contained in:
parent
c4ed230f8a
commit
df5c535dd0
3 changed files with 3 additions and 36 deletions
|
|
@ -244,9 +244,6 @@ mod test {
|
|||
let options = lint_command().run_inner(new_args.as_slice()).unwrap();
|
||||
match LintRunner::new(options).run() {
|
||||
CliRunResult::LintResult(lint_result) => lint_result,
|
||||
CliRunResult::LintError { error } => {
|
||||
panic!("{error}")
|
||||
}
|
||||
other => panic!("{other:?}"),
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -7,21 +7,10 @@ use std::{
|
|||
#[derive(Debug)]
|
||||
pub enum CliRunResult {
|
||||
None,
|
||||
InvalidOptions {
|
||||
message: String,
|
||||
},
|
||||
PathNotFound {
|
||||
paths: Vec<PathBuf>,
|
||||
},
|
||||
/// Indicates that there was an error trying to run the linter and it was
|
||||
/// not able to complete linting successfully.
|
||||
LintError {
|
||||
error: String,
|
||||
},
|
||||
InvalidOptions { message: String },
|
||||
PathNotFound { paths: Vec<PathBuf> },
|
||||
LintResult(LintResult),
|
||||
PrintConfigResult {
|
||||
config_file: String,
|
||||
},
|
||||
PrintConfigResult { config_file: String },
|
||||
}
|
||||
|
||||
/// A summary of a complete linter run.
|
||||
|
|
@ -58,10 +47,6 @@ impl Termination for CliRunResult {
|
|||
println!("Path {paths:?} does not exist.");
|
||||
ExitCode::from(1)
|
||||
}
|
||||
Self::LintError { error } => {
|
||||
eprintln!("Error: {error}");
|
||||
ExitCode::from(1)
|
||||
}
|
||||
Self::LintResult(LintResult {
|
||||
duration,
|
||||
number_of_rules,
|
||||
|
|
|
|||
|
|
@ -3,7 +3,6 @@ use std::{
|
|||
fmt,
|
||||
};
|
||||
|
||||
use oxc_diagnostics::{Error, OxcDiagnostic};
|
||||
use oxc_span::CompactStr;
|
||||
use rustc_hash::FxHashSet;
|
||||
|
||||
|
|
@ -102,20 +101,6 @@ impl LinterBuilder {
|
|||
oxlintrc_rules.override_rules(&mut builder.rules, all_rules.as_slice());
|
||||
}
|
||||
|
||||
#[expect(clippy::print_stderr)]
|
||||
if !oxlintrc_rules.unknown_rules.is_empty() {
|
||||
let rules = oxlintrc_rules
|
||||
.unknown_rules
|
||||
.iter()
|
||||
.map(|r| r.full_name())
|
||||
.collect::<Vec<_>>()
|
||||
.join("\n");
|
||||
let error = Error::from(OxcDiagnostic::warn(format!(
|
||||
"The following rules do not match the currently supported rules:\n{rules}"
|
||||
)));
|
||||
eprintln!("{error:?}");
|
||||
}
|
||||
|
||||
builder
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue