dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer): remove unreachable code from TS namespace transform (#3475)

Browse source 
As discussed in https://github.com/oxc-project/oxc/pull/3468#discussion_r1619782711, `export {x}` is not legal inside a TS namespace. So remove the code which handles this impossible case.
This commit is contained in:
overlookmotel 2024-05-30 21:56:30 +00:00
parent 0f4bcc0a68
commit deef86aff2
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/oxc_transformer/src/typescript/namespace.rs
View file

@ -227,6 +227,8 @@ impl<'a> TypeScript<'a> {
new_stmts.push(Statement::VariableDeclaration(decl));
}
Statement::ExportNamedDeclaration(export_decl) => {
// NB: `ExportNamedDeclaration` with no declaration (e.g. `export {x}`) is not
// legal syntax in TS namespaces
let export_decl = export_decl.unbox();
if let Some(decl) = export_decl.declaration {
if decl.modifiers().is_some_and(Modifiers::is_contains_declare) {
@ -294,13 +296,6 @@ impl<'a> TypeScript<'a> {
}
_ => {}
}
} else {
let stmt = self.ctx.ast.module_declaration(
ModuleDeclaration::ExportNamedDeclaration(
self.ctx.ast.alloc(export_decl),
),
);
new_stmts.push(stmt);
}
}
stmt => {