dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(minifier): keep return undefined in async generator function (#8439)

Browse source 
closes #8403
This commit is contained in:
Boshen 2025-01-12 02:02:15 +00:00
parent 43ed3e1722
commit dd643407dd
1 changed files with 26 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
crates/oxc_minifier/src/ast_passes/peephole_substitute_alternate_syntax.rs
View file

@ -2,6 +2,7 @@ use oxc_allocator::Vec;
use oxc_ast::{ast::*, NONE}; use oxc_ast::{ast::*, NONE};
use oxc_ecmascript::{ use oxc_ecmascript::{
constant_evaluation::{ConstantEvaluation, ValueType}, constant_evaluation::{ConstantEvaluation, ValueType},
side_effects::MayHaveSideEffects,
ToInt32, ToJsString, ToNumber, ToInt32, ToJsString, ToNumber,
}; };
use oxc_span::cmp::ContentEq; use oxc_span::cmp::ContentEq;
@ -636,10 +637,24 @@ impl<'a, 'b> PeepholeSubstituteAlternateSyntax {
stmt: &mut ReturnStatement<'a>, stmt: &mut ReturnStatement<'a>,
ctx: &mut TraverseCtx<'a>, ctx: &mut TraverseCtx<'a>,
) { ) {
if stmt.argument.as_ref().is_some_and(|expr| Ctx(ctx).is_expression_undefined(expr)) { let Some(argument) = &stmt.argument else { return };
stmt.argument = None; if !match argument {
self.changed = true; Expression::Identifier(ident) => Ctx(ctx).is_identifier_undefined(ident),
Expression::UnaryExpression(e) => e.operator.is_void() && !e.may_have_side_effects(),
_ => false,
} {
return;
} }
// `return undefined` has a different semantic in async generator function.
for ancestor in ctx.ancestors() {
if let Ancestor::FunctionBody(func) = ancestor {
if *func.r#async() && *func.generator() {
return;
}
}
}
stmt.argument = None;
self.changed = true;
} }
fn compress_variable_declarator( fn compress_variable_declarator(
@ -1252,9 +1267,16 @@ mod test {
test("function f(){return void 0;}", "function f(){return}"); test("function f(){return void 0;}", "function f(){return}");
test("function f(){return void foo();}", "function f(){return void foo()}"); test("function f(){return void foo();}", "function f(){return void foo()}");
test("function f(){return undefined;}", "function f(){return}"); test("function f(){return undefined;}", "function f(){return}");
// Here we handle the block in dce.
test("function f(){if(a()){return undefined;}}", "function f(){if(a()){return}}"); test("function f(){if(a()){return undefined;}}", "function f(){if(a()){return}}");
test_same("function a(undefined) { return undefined; }"); test_same("function a(undefined) { return undefined; }");
test_same("function f(){return foo()");
// `return undefined` has a different semantic in async generator function.
test("function foo() { return undefined }", "function foo() { return }");
test("function* foo() { return undefined }", "function* foo() { return }");
test("async function foo() { return undefined }", "async function foo() { return }");
test_same("async function* foo() { return void 0 }");
test_same("class Foo { async * foo() { return void 0 } }");
} }
#[test] #[test]