dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): fixer for eslint/for-direction (#4727)

Browse source
This commit is contained in:
heygsc 2024-08-07 20:42:51 +08:00 committed by GitHub
parent 17602db6de
commit db68a6c290
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
crates/oxc_linter/src/rules/eslint/for_direction.rs
View file

@ -70,13 +70,20 @@ impl Rule for ForDirection {
ctx.diagnostic_with_dangerous_fix(
for_direction_diagnostic(test.span, update_span),
|fixer| {
let mut start: u32 = 0;
let mut start = 0;
let mut end = 0;
if let Expression::UpdateExpression(update) = update {
start = update.argument.span().end;
if update.span().start == update.argument.span().start {
start = update.argument.span().end;
end = update.span().end;
} else {
start = update.span().start;
end = update.argument.span().start;
}
} else if let Expression::AssignmentExpression(update) = update {
start = update.left.span().end;
end = update.right.span().start;
}
let end = start + 2;
let span = Span::new(start, end);
let mut new_operator_str = "";
if let Expression::UpdateExpression(update) = update {
@ -260,6 +267,9 @@ fn test() {
("for(var i = 10; i > 0; i+=1){}", "for(var i = 10; i > 0; i-=1){}", None),
("for(var i = 0; i < 10; i+=-1){}", "for(var i = 0; i < 10; i-=-1){}", None),
("for(var i = 10; i > 0; i-=-1){}", "for(var i = 10; i > 0; i+=-1){}", None),
("for(var i = 0; i < 10; --i){}", "for(var i = 0; i < 10; ++i){}", None),
("for(var i = 0; i < 10; -- i){}", "for(var i = 0; i < 10; ++i){}", None),
("for(var i = 0; i < 10; i -= 1){}", "for(var i = 0; i < 10; i+=1){}", None),
// variables of different lengths
("for(var ii = 0; ii < 10; ii--){}", "for(var ii = 0; ii < 10; ii++){}", None),
("for(var ii = 10; ii > 0; ii+=1){}", "for(var ii = 10; ii > 0; ii-=1){}", None),