dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(linter/oxc): add fixer for double-comparisons (#5378)

Browse source
This commit is contained in:
camc314 2024-08-31 20:48:59 +00:00
parent ed31d67b51
commit db554447aa
1 changed files with 33 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
crates/oxc_linter/src/rules/oxc/double_comparisons.rs
View file

@ -39,6 +39,7 @@ declare_oxc_lint!(
/// ```
DoubleComparisons,
correctness,
fix
);
#[allow(clippy::similar_names)]
@ -84,7 +85,22 @@ impl Rule for DoubleComparisons {
_ => return,
};
ctx.diagnostic(double_comparisons_diagnostic(logical_expr.span, new_op));
ctx.diagnostic_with_fix(
double_comparisons_diagnostic(logical_expr.span, new_op),
|fixer| {
let modified_code = {
let mut codegen = fixer.codegen();
codegen.print_expression(llhs);
codegen.print_char(b' ');
codegen.print_str(new_op);
codegen.print_char(b' ');
codegen.print_expression(lrhs);
codegen.into_source_text()
};
fixer.replace(logical_expr.span, modified_code)
},
);
}
}
@ -127,5 +143,20 @@ fn test() {
"x > y || x === y",
];
Tester::new(DoubleComparisons::NAME, pass, fail).test_and_snapshot();
let fix = vec![
("x == y || x < y", "x <= y"),
("x < y || x == y", "x <= y"),
("x == y || x > y", "x >= y"),
("x > y || x == y", "x >= y"),
("x < y || x > y", "x != y"),
("x > y || x < y", "x != y"),
("x <= y && x >= y", "x == y"),
("x >= y && x <= y", "x == y"),
("x === y || x < y", "x <= y"),
("x < y || x === y", "x <= y"),
("x === y || x > y", "x >= y"),
("x > y || x === y", "x >= y"),
];
Tester::new(DoubleComparisons::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
}