refactor(clippy): allow clippy::too_many_lines

.cargo/config.toml

@@ -53,8 +53,9 @@ rustflags = [
 
   # This rule is too pedantic, I don't want to force this because naming things are hard.
   "-Aclippy::module_name_repetitions",
-  # Most usages are ignored in our codebase, so this is ignored.
+  # All triggers are mostly ignored in our codebase, so this is ignored globally.
   "-Aclippy::struct_excessive_bools",
+  "-Aclippy::too_many_lines",
 
   # #[must_use] is creating too much noise for this codebase, it does not add much value execept nagging
   # the programmer to add a #[must_use] after clippy has been run.

crates/oxc_ast/src/ast_kind.rs

@@ -239,7 +239,7 @@ impl<'a> AstKind<'a> {
 }
 
 impl<'a> GetSpan for AstKind<'a> {
-    #[allow(clippy::match_same_arms, clippy::too_many_lines)]
+    #[allow(clippy::match_same_arms)]
     fn span(&self) -> Span {
         match self {
             Self::Program(x) => x.span,
@@ -386,7 +386,7 @@ impl<'a> GetSpan for AstKind<'a> {
 
 #[cfg(debug_assertions)]
 impl<'a> AstKind<'a> {
-    #[allow(clippy::match_same_arms, clippy::too_many_lines)]
+    #[allow(clippy::match_same_arms)]
     /// Get the AST kind name with minimal details. Particularly useful for
     /// when debugging an iteration over an AST.
     ///

crates/oxc_linter/src/rules/eslint/array_callback_return/mod.rs

@@ -251,7 +251,6 @@ fn full_array_method_name(array_method: &'static str) -> Atom {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/eslint/getter_return.rs

@@ -192,7 +192,6 @@ impl Rule for GetterReturn {
     }
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/eslint/no_constant_binary_expression.rs

@@ -377,7 +377,6 @@ impl NoConstantBinaryExpression {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/eslint/no_constant_condition.rs

@@ -68,7 +68,6 @@ impl Rule for NoConstantCondition {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/eslint/no_duplicate_case.rs

@@ -64,7 +64,6 @@ impl Rule for NoDuplicateCase {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/eslint/no_extra_boolean_cast.rs

@@ -204,7 +204,6 @@ fn get_real_parent<'a, 'b>(node: &AstNode, ctx: &'a LintContext<'b>) -> Option<&
     None
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/eslint/no_loss_of_precision.rs

@@ -239,7 +239,6 @@ impl NoLossOfPrecision {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/eslint/no_return_await.rs

@@ -143,7 +143,6 @@ fn has_error_handler<'a>(node: &AstNode<'a>, ctx: &LintContext<'a>) -> bool {
     false
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/eslint/no_setter_return.rs

@@ -48,7 +48,6 @@ impl Rule for NoSetterReturn {
     }
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/eslint/no_useless_catch.rs

@@ -71,7 +71,6 @@ impl Rule for NoUselessCatch {
     }
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/eslint/no_useless_escape.rs

@@ -195,7 +195,6 @@ fn check_template(string: &str) -> Vec<usize> {
     offsets
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/eslint/use_isnan.rs

@@ -163,7 +163,6 @@ fn is_target_callee<'a>(callee: &'a Expression<'a>) -> Option<&'static str> {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/eslint/valid_typeof.rs

@@ -140,7 +140,6 @@ const VALID_TYPES: Set<&'static str> = phf_set! {
 };
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/jest/expect_expect.rs

@@ -201,7 +201,6 @@ fn convert_pattern(pattern: &str) -> String {
     format!("(?ui)^{pattern}(\\.|$)")
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/jest/no_conditional_expect.rs

@@ -118,7 +118,6 @@ fn check_parents<'a>(node: &AstNode<'a>, ctx: &LintContext<'a>, in_conditional:
     check_parents(parent, ctx, in_conditional)
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/jest/no_confusing_set_timeout.rs

@@ -237,7 +237,6 @@ fn is_jest_call(name: &Atom) -> bool {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/jest/no_done_callback.rs

@@ -196,7 +196,6 @@ impl Message {
     }
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/jest/no_identical_title.rs

@@ -180,7 +180,6 @@ impl Message {
     }
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/jest/no_standalone_expect.rs

@@ -185,7 +185,6 @@ fn is_var_declarator_or_test_block<'a>(
     false
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/jest/valid_describe_callback.rs

@@ -183,7 +183,6 @@ impl Message {
     }
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/jest/valid_expect.rs

@@ -372,7 +372,6 @@ fn test_1() {
     Tester::new(ValidExpect::NAME, pass, fail).test_and_snapshot();
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/jest/valid_title.rs

@@ -362,7 +362,6 @@ impl Message {
     }
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/typescript/adjacent_overload_signatures.rs

@@ -322,7 +322,6 @@ impl Rule for AdjacentOverloadSignatures {
     }
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/typescript/ban_ts_comment.rs

@@ -206,7 +206,6 @@ pub fn find_ts_comment_directive(raw: &str, single_line: bool) -> Option<(&str,
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/typescript/ban_types.rs

@@ -87,7 +87,6 @@ impl Rule for BanTypes {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/typescript/no_duplicate_enum_values.rs

@@ -68,7 +68,6 @@ impl Rule for NoDuplicateEnumValues {
     }
 }
 
-#[allow(clippy::too_many_lines)]
 #[test]
 fn test() {
     use crate::tester::Tester;

crates/oxc_linter/src/rules/typescript/no_explicit_any.rs

@@ -135,7 +135,6 @@ mod tests {
         Tester::new_without_config(NoExplicitAny::NAME, pass, fail).test();
     }
 
-    #[allow(clippy::too_many_lines)]
     #[test]
     fn test() {
         let pass = vec![

crates/oxc_linter/src/rules/typescript/no_namespace.rs

@@ -103,7 +103,6 @@ fn is_declaration(node: &AstNode, ctx: &LintContext) -> bool {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/unicorn/no_console_spaces.rs

@@ -143,7 +143,6 @@ fn report_diagnostic(
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/unicorn/no_thenable.rs

@@ -57,7 +57,6 @@ declare_oxc_lint!(
 );
 
 impl Rule for NoThenable {
-    #[allow(clippy::too_many_lines)]
     fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
         match node.kind() {
             AstKind::ObjectExpression(expr) => {
@@ -281,7 +280,6 @@ fn contains_then(key: &PropertyKey, ctx: &LintContext) -> Option<Span> {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_linter/src/rules/unicorn/prefer_array_flat_map.rs

@@ -89,7 +89,6 @@ impl Rule for PreferArrayFlatMap {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test() {
     use crate::tester::Tester;
 

crates/oxc_macros/src/declare_all_lint_rules/mod.rs

@@ -40,7 +40,7 @@ impl Parse for AllLintRulesMeta {
     }
 }
 
-#[allow(clippy::cognitive_complexity, clippy::too_many_lines)]
+#[allow(clippy::cognitive_complexity)]
 pub fn declare_all_lint_rules(metadata: AllLintRulesMeta) -> TokenStream {
     let AllLintRulesMeta { rules } = metadata;
     // all the top-level module trees

crates/oxc_minifier/src/compressor/fold.rs

@@ -595,7 +595,6 @@ impl<'a> Compressor<'a> {
         None
     }
 
-    #[allow(clippy::too_many_lines)]
     fn try_fold_unary_operator(
         &mut self,
         unary_expr: &UnaryExpression<'a>,

crates/oxc_minifier/tests/mod.rs

@@ -1,5 +1,3 @@
-#![allow(clippy::too_many_lines)]
-
 mod closure;
 mod esbuild;
 mod oxc;

crates/oxc_parser/src/js/class.rs

@@ -159,7 +159,6 @@ impl<'a> Parser<'a> {
         Ok(self.ast.class_body(self.end_span(span), body))
     }
 
-    #[allow(clippy::too_many_lines)]
     pub(crate) fn parse_class_element(&mut self) -> Result<ClassElement<'a>> {
         let span = self.start_span();
 

crates/oxc_parser/src/lexer/kind.rs

@@ -478,7 +478,6 @@ impl Kind {
         }
     }
 
-    #[allow(clippy::too_many_lines)]
     pub fn to_str(self) -> &'static str {
         match self {
             Undetermined => "Unknown",

crates/oxc_query/src/adapter.rs

@@ -59,7 +59,6 @@ impl<'a, 'b: 'a> trustfall::provider::Adapter<'a> for &'a Adapter<'b> {
         }
     }
 
-    #[allow(clippy::too_many_lines)]
     fn resolve_property(
         &self,
         contexts: ContextIterator<'a, Self::Vertex>,
@@ -301,7 +300,6 @@ impl<'a, 'b: 'a> trustfall::provider::Adapter<'a> for &'a Adapter<'b> {
         }
     }
 
-    #[allow(clippy::too_many_lines)]
     fn resolve_neighbors(
         &self,
         contexts: ContextIterator<'a, Self::Vertex>,

crates/oxc_query/src/vertex.rs

@@ -442,7 +442,6 @@ impl Typename for Vertex<'_> {
     }
 }
 
-#[allow(clippy::too_many_lines)]
 impl<'a> From<AstNode<'a>> for Vertex<'a> {
     fn from(ast_node: AstNode<'a>) -> Self {
         match ast_node.kind() {

crates/oxc_resolver/src/tests/imports_field.rs

@@ -84,7 +84,6 @@ fn imports_field(value: serde_json::Value) -> MatchObject {
 }
 
 #[test]
-#[allow(clippy::too_many_lines)]
 fn test_cases() {
     let test_cases = [
         TestCase {