refactor(semantic): call with_trivias before build_with_jsdoc (#5875)

crates/oxc_linter/src/service.rs

@@ -313,8 +313,8 @@ impl Runtime {
         // The semantic model is not built at this stage.
         let semantic_builder = SemanticBuilder::new(source_text)
             .with_cfg(true)
-            .with_build_jsdoc(true)
             .with_trivias(trivias)
+            .with_build_jsdoc(true)
             .with_check_syntax_error(check_syntax_errors)
             .build_module_record(path, program);
         let module_record = semantic_builder.module_record();

crates/oxc_semantic/src/builder.rs

@@ -157,8 +157,7 @@ impl<'a> SemanticBuilder<'a> {
 
     #[must_use]
     pub fn with_trivias(mut self, trivias: Trivias) -> Self {
-        self.trivias = trivias.clone();
-        self.jsdoc = JSDocBuilder::new(self.source_text, trivias);
+        self.trivias = trivias;
         self
     }
 
@@ -176,8 +175,10 @@ impl<'a> SemanticBuilder<'a> {
     }
 
     /// Enable/disable JSDoc parsing.
+    /// `with_trivias` must be called prior to this call.
     #[must_use]
     pub fn with_build_jsdoc(mut self, yes: bool) -> Self {
+        self.jsdoc = JSDocBuilder::new(self.source_text, self.trivias.clone());
         self.build_jsdoc = yes;
         self
     }

crates/oxc_semantic/src/module_record/mod.rs

@@ -20,7 +20,6 @@ mod module_record_tests {
         let ret = Parser::new(&allocator, source_text, source_type).parse();
         let program = allocator.alloc(ret.program);
         let semantic_ret = SemanticBuilder::new(source_text)
-            .with_trivias(ret.trivias)
             .build_module_record(Path::new(""), program)
             .build(program);
         Arc::clone(&semantic_ret.semantic.module_record)

tasks/benchmark/benches/linter.rs

@@ -30,6 +30,7 @@ fn bench_linter(criterion: &mut Criterion) {
                 let program = allocator.alloc(ret.program);
                 let semantic_ret = SemanticBuilder::new(source_text)
                     .with_trivias(ret.trivias)
+                    .with_build_jsdoc(true)
                     .with_cfg(true)
                     .build_module_record(Path::new(""), program)
                     .build(program);