From dafdc95d81070ce2513588618435a58bd9bbae34 Mon Sep 17 00:00:00 2001 From: Boshen Date: Mon, 21 Aug 2023 11:41:12 +0800 Subject: [PATCH] chore(linter): add rule name to no-instanceof-array --- .../src/rules/unicorn/no_instanceof_array.rs | 2 +- .../src/snapshots/no_instanceof_array.snap | 17 ++++++++--------- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/crates/oxc_linter/src/rules/unicorn/no_instanceof_array.rs b/crates/oxc_linter/src/rules/unicorn/no_instanceof_array.rs index c5f7cb95c..9119a1fee 100644 --- a/crates/oxc_linter/src/rules/unicorn/no_instanceof_array.rs +++ b/crates/oxc_linter/src/rules/unicorn/no_instanceof_array.rs @@ -12,7 +12,7 @@ use oxc_syntax::operator::BinaryOperator; use crate::{context::LintContext, fixer::Fix, rule::Rule, AstNode}; #[derive(Debug, Error, Diagnostic)] -#[error("Use `Array.isArray()` instead of `instanceof Array`.")] +#[error("eslint-plugin-unicorn(no-instanceof-array): Use `Array.isArray()` instead of `instanceof Array`.")] #[diagnostic(severity(warning), help("The instanceof Array check doesn't work across realms/contexts, for example, frames/windows in browsers or the vm module in Node.js."))] struct NoInstanceofArrayDiagnostic(#[label] pub Span); diff --git a/crates/oxc_linter/src/snapshots/no_instanceof_array.snap b/crates/oxc_linter/src/snapshots/no_instanceof_array.snap index c5599c7ba..fd494e166 100644 --- a/crates/oxc_linter/src/snapshots/no_instanceof_array.snap +++ b/crates/oxc_linter/src/snapshots/no_instanceof_array.snap @@ -1,58 +1,57 @@ --- source: crates/oxc_linter/src/tester.rs -assertion_line: 80 expression: no_instanceof_array --- - ⚠ Use `Array.isArray()` instead of `instanceof Array`. + ⚠ eslint-plugin-unicorn(no-instanceof-array): Use `Array.isArray()` instead of `instanceof Array`. ╭─[no_instanceof_array.tsx:1:1] 1 │ arr instanceof Array · ──────────────────── ╰──── help: The instanceof Array check doesn't work across realms/contexts, for example, frames/windows in browsers or the vm module in Node.js. - ⚠ Use `Array.isArray()` instead of `instanceof Array`. + ⚠ eslint-plugin-unicorn(no-instanceof-array): Use `Array.isArray()` instead of `instanceof Array`. ╭─[no_instanceof_array.tsx:1:1] 1 │ [] instanceof Array · ─────────────────── ╰──── help: The instanceof Array check doesn't work across realms/contexts, for example, frames/windows in browsers or the vm module in Node.js. - ⚠ Use `Array.isArray()` instead of `instanceof Array`. + ⚠ eslint-plugin-unicorn(no-instanceof-array): Use `Array.isArray()` instead of `instanceof Array`. ╭─[no_instanceof_array.tsx:1:1] 1 │ [1,2,3] instanceof Array === true · ──────────────────────── ╰──── help: The instanceof Array check doesn't work across realms/contexts, for example, frames/windows in browsers or the vm module in Node.js. - ⚠ Use `Array.isArray()` instead of `instanceof Array`. + ⚠ eslint-plugin-unicorn(no-instanceof-array): Use `Array.isArray()` instead of `instanceof Array`. ╭─[no_instanceof_array.tsx:1:1] 1 │ fun.call(1, 2, 3) instanceof Array · ────────────────────────────────── ╰──── help: The instanceof Array check doesn't work across realms/contexts, for example, frames/windows in browsers or the vm module in Node.js. - ⚠ Use `Array.isArray()` instead of `instanceof Array`. + ⚠ eslint-plugin-unicorn(no-instanceof-array): Use `Array.isArray()` instead of `instanceof Array`. ╭─[no_instanceof_array.tsx:1:1] 1 │ obj.arr instanceof Array · ──────────────────────── ╰──── help: The instanceof Array check doesn't work across realms/contexts, for example, frames/windows in browsers or the vm module in Node.js. - ⚠ Use `Array.isArray()` instead of `instanceof Array`. + ⚠ eslint-plugin-unicorn(no-instanceof-array): Use `Array.isArray()` instead of `instanceof Array`. ╭─[no_instanceof_array.tsx:1:1] 1 │ foo.bar[2] instanceof Array · ─────────────────────────── ╰──── help: The instanceof Array check doesn't work across realms/contexts, for example, frames/windows in browsers or the vm module in Node.js. - ⚠ Use `Array.isArray()` instead of `instanceof Array`. + ⚠ eslint-plugin-unicorn(no-instanceof-array): Use `Array.isArray()` instead of `instanceof Array`. ╭─[no_instanceof_array.tsx:1:1] 1 │ (0, array) instanceof Array · ─────────────────────────── ╰──── help: The instanceof Array check doesn't work across realms/contexts, for example, frames/windows in browsers or the vm module in Node.js. - ⚠ Use `Array.isArray()` instead of `instanceof Array`. + ⚠ eslint-plugin-unicorn(no-instanceof-array): Use `Array.isArray()` instead of `instanceof Array`. ╭─[no_instanceof_array.tsx:1:1] 1 │ function foo(){return [] instanceof Array} · ───────────────────