From d9ca086eb688ed06a1cc7a6b45085e7b3bc4dd2b Mon Sep 17 00:00:00 2001 From: Cameron Date: Tue, 9 Jan 2024 03:35:34 +0000 Subject: [PATCH] feat(linter) add support for custom filenames in tests (#1955) --- .../src/rules/jsx_a11y/aria_role.rs | 75 ++++++------ .../src/rules/jsx_a11y/html_has_lang.rs | 24 ++-- crates/oxc_linter/src/rules/jsx_a11y/lang.rs | 38 +++--- .../src/rules/jsx_a11y/media_has_caption.rs | 110 +++++++++--------- .../src/rules/jsx_a11y/no_autofocus.rs | 38 +++--- .../rules/jsx_a11y/no_distracting_elements.rs | 26 ++--- .../src/rules/unicorn/filename_case.rs | 21 ++++ .../src/snapshots/filename_case.snap | 17 +++ crates/oxc_linter/src/tester.rs | 43 ++++--- 9 files changed, 222 insertions(+), 170 deletions(-) create mode 100644 crates/oxc_linter/src/snapshots/filename_case.snap diff --git a/crates/oxc_linter/src/rules/jsx_a11y/aria_role.rs b/crates/oxc_linter/src/rules/jsx_a11y/aria_role.rs index 4fe69ce51..fc7f1cede 100644 --- a/crates/oxc_linter/src/rules/jsx_a11y/aria_role.rs +++ b/crates/oxc_linter/src/rules/jsx_a11y/aria_role.rs @@ -192,44 +192,49 @@ fn test() { } let pass = vec![ - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("", None, None), - ("", Some(allowed_invalid_roles()), None), - ("", Some(allowed_invalid_roles()), None), - ("", Some(allowed_invalid_roles()), None), - ("", Some(ignore_non_dom_schema()), None), - ("", Some(ignore_non_dom_schema()), None), - ("", Some(ignore_non_dom_schema()), None), - ("
", None, Some(settings())), - ("", None, Some(settings())), - ("", None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("", None, None, None), + ("", Some(allowed_invalid_roles()), None, None), + ("", Some(allowed_invalid_roles()), None, None), + ( + "", + Some(allowed_invalid_roles()), + None, + None, + ), + ("", Some(ignore_non_dom_schema()), None, None), + ("", Some(ignore_non_dom_schema()), None, None), + ("", Some(ignore_non_dom_schema()), None, None), + ("
", None, Some(settings()), None), + ("", None, Some(settings()), None), + ("", None, None, None), ]; let fail = vec![ - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", None, None), - ("
", Some(allowed_invalid_roles()), None), - ("
", None, None), - ("", None, None), - ("", None, None), - ("
", None, Some(settings())), - ("
", Some(ignore_non_dom_schema()), Some(settings())), - ("", None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", None, None, None), + ("
", Some(allowed_invalid_roles()), None, None), + ("
", None, None, None), + ("", None, None, None), + ("", None, None, None), + ("
", None, Some(settings()), None), + ("
", Some(ignore_non_dom_schema()), Some(settings()), None), + ("", None, None, None), ]; Tester::new_with_settings(AriaRole::NAME, pass, fail).test_and_snapshot(); diff --git a/crates/oxc_linter/src/rules/jsx_a11y/html_has_lang.rs b/crates/oxc_linter/src/rules/jsx_a11y/html_has_lang.rs index c4f279c1f..461b1ff54 100644 --- a/crates/oxc_linter/src/rules/jsx_a11y/html_has_lang.rs +++ b/crates/oxc_linter/src/rules/jsx_a11y/html_has_lang.rs @@ -111,21 +111,21 @@ fn test() { } let pass = vec![ - (r"
;", None, None), - (r#""#, None, None), - (r#""#, None, None), - (r";", None, None), - (r";", None, None), - (r";", None, None), - ("", None, Some(settings())), + (r"
;", None, None, None), + (r#""#, None, None, None), + (r#""#, None, None, None), + (r";", None, None, None), + (r";", None, None, None), + (r";", None, None, None), + ("", None, Some(settings()), None), ]; let fail = vec![ - (r";", None, None), - (r";", None, None), - (r";", None, None), - (r#";"#, None, None), - ("", None, Some(settings())), + (r";", None, None, None), + (r";", None, None, None), + (r";", None, None, None), + (r#";"#, None, None, None), + ("", None, Some(settings()), None), ]; Tester::new_with_settings(HtmlHasLang::NAME, pass, fail) diff --git a/crates/oxc_linter/src/rules/jsx_a11y/lang.rs b/crates/oxc_linter/src/rules/jsx_a11y/lang.rs index 4cc5f4f62..e3ea2adae 100644 --- a/crates/oxc_linter/src/rules/jsx_a11y/lang.rs +++ b/crates/oxc_linter/src/rules/jsx_a11y/lang.rs @@ -122,28 +122,28 @@ fn test() { } let pass = vec![ - ("
;", None, None), - ("
;", None, None), - ("
;", None, None), - ("", None, None), - ("", None, None), - ("", None, None), - ("", None, None), - ("", None, None), - ("", None, None), - ("", None, None), - ("", None, None), - ("", None, None), - ("", None, Some(settings())), - ("", None, Some(settings())), + ("
;", None, None, None), + ("
;", None, None, None), + ("
;", None, None, None), + ("", None, None, None), + ("", None, None, None), + ("", None, None, None), + ("", None, None, None), + ("", None, None, None), + ("", None, None, None), + ("", None, None, None), + ("", None, None, None), + ("", None, None, None), + ("", None, Some(settings()), None), + ("", None, Some(settings()), None), ]; let fail = vec![ - ("", None, None), - ("", None, None), - ("", None, None), - ("", None, Some(settings())), - ("", None, Some(settings())), + ("", None, None, None), + ("", None, None, None), + ("", None, None, None), + ("", None, Some(settings()), None), + ("", None, Some(settings()), None), ]; Tester::new_with_settings(Lang::NAME, pass, fail).test_and_snapshot(); diff --git a/crates/oxc_linter/src/rules/jsx_a11y/media_has_caption.rs b/crates/oxc_linter/src/rules/jsx_a11y/media_has_caption.rs index 642bc8c5a..d6f642f92 100644 --- a/crates/oxc_linter/src/rules/jsx_a11y/media_has_caption.rs +++ b/crates/oxc_linter/src/rules/jsx_a11y/media_has_caption.rs @@ -200,64 +200,64 @@ fn test() { } let pass = vec![ - (r"
;", None, None), - (r";", None, None), - (r"", None, None), - (r"", None, None), - (r"", None, None), - (r"", None, None), - (r"", None, None), - (r"", None, None), - (r"", None, None), - (r"", None, None), - (r"", None, None), - (r"", Some(config()), None), - (r"", Some(config()), None), - (r"", Some(config()), None), - (r"", Some(config()), None), - (r"", Some(config()), None), - (r"", Some(config()), None), - (r"", Some(config()), None), - (r"", Some(config()), None), - (r"", Some(config()), None), - (r"", Some(config()), None), - (r"", None, Some(settings())), - (r"", None, Some(settings())), - (r"", None, Some(settings())), - (r"", None, Some(settings())), - (r"", None, Some(settings())), - (r"", None, Some(settings())), - (r"", None, Some(settings())), - (r"", None, Some(settings())), - (r"", None, Some(settings())), - (r"", None, Some(settings())), - (r"", None, Some(settings())), + (r"
;", None, None, None), + (r";", None, None, None), + (r"", None, None, None), + (r"", None, None, None), + (r"", None, None, None), + (r"", None, None, None), + (r"", None, None, None), + (r"", None, None, None), + (r"", None, None, None), + (r"", None, None, None), + (r"", None, None, None), + (r"", Some(config()), None, None), + (r"", Some(config()), None, None), + (r"", Some(config()), None, None), + (r"", Some(config()), None, None), + (r"", Some(config()), None, None), + (r"", Some(config()), None, None), + (r"", Some(config()), None, None), + (r"", Some(config()), None, None), + (r"", Some(config()), None, None), + (r"", Some(config()), None, None), + (r"", None, Some(settings()), None), + (r"", None, Some(settings()), None), + (r"", None, Some(settings()), None), + (r"", None, Some(settings()), None), + (r"", None, Some(settings()), None), + (r"", None, Some(settings()), None), + (r"", None, Some(settings()), None), + (r"", None, Some(settings()), None), + (r"", None, Some(settings()), None), + (r"", None, Some(settings()), None), + (r"", None, Some(settings()), None), ]; let fail = vec![ - (r"", None, None), - (r"", None, None), - (r"