dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(minifier): Unknown.fromCharCode should not be treated as String.fromCharCode (#8709)

Browse source
This commit is contained in:
sapphi-red 2025-01-25 10:56:09 +00:00
parent bf895eb90d
commit d982cdba85
No known key found for this signature in database
GPG key ID: 67631A259A77AC6C
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_minifier/src/peephole/replace_known_methods.rs
View file

@ -245,7 +245,7 @@ impl<'a> PeepholeOptimizations {
) -> Option<Expression<'a>> {
let Expression::Identifier(ident) = object else { return None };
let ctx = Ctx(ctx);
if !ctx.is_global_reference(ident) {
if ident.name != "String" || !ctx.is_global_reference(ident) {
return None;
}
let args = &ce.arguments;
@ -1422,6 +1422,8 @@ mod test {
test_same("String.fromCharCode(x)");
test("x = String.fromCharCode('x')", "x = '\\0'");
test("x = String.fromCharCode('0.5')", "x = '\\0'");
test_same("x = Unknown.fromCharCode('0.5')");
}
#[test]