dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(codegen): do not check for comments if turned off (#8598)

Browse source
This commit is contained in:
Boshen 2025-01-19 09:07:24 +00:00
parent 8cce69a602
commit d966e0adda
1 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
crates/oxc_codegen/src/gen.rs
View file

@ -1447,10 +1447,12 @@ impl GenExpr for CallExpression<'_> {
type_parameters.print(p, ctx); type_parameters.print(p, ctx);
} }
p.print_ascii_byte(b'('); p.print_ascii_byte(b'(');
let print_comments = p.options.print_comments();
let has_comment_before_right_paren = let has_comment_before_right_paren =
self.span.end > 0 && p.has_comment(self.span.end - 1); print_comments && self.span.end > 0 && p.has_comment(self.span.end - 1);
let has_comment = has_comment_before_right_paren let has_comment = print_comments
|| self.arguments.iter().any(|item| p.has_comment(item.span().start)); && (has_comment_before_right_paren
|| self.arguments.iter().any(|item| p.has_comment(item.span().start)));
if has_comment { if has_comment {
p.indent(); p.indent();
p.print_list_with_comments(&self.arguments, ctx); p.print_list_with_comments(&self.arguments, ctx);
@ -2075,10 +2077,17 @@ impl GenExpr for SequenceExpression<'_> {
impl GenExpr for ImportExpression<'_> { impl GenExpr for ImportExpression<'_> {
fn gen_expr(&self, p: &mut Codegen, precedence: Precedence, ctx: Context) { fn gen_expr(&self, p: &mut Codegen, precedence: Precedence, ctx: Context) {
let wrap = precedence >= Precedence::New || ctx.intersects(Context::FORBID_CALL); let wrap = precedence >= Precedence::New || ctx.intersects(Context::FORBID_CALL);
let has_comment_before_right_paren = self.span.end > 0 && p.has_comment(self.span.end - 1);
let has_comment = has_comment_before_right_paren let print_comments = p.options.print_comments();
let has_comment_before_right_paren =
print_comments && self.span.end > 0 && p.has_comment(self.span.end - 1);
let has_comment = print_comments
&& (has_comment_before_right_paren
|| p.has_comment(self.source.span().start) || p.has_comment(self.source.span().start)
|| self.arguments.first().is_some_and(|argument| p.has_comment(argument.span().start)); || self
.arguments
.first()
.is_some_and(|argument| p.has_comment(argument.span().start)));
p.wrap(wrap, |p| { p.wrap(wrap, |p| {
p.print_space_before_identifier(); p.print_space_before_identifier();