dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(semantic): remove record_ast_node call for Program (#5701)

Browse source 
Remove a tiny bit of dead code from `SemanticBuilder`.

`record_ast_node` does nothing if `ast_node_records` is empty. It is always empty when visiting `Program`, so is a no-op.
This commit is contained in:
overlookmotel 2024-09-11 11:31:20 +00:00
parent 1857ff09eb
commit d8ec78192e
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
crates/oxc_semantic/src/builder.rs
View file

@ -606,15 +606,14 @@ impl<'a> Visit<'a> for SemanticBuilder<'a> {
// Don't call `enter_node` here as `Program` is a special case - node has no `parent_id`.
// Inline the specific logic for `Program` here instead.
// This avoids `Nodes::add_node` having to handle the special case.
// We can also skip calling `self.enter_kind`, and `self.jsdoc.retrieve_attached_jsdoc`
// as they are no-ops for `Program`.
// We can also skip calling `self.enter_kind`, `self.record_ast_node`
// and `self.jsdoc.retrieve_attached_jsdoc`, as they are all no-ops for `Program`.
self.current_node_id = self.nodes.add_program_node(
kind,
self.current_scope_id,
control_flow!(self, |cfg| cfg.current_node_ix),
self.current_node_flags,
);
self.record_ast_node();
// Don't call `enter_scope` here as `Program` is a special case - scope has no `parent_id`.
// Inline the specific logic for `Program` here instead.