dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(oxc_linter): prefer pass Enum instead of str no_plus_plus (#5730)

Browse source 
1. remove redundant branch.
This commit is contained in:
IWANABETHATGUY 2024-09-12 23:43:24 +08:00 committed by GitHub
parent 6436524ff1
commit d8b612c038
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
crates/oxc_linter/src/rules/eslint/no_plusplus.rs
View file

@ -1,21 +1,25 @@
use oxc_ast::AstKind;
use oxc_ast::{ast::UpdateOperator, AstKind};
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::Span;
use crate::{context::LintContext, rule::Rule, AstNode};
fn no_plusplus_diagnostic(span: Span, operator: &str) -> OxcDiagnostic {
let diagnostic =
OxcDiagnostic::warn(format!("Unary operator '{operator}' used.")).with_label(span);
fn no_plusplus_diagnostic(span: Span, operator: UpdateOperator) -> OxcDiagnostic {
let diagnostic = OxcDiagnostic::warn(format!(
"Unary operator '{operator}' used.",
operator = operator.as_str()
))
.with_label(span);
if operator == "++" {
return diagnostic.with_help("Use the assignment operator `+=` instead.");
} else if operator == "--" {
return diagnostic.with_help("Use the assignment operator `-=` instead.");
match operator {
UpdateOperator::Increment => {
diagnostic.with_help("Use the assignment operator `+=` instead.")
}
UpdateOperator::Decrement => {
diagnostic.with_help("Use the assignment operator `-=` instead.")
}
}
diagnostic
}
#[derive(Debug, Default, Clone)]
@ -98,7 +102,7 @@ impl Rule for NoPlusplus {
return;
}
ctx.diagnostic(no_plusplus_diagnostic(expr.span, expr.operator.as_str()));
ctx.diagnostic(no_plusplus_diagnostic(expr.span, expr.operator));
}
}