dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(linter): use CompactStr in prefer-lowercase-title (#6405)

Browse source
This commit is contained in:
camchenry 2024-10-10 02:45:23 +00:00
parent 889400c77d
commit d66e826136
1 changed files with 8 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
crates/oxc_linter/src/rules/jest/prefer_lowercase_title.rs
View file

@ -1,7 +1,7 @@
use oxc_ast::{ast::Argument, AstKind}; use oxc_ast::{ast::Argument, AstKind};
use oxc_diagnostics::OxcDiagnostic; use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint; use oxc_macros::declare_oxc_lint;
use oxc_span::Span; use oxc_span::{CompactStr, Span};
use crate::{ use crate::{
context::LintContext, context::LintContext,
@ -20,8 +20,8 @@ fn unexpected_lowercase(x0: &str, span1: Span) -> OxcDiagnostic {
#[derive(Debug, Default, Clone)] #[derive(Debug, Default, Clone)]
pub struct PreferLowercaseTitleConfig { pub struct PreferLowercaseTitleConfig {
allowed_prefixes: Vec<String>, allowed_prefixes: Vec<CompactStr>,
ignore: Vec<String>, ignore: Vec<CompactStr>,
ignore_top_level_describe: bool, ignore_top_level_describe: bool,
} }
@ -142,16 +142,12 @@ impl Rule for PreferLowercaseTitle {
let ignore = obj let ignore = obj
.and_then(|config| config.get("ignore")) .and_then(|config| config.get("ignore"))
.and_then(serde_json::Value::as_array) .and_then(serde_json::Value::as_array)
.map(|v| { .map(|v| v.iter().filter_map(serde_json::Value::as_str).map(CompactStr::from).collect())
v.iter().filter_map(serde_json::Value::as_str).map(ToString::to_string).collect()
})
.unwrap_or_default(); .unwrap_or_default();
let allowed_prefixes = obj let allowed_prefixes = obj
.and_then(|config| config.get("allowedPrefixes")) .and_then(|config| config.get("allowedPrefixes"))
.and_then(serde_json::Value::as_array) .and_then(serde_json::Value::as_array)
.map(|v| { .map(|v| v.iter().filter_map(serde_json::Value::as_str).map(CompactStr::from).collect())
v.iter().filter_map(serde_json::Value::as_str).map(ToString::to_string).collect()
})
.unwrap_or_default(); .unwrap_or_default();
Self(Box::new(PreferLowercaseTitleConfig { Self(Box::new(PreferLowercaseTitleConfig {
@ -209,7 +205,7 @@ impl PreferLowercaseTitle {
} }
} }
fn populate_ignores(ignore: &[String]) -> Vec<&str> { fn populate_ignores(ignore: &[CompactStr]) -> Vec<&str> {
let mut ignores: Vec<&str> = vec![]; let mut ignores: Vec<&str> = vec![];
let test_case_name = ["fit", "it", "xit", "test", "xtest"]; let test_case_name = ["fit", "it", "xit", "test", "xtest"];
let describe_alias = ["describe", "fdescribe", "xdescribe"]; let describe_alias = ["describe", "fdescribe", "xdescribe"];
@ -232,7 +228,8 @@ impl PreferLowercaseTitle {
} }
fn lint_string<'a>(&self, ctx: &LintContext<'a>, literal: &'a str, span: Span) { fn lint_string<'a>(&self, ctx: &LintContext<'a>, literal: &'a str, span: Span) {
if literal.is_empty() || self.allowed_prefixes.iter().any(|name| literal.starts_with(name)) if literal.is_empty()
|| self.allowed_prefixes.iter().any(|name| literal.starts_with(name.as_str()))
{ {
return; return;
} }