From d63d07a05075cf06b508aef8cac7ce328960d241 Mon Sep 17 00:00:00 2001 From: IWANABETHATGUY <974153916@qq.com> Date: Sun, 17 Sep 2023 19:58:10 +0800 Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=A4=96=20refactor=20crates/oxc?= =?UTF-8?q?=5Ftransformer/src/es2021/logical=5Fassignment=5Foperators.rs?= =?UTF-8?q?=20and=20fix=20typo=20(#927)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. Fixing typo. 2. Making the code more expresisonful. --- .../src/es2021/logical_assignment_operators.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/crates/oxc_transformer/src/es2021/logical_assignment_operators.rs b/crates/oxc_transformer/src/es2021/logical_assignment_operators.rs index 51972f71a..34301daf6 100644 --- a/crates/oxc_transformer/src/es2021/logical_assignment_operators.rs +++ b/crates/oxc_transformer/src/es2021/logical_assignment_operators.rs @@ -28,19 +28,18 @@ impl<'a> LogicalAssignmentOperators<'a> { _ => return, }; - // Create the left hand sife + // Create the left hand side // a || (a = b) // ^ ^ let left1: AssignmentTarget<'a> = self.ast.copy(&assignment_expr.left); - let left2; - match &assignment_expr.left { + let left2 = match &assignment_expr.left { AssignmentTarget::SimpleAssignmentTarget(target) => match target { SimpleAssignmentTarget::AssignmentTargetIdentifier(ident) => { - left2 = self.ast.identifier_expression((*ident).clone()); + self.ast.identifier_expression((*ident).clone()) } SimpleAssignmentTarget::MemberAssignmentTarget(member_expr) => { let member_expr = self.ast.copy(&**member_expr); - left2 = self.ast.member_expression(member_expr); + self.ast.member_expression(member_expr) } // All other are TypeScript syntax. _ => return,