dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-25 04:42:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(transformer/react-jsx): use extend instead of for-in with push (#1236)

Browse source
This commit is contained in:
Dunqing 2023-11-12 19:26:15 +08:00 committed by GitHub
parent 47ba874f4f
commit d62631e239
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/oxc_transformer/src/react_jsx/mod.rs
View file

@ -335,7 +335,7 @@ impl<'a> ReactJsx<'a> {
} }
// The object properties for the second argument of `React.createElement` // The object properties for the second argument of `React.createElement`
let mut properties = self.ast.new_vec_with_capacity(0); let mut properties = self.ast.new_vec();
if let Some(attributes) = attributes { if let Some(attributes) = attributes {
// TODO: compute the correct capacity for both runtimes // TODO: compute the correct capacity for both runtimes
@ -585,9 +585,7 @@ impl<'a> ReactJsx<'a> {
} }
JSXAttributeItem::SpreadAttribute(attr) => match &attr.argument { JSXAttributeItem::SpreadAttribute(attr) => match &attr.argument {
Expression::ObjectExpression(expr) if !expr.has_proto() => { Expression::ObjectExpression(expr) if !expr.has_proto() => {
for object_property in &expr.properties { properties.extend(self.ast.copy(&expr.properties));
properties.push(self.ast.copy(object_property));
}
} }
expr => { expr => {
let argument = self.ast.copy(expr); let argument = self.ast.copy(expr);