dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 04:08:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(ast): comments for enums with no AstKind in generated code for Visit trait (#8796)

Browse source 
"No `AstKind` for this type" comments appear in `walk_*` functions for structs with no `AstKind`. Do the same for enums.
This commit is contained in:
overlookmotel 2025-01-31 01:24:51 +00:00
parent 87a7711d29
commit d4eee5002b
3 changed files with 64 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
crates/oxc_ast/src/generated/visit.rs
View file

@ -1406,6 +1406,7 @@ pub mod walk {
}
pub fn walk_statement<'a, V: Visit<'a>>(visitor: &mut V, it: &Statement<'a>) {
// No `AstKind` for this type
match it {
Statement::BlockStatement(it) => visitor.visit_block_statement(it),
Statement::BreakStatement(it) => visitor.visit_break_statement(it),
@ -1492,6 +1493,7 @@ pub mod walk {
}
pub fn walk_expression<'a, V: Visit<'a>>(visitor: &mut V, it: &Expression<'a>) {
// No `AstKind` for this type
match it {
Expression::BooleanLiteral(it) => visitor.visit_boolean_literal(it),
Expression::NullLiteral(it) => visitor.visit_null_literal(it),
@ -1787,6 +1789,7 @@ pub mod walk {
}
pub fn walk_ts_type<'a, V: Visit<'a>>(visitor: &mut V, it: &TSType<'a>) {
// No `AstKind` for this type
match it {
TSType::TSAnyKeyword(it) => visitor.visit_ts_any_keyword(it),
TSType::TSBigIntKeyword(it) => visitor.visit_ts_big_int_keyword(it),
@ -2027,6 +2030,7 @@ pub mod walk {
visitor: &mut V,
it: &BindingPatternKind<'a>,
) {
// No `AstKind` for this type
match it {
BindingPatternKind::BindingIdentifier(it) => visitor.visit_binding_identifier(it),
BindingPatternKind::ObjectPattern(it) => visitor.visit_object_pattern(it),
@ -2229,6 +2233,7 @@ pub mod walk {
visitor: &mut V,
it: &TSImportAttributeName<'a>,
) {
// No `AstKind` for this type
match it {
TSImportAttributeName::Identifier(it) => visitor.visit_identifier_name(it),
TSImportAttributeName::StringLiteral(it) => visitor.visit_string_literal(it),
@ -2298,6 +2303,7 @@ pub mod walk {
}
pub fn walk_ts_literal<'a, V: Visit<'a>>(visitor: &mut V, it: &TSLiteral<'a>) {
// No `AstKind` for this type
match it {
TSLiteral::BooleanLiteral(it) => visitor.visit_boolean_literal(it),
TSLiteral::NullLiteral(it) => visitor.visit_null_literal(it),
@ -2351,6 +2357,7 @@ pub mod walk {
#[inline]
pub fn walk_ts_tuple_element<'a, V: Visit<'a>>(visitor: &mut V, it: &TSTupleElement<'a>) {
// No `AstKind` for this type
match it {
TSTupleElement::TSOptionalType(it) => visitor.visit_ts_optional_type(it),
TSTupleElement::TSRestType(it) => visitor.visit_ts_rest_type(it),
@ -2428,6 +2435,7 @@ pub mod walk {
#[inline]
pub fn walk_ts_signature<'a, V: Visit<'a>>(visitor: &mut V, it: &TSSignature<'a>) {
// No `AstKind` for this type
match it {
TSSignature::TSIndexSignature(it) => visitor.visit_ts_index_signature(it),
TSSignature::TSPropertySignature(it) => visitor.visit_ts_property_signature(it),
@ -2565,6 +2573,7 @@ pub mod walk {
visitor: &mut V,
it: &TSTypePredicateName<'a>,
) {
// No `AstKind` for this type
match it {
TSTypePredicateName::Identifier(it) => visitor.visit_identifier_name(it),
TSTypePredicateName::This(it) => visitor.visit_ts_this_type(it),
@ -2588,6 +2597,7 @@ pub mod walk {
visitor: &mut V,
it: &TSTypeQueryExprName<'a>,
) {
// No `AstKind` for this type
match it {
TSTypeQueryExprName::TSImportType(it) => visitor.visit_ts_import_type(it),
match_ts_type_name!(TSTypeQueryExprName) => {
@ -2873,6 +2883,7 @@ pub mod walk {
visitor: &mut V,
it: &AssignmentTargetMaybeDefault<'a>,
) {
// No `AstKind` for this type
match it {
AssignmentTargetMaybeDefault::AssignmentTargetWithDefault(it) => {
visitor.visit_assignment_target_with_default(it)
@ -2936,6 +2947,7 @@ pub mod walk {
visitor: &mut V,
it: &AssignmentTargetProperty<'a>,
) {
// No `AstKind` for this type
match it {
AssignmentTargetProperty::AssignmentTargetPropertyIdentifier(it) => {
visitor.visit_assignment_target_property_identifier(it)
@ -3031,6 +3043,7 @@ pub mod walk {
#[inline]
pub fn walk_chain_element<'a, V: Visit<'a>>(visitor: &mut V, it: &ChainElement<'a>) {
// No `AstKind` for this type
match it {
ChainElement::CallExpression(it) => visitor.visit_call_expression(it),
ChainElement::TSNonNullExpression(it) => visitor.visit_ts_non_null_expression(it),
@ -3106,6 +3119,7 @@ pub mod walk {
#[inline]
pub fn walk_class_element<'a, V: Visit<'a>>(visitor: &mut V, it: &ClassElement<'a>) {
// No `AstKind` for this type
match it {
ClassElement::StaticBlock(it) => visitor.visit_static_block(it),
ClassElement::MethodDefinition(it) => visitor.visit_method_definition(it),
@ -3286,6 +3300,7 @@ pub mod walk {
visitor: &mut V,
it: &ObjectPropertyKind<'a>,
) {
// No `AstKind` for this type
match it {
ObjectPropertyKind::ObjectProperty(it) => visitor.visit_object_property(it),
ObjectPropertyKind::SpreadProperty(it) => visitor.visit_spread_element(it),
@ -3506,6 +3521,7 @@ pub mod walk {
#[inline]
pub fn walk_jsx_attribute_name<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXAttributeName<'a>) {
// No `AstKind` for this type
match it {
JSXAttributeName::Identifier(it) => visitor.visit_jsx_identifier(it),
JSXAttributeName::NamespacedName(it) => visitor.visit_jsx_namespaced_name(it),
@ -3514,6 +3530,7 @@ pub mod walk {
#[inline]
pub fn walk_jsx_attribute_value<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXAttributeValue<'a>) {
// No `AstKind` for this type
match it {
JSXAttributeValue::StringLiteral(it) => visitor.visit_string_literal(it),
JSXAttributeValue::ExpressionContainer(it) => {
@ -3538,6 +3555,7 @@ pub mod walk {
#[inline]
pub fn walk_jsx_expression<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXExpression<'a>) {
// No `AstKind` for this type
match it {
JSXExpression::EmptyExpression(it) => visitor.visit_jsx_empty_expression(it),
match_expression!(JSXExpression) => visitor.visit_expression(it.to_expression()),
@ -3568,6 +3586,7 @@ pub mod walk {
#[inline]
pub fn walk_jsx_child<'a, V: Visit<'a>>(visitor: &mut V, it: &JSXChild<'a>) {
// No `AstKind` for this type
match it {
JSXChild::Text(it) => visitor.visit_jsx_text(it),
JSXChild::Element(it) => visitor.visit_jsx_element(it),
@ -3648,6 +3667,7 @@ pub mod walk {
#[inline]
pub fn walk_for_statement_left<'a, V: Visit<'a>>(visitor: &mut V, it: &ForStatementLeft<'a>) {
// No `AstKind` for this type
match it {
ForStatementLeft::VariableDeclaration(it) => visitor.visit_variable_declaration(it),
match_assignment_target!(ForStatementLeft) => {
@ -3870,6 +3890,7 @@ pub mod walk {
}
pub fn walk_declaration<'a, V: Visit<'a>>(visitor: &mut V, it: &Declaration<'a>) {
// No `AstKind` for this type
match it {
Declaration::VariableDeclaration(it) => visitor.visit_variable_declaration(it),
Declaration::FunctionDeclaration(it) => {
@ -3991,6 +4012,7 @@ pub mod walk {
#[inline]
pub fn walk_ts_enum_member_name<'a, V: Visit<'a>>(visitor: &mut V, it: &TSEnumMemberName<'a>) {
// No `AstKind` for this type
match it {
TSEnumMemberName::Identifier(it) => visitor.visit_identifier_name(it),
TSEnumMemberName::String(it) => visitor.visit_string_literal(it),
@ -4028,6 +4050,7 @@ pub mod walk {
visitor: &mut V,
it: &TSModuleDeclarationName<'a>,
) {
// No `AstKind` for this type
match it {
TSModuleDeclarationName::Identifier(it) => visitor.visit_binding_identifier(it),
TSModuleDeclarationName::StringLiteral(it) => visitor.visit_string_literal(it),
@ -4039,6 +4062,7 @@ pub mod walk {
visitor: &mut V,
it: &TSModuleDeclarationBody<'a>,
) {
// No `AstKind` for this type
match it {
TSModuleDeclarationBody::TSModuleDeclaration(it) => {
visitor.visit_ts_module_declaration(it)
@ -4147,6 +4171,7 @@ pub mod walk {
visitor: &mut V,
it: &ImportDeclarationSpecifier<'a>,
) {
// No `AstKind` for this type
match it {
ImportDeclarationSpecifier::ImportSpecifier(it) => visitor.visit_import_specifier(it),
ImportDeclarationSpecifier::ImportDefaultSpecifier(it) => {
@ -4170,6 +4195,7 @@ pub mod walk {
#[inline]
pub fn walk_module_export_name<'a, V: Visit<'a>>(visitor: &mut V, it: &ModuleExportName<'a>) {
// No `AstKind` for this type
match it {
ModuleExportName::IdentifierName(it) => visitor.visit_identifier_name(it),
ModuleExportName::IdentifierReference(it) => visitor.visit_identifier_reference(it),
@ -4232,6 +4258,7 @@ pub mod walk {
visitor: &mut V,
it: &ImportAttributeKey<'a>,
) {
// No `AstKind` for this type
match it {
ImportAttributeKey::Identifier(it) => visitor.visit_identifier_name(it),
ImportAttributeKey::StringLiteral(it) => visitor.visit_string_literal(it),
@ -4274,6 +4301,7 @@ pub mod walk {
visitor: &mut V,
it: &ExportDefaultDeclarationKind<'a>,
) {
// No `AstKind` for this type
match it {
ExportDefaultDeclarationKind::FunctionDeclaration(it) => {
let flags = ScopeFlags::Function;

28
crates/oxc_ast/src/generated/visit_mut.rs
View file

@ -1401,6 +1401,7 @@ pub mod walk_mut {
}
pub fn walk_statement<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Statement<'a>) {
// No `AstType` for this type
match it {
Statement::BlockStatement(it) => visitor.visit_block_statement(it),
Statement::BreakStatement(it) => visitor.visit_break_statement(it),
@ -1499,6 +1500,7 @@ pub mod walk_mut {
}
pub fn walk_expression<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Expression<'a>) {
// No `AstType` for this type
match it {
Expression::BooleanLiteral(it) => visitor.visit_boolean_literal(it),
Expression::NullLiteral(it) => visitor.visit_null_literal(it),
@ -1812,6 +1814,7 @@ pub mod walk_mut {
}
pub fn walk_ts_type<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut TSType<'a>) {
// No `AstType` for this type
match it {
TSType::TSAnyKeyword(it) => visitor.visit_ts_any_keyword(it),
TSType::TSBigIntKeyword(it) => visitor.visit_ts_big_int_keyword(it),
@ -2076,6 +2079,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut BindingPatternKind<'a>,
) {
// No `AstType` for this type
match it {
BindingPatternKind::BindingIdentifier(it) => visitor.visit_binding_identifier(it),
BindingPatternKind::ObjectPattern(it) => visitor.visit_object_pattern(it),
@ -2302,6 +2306,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut TSImportAttributeName<'a>,
) {
// No `AstType` for this type
match it {
TSImportAttributeName::Identifier(it) => visitor.visit_identifier_name(it),
TSImportAttributeName::StringLiteral(it) => visitor.visit_string_literal(it),
@ -2371,6 +2376,7 @@ pub mod walk_mut {
}
pub fn walk_ts_literal<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut TSLiteral<'a>) {
// No `AstType` for this type
match it {
TSLiteral::BooleanLiteral(it) => visitor.visit_boolean_literal(it),
TSLiteral::NullLiteral(it) => visitor.visit_null_literal(it),
@ -2430,6 +2436,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut TSTupleElement<'a>,
) {
// No `AstType` for this type
match it {
TSTupleElement::TSOptionalType(it) => visitor.visit_ts_optional_type(it),
TSTupleElement::TSRestType(it) => visitor.visit_ts_rest_type(it),
@ -2513,6 +2520,7 @@ pub mod walk_mut {
#[inline]
pub fn walk_ts_signature<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut TSSignature<'a>) {
// No `AstType` for this type
match it {
TSSignature::TSIndexSignature(it) => visitor.visit_ts_index_signature(it),
TSSignature::TSPropertySignature(it) => visitor.visit_ts_property_signature(it),
@ -2662,6 +2670,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut TSTypePredicateName<'a>,
) {
// No `AstType` for this type
match it {
TSTypePredicateName::Identifier(it) => visitor.visit_identifier_name(it),
TSTypePredicateName::This(it) => visitor.visit_ts_this_type(it),
@ -2685,6 +2694,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut TSTypeQueryExprName<'a>,
) {
// No `AstType` for this type
match it {
TSTypeQueryExprName::TSImportType(it) => visitor.visit_ts_import_type(it),
match_ts_type_name!(TSTypeQueryExprName) => {
@ -2988,6 +2998,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut AssignmentTargetMaybeDefault<'a>,
) {
// No `AstType` for this type
match it {
AssignmentTargetMaybeDefault::AssignmentTargetWithDefault(it) => {
visitor.visit_assignment_target_with_default(it)
@ -3051,6 +3062,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut AssignmentTargetProperty<'a>,
) {
// No `AstType` for this type
match it {
AssignmentTargetProperty::AssignmentTargetPropertyIdentifier(it) => {
visitor.visit_assignment_target_property_identifier(it)
@ -3155,6 +3167,7 @@ pub mod walk_mut {
#[inline]
pub fn walk_chain_element<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut ChainElement<'a>) {
// No `AstType` for this type
match it {
ChainElement::CallExpression(it) => visitor.visit_call_expression(it),
ChainElement::TSNonNullExpression(it) => visitor.visit_ts_non_null_expression(it),
@ -3236,6 +3249,7 @@ pub mod walk_mut {
#[inline]
pub fn walk_class_element<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut ClassElement<'a>) {
// No `AstType` for this type
match it {
ClassElement::StaticBlock(it) => visitor.visit_static_block(it),
ClassElement::MethodDefinition(it) => visitor.visit_method_definition(it),
@ -3435,6 +3449,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut ObjectPropertyKind<'a>,
) {
// No `AstType` for this type
match it {
ObjectPropertyKind::ObjectProperty(it) => visitor.visit_object_property(it),
ObjectPropertyKind::SpreadProperty(it) => visitor.visit_spread_element(it),
@ -3676,6 +3691,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut JSXAttributeName<'a>,
) {
// No `AstType` for this type
match it {
JSXAttributeName::Identifier(it) => visitor.visit_jsx_identifier(it),
JSXAttributeName::NamespacedName(it) => visitor.visit_jsx_namespaced_name(it),
@ -3687,6 +3703,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut JSXAttributeValue<'a>,
) {
// No `AstType` for this type
match it {
JSXAttributeValue::StringLiteral(it) => visitor.visit_string_literal(it),
JSXAttributeValue::ExpressionContainer(it) => {
@ -3711,6 +3728,7 @@ pub mod walk_mut {
#[inline]
pub fn walk_jsx_expression<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut JSXExpression<'a>) {
// No `AstType` for this type
match it {
JSXExpression::EmptyExpression(it) => visitor.visit_jsx_empty_expression(it),
match_expression!(JSXExpression) => visitor.visit_expression(it.to_expression_mut()),
@ -3744,6 +3762,7 @@ pub mod walk_mut {
#[inline]
pub fn walk_jsx_child<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut JSXChild<'a>) {
// No `AstType` for this type
match it {
JSXChild::Text(it) => visitor.visit_jsx_text(it),
JSXChild::Element(it) => visitor.visit_jsx_element(it),
@ -3836,6 +3855,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut ForStatementLeft<'a>,
) {
// No `AstType` for this type
match it {
ForStatementLeft::VariableDeclaration(it) => visitor.visit_variable_declaration(it),
match_assignment_target!(ForStatementLeft) => {
@ -4076,6 +4096,7 @@ pub mod walk_mut {
}
pub fn walk_declaration<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Declaration<'a>) {
// No `AstType` for this type
match it {
Declaration::VariableDeclaration(it) => visitor.visit_variable_declaration(it),
Declaration::FunctionDeclaration(it) => {
@ -4209,6 +4230,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut TSEnumMemberName<'a>,
) {
// No `AstType` for this type
match it {
TSEnumMemberName::Identifier(it) => visitor.visit_identifier_name(it),
TSEnumMemberName::String(it) => visitor.visit_string_literal(it),
@ -4246,6 +4268,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut TSModuleDeclarationName<'a>,
) {
// No `AstType` for this type
match it {
TSModuleDeclarationName::Identifier(it) => visitor.visit_binding_identifier(it),
TSModuleDeclarationName::StringLiteral(it) => visitor.visit_string_literal(it),
@ -4257,6 +4280,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut TSModuleDeclarationBody<'a>,
) {
// No `AstType` for this type
match it {
TSModuleDeclarationBody::TSModuleDeclaration(it) => {
visitor.visit_ts_module_declaration(it)
@ -4374,6 +4398,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut ImportDeclarationSpecifier<'a>,
) {
// No `AstType` for this type
match it {
ImportDeclarationSpecifier::ImportSpecifier(it) => visitor.visit_import_specifier(it),
ImportDeclarationSpecifier::ImportDefaultSpecifier(it) => {
@ -4403,6 +4428,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut ModuleExportName<'a>,
) {
// No `AstType` for this type
match it {
ModuleExportName::IdentifierName(it) => visitor.visit_identifier_name(it),
ModuleExportName::IdentifierReference(it) => visitor.visit_identifier_reference(it),
@ -4468,6 +4494,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut ImportAttributeKey<'a>,
) {
// No `AstType` for this type
match it {
ImportAttributeKey::Identifier(it) => visitor.visit_identifier_name(it),
ImportAttributeKey::StringLiteral(it) => visitor.visit_string_literal(it),
@ -4510,6 +4537,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut ExportDefaultDeclarationKind<'a>,
) {
// No `AstType` for this type
match it {
ExportDefaultDeclarationKind::FunctionDeclaration(it) => {
let flags = ScopeFlags::Function;

9
tasks/ast_tools/src/generators/visit.rs
View file

@ -356,7 +356,14 @@ impl<'a> VisitBuilder<'a> {
let with_node_events = |tk| {
if KIND_BLACK_LIST.contains(&ident.to_string().as_str()) {
tk
let comment = format!(
"@ No `{}` for this type",
if self.is_mut { "AstType" } else { "AstKind" }
);
quote! {
#![doc = #comment]
#tk
}
} else {
let kind = self.kind_type(&ident);
quote! {