dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(linter): simplify getting ImportDefaultSpecifier (#2453)

Browse source
This commit is contained in:
Dunqing 2024-02-20 16:16:02 +08:00 committed by GitHub
parent d0d0d9d7bb
commit cd48e1e9d9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
crates/oxc_linter/src/rules/nextjs/inline_script_id.rs
View file

@ -1,8 +1,5 @@
use oxc_ast::{
ast::{
Expression, ImportDeclarationSpecifier, JSXAttributeItem, JSXAttributeName,
ModuleDeclaration, ObjectPropertyKind, PropertyKey,
},
ast::{Expression, JSXAttributeItem, JSXAttributeName, ObjectPropertyKind, PropertyKey},
AstKind,
};
use oxc_diagnostics::{
@ -39,8 +36,10 @@ declare_oxc_lint!(
impl Rule for InlineScriptId {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
let AstKind::ModuleDeclaration(ModuleDeclaration::ImportDeclaration(import_decl)) =
node.kind()
let AstKind::ImportDefaultSpecifier(specifier) = node.kind() else {
return;
};
let Some(AstKind::ImportDeclaration(import_decl)) = ctx.nodes().parent_kind(node.id())
else {
return;
};
@ -49,23 +48,8 @@ impl Rule for InlineScriptId {
return;
}
let Some(import_specifiers) = &import_decl.specifiers else { return };
// find default import
let Some(default_import) = import_specifiers.iter().find_map(|import_specifier| {
let ImportDeclarationSpecifier::ImportDefaultSpecifier(import_default_specifier) =
import_specifier
else {
return None;
};
Some(import_default_specifier)
}) else {
return;
};
'references_loop: for reference in
ctx.semantic().symbol_references(default_import.local.symbol_id.get().unwrap())
ctx.semantic().symbol_references(specifier.local.symbol_id.get().unwrap())
{
let node = ctx.nodes().get_node(reference.node_id());