dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(ast): fix serializing rest elements (#2652)

Browse source 
Fix a mistake I made in #2567. Length that `serialize_seq` is called
with should only be `+1` if there is a rest element being added on the
end.

Makes no difference for serializing to JSON, as JSON serializer doesn't
use the `len` value, but still better to get it right.
This commit is contained in:
overlookmotel 2024-03-10 02:03:05 +00:00 committed by GitHub
parent 32303b20fb
commit cc5be633f2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
crates/oxc_ast/src/serialize.rs
View file

@ -227,13 +227,15 @@ impl<'a, 'b, E, R> ElementsAndRest<'a, 'b, E, R> {
impl<'a, 'b, E: Serialize, R: Serialize> Serialize for ElementsAndRest<'a, 'b, E, R> {
fn serialize<S: Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
let mut seq = serializer.serialize_seq(Some(self.elements.len() + 1))?;
for element in self.elements {
seq.serialize_element(element)?;
}
if let Some(rest) = self.rest {
let mut seq = serializer.serialize_seq(Some(self.elements.len() + 1))?;
for element in self.elements {
seq.serialize_element(element)?;
}
seq.serialize_element(rest)?;
seq.end()
} else {
self.elements.serialize(serializer)
}
seq.end()
}
}