dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-24 12:21:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf(semantic): reduce memory copies (#4216)

Browse source 
Reduce memory copies when resolving references in `Semantic`.

If parent scope has no unresolved references for `name`, there is no need to generate a new `Vec<ReferenceId>` for `name` and copy in contents from current scope. Just move the existing `Vec` to the parent.
This commit is contained in:
overlookmotel 2024-07-12 02:05:22 +00:00
parent ef4c1f4e32
commit cb15303644
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/oxc_semantic/src/builder.rs
View file

@ -389,8 +389,10 @@ impl<'a> SemanticBuilder<'a> {
self.symbols.references[*reference_id].set_symbol_id(symbol_id); self.symbols.references[*reference_id].set_symbol_id(symbol_id);
} }
self.symbols.resolved_references[symbol_id].extend(reference_ids); self.symbols.resolved_references[symbol_id].extend(reference_ids);
} else if let Some(parent_reference_ids) = parent_refs.get_mut(&name) {
parent_reference_ids.extend(reference_ids);
} else { } else {
parent_refs.entry(name).or_default().extend(reference_ids); parent_refs.insert(name, reference_ids);
} }
} }
} }