dan/oxc
1
0
Fork 0
mirror of https://github.com/danbulant/oxc synced 2026-05-19 12:19:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(traverse): use symbol_id etc methods (#7129)

Browse source 
Utilize the methods added in #7127 in `oxc_traverse`.
This commit is contained in:
overlookmotel 2024-11-05 02:25:28 +00:00
parent fdfd9a4378
commit cacfb9b326
3 changed files with 9 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
crates/oxc_traverse/src/context/bound_identifier.rs
View file

@ -50,9 +50,8 @@ impl<'a> BoundIdentifier<'a> {
}
/// Create `BoundIdentifier` from a `BindingIdentifier`
#[expect(clippy::missing_panics_doc)]
pub fn from_binding_ident(ident: &BindingIdentifier<'a>) -> Self {
Self { name: ident.name.clone(), symbol_id: ident.symbol_id.get().unwrap() }
Self { name: ident.name.clone(), symbol_id: ident.symbol_id() }
}
/// Create `BindingIdentifier` for this binding

5
crates/oxc_traverse/src/context/mod.rs
View file

@ -538,10 +538,7 @@ impl<'a> TraverseCtx<'a> {
ident: &IdentifierReference<'a>,
flags: ReferenceFlags,
) -> IdentifierReference<'a> {
let reference =
self.symbols().get_reference(ident.reference_id.get().unwrap_or_else(|| {
unreachable!("IdentifierReference must have a reference_id");
}));
let reference = self.symbols().get_reference(ident.reference_id());
let symbol_id = reference.symbol_id();
self.create_reference_id(ident.span, ident.name.clone(), symbol_id, flags)
}

14
crates/oxc_traverse/src/context/scoping.rs
View file

@ -369,13 +369,13 @@ impl TraverseScoping {
pub fn is_static(&self, expr: &Expression) -> bool {
match expr {
Expression::ThisExpression(_) | Expression::Super(_) => true,
Expression::Identifier(ident) => self
.symbols
.get_reference(ident.reference_id.get().unwrap())
.symbol_id()
.is_some_and(|symbol_id| {
self.symbols.get_resolved_references(symbol_id).all(|r| !r.is_write())
}),
Expression::Identifier(ident) => {
self.symbols.get_reference(ident.reference_id()).symbol_id().is_some_and(
|symbol_id| {
self.symbols.get_resolved_references(symbol_id).all(|r| !r.is_write())
},
)
}
_ => false,
}
}